Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp2616274pxb; Fri, 5 Nov 2021 01:28:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxqGi4ZTkx6jJBt6r2qv8CZZy99zYFM9HGmEC8D4eKFbbPAZpmM+kmQEh/myp47EZfgFzys X-Received: by 2002:a17:907:7e90:: with SMTP id qb16mr66561473ejc.79.1636100894572; Fri, 05 Nov 2021 01:28:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1636100894; cv=none; d=google.com; s=arc-20160816; b=jD/Ll1/m0hNRDOdFTO5/UjnWap3aOsQLVHBq5vfh63Pqalnp7Ds1cgTj0KToLWsKfq RBExJm2liVu3xceYlojfK5m+xYBA49HYiIGw/8xU1UC0PiSdK+Vhpc+gOdG+O3opd8pP l2nM8Gb2hPkKwoSWh61ro9r5EbE767ZGPFQXAQkzsB6nWn5Pz0PxpFWgJO1Ouo5xiXQ4 Z0v2WJvxZJu01fags+A369emGsh7oqHXcYHDREjkLomRHTRhE171HhAXW6bZIhJGECZV aFRsWMt808qtSgRWaQd2aQT3p2UnNC3WKIdD7NBsuLZYvrBRTaRp3aDDxtUndJmPap9j aZsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:subject :from:references:to:content-language:cc:user-agent:mime-version:date :message-id; bh=EvODGzASumrPEpdtpwSx9MtcCjJLyJJUgv52qaZ6iFQ=; b=pkLUuv05lsgIi7oTtUJf5g6si1M3yXRgcVGlZpv5lJgK6Km9csUObr3OYGqw5QF94q iuj314hiSYYohOBqfOZMWX/b4o3HfcpX7tBUixyYgj8eTC256IGVGx9L2XU/4A9YXMC1 NVorjiMCUwcwmH/RDBdVY1cYGKajqekLoIj3O434vD09MC4mEt9DcYAivcH/ooK1V89t bEdRECz2NUmHDid8gzY1+azOSpt1wY6I1PrE4f0XmYFFygHx571CaCFNp7AOiu8eUCJI SMkkPccwoVbGO9SMKLG+2FNIu7NuRRNSGx8OGdwcaEkM7t8BvEDhspZaVQ5GfJN62tUf KrtQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id eb9si6170095edb.619.2021.11.05.01.27.49; Fri, 05 Nov 2021 01:28:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232467AbhKEIHL (ORCPT + 99 others); Fri, 5 Nov 2021 04:07:11 -0400 Received: from mga02.intel.com ([134.134.136.20]:22490 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229473AbhKEIHK (ORCPT ); Fri, 5 Nov 2021 04:07:10 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10158"; a="219057965" X-IronPort-AV: E=Sophos;i="5.87,210,1631602800"; d="scan'208";a="219057965" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Nov 2021 01:04:30 -0700 X-IronPort-AV: E=Sophos;i="5.87,210,1631602800"; d="scan'208";a="490253444" Received: from blu2-mobl3.ccr.corp.intel.com (HELO [10.254.213.18]) ([10.254.213.18]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Nov 2021 01:04:28 -0700 Message-ID: <716e2940-a426-60d7-e4a7-9ff6187a6af8@linux.intel.com> Date: Fri, 5 Nov 2021 16:04:25 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.1 Cc: baolu.lu@linux.intel.com, Will Deacon , Linux Kernel Mailing List , iommu Content-Language: en-US To: Joerg Roedel , Linus Torvalds References: From: Lu Baolu Subject: Re: [git pull] IOMMU Updates for Linux v5.16 In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/11/5 15:35, Joerg Roedel wrote: > On Thu, Nov 04, 2021 at 11:10:53AM -0700, Linus Torvalds wrote: >> That too seems to be stale and unused since commit 9bfecd058339 >> ("x86/cpufeatures: Force disable X86_FEATURE_ENQCMD and remove >> update_pasid()") >> >> I left it alone because I didn't want to do any extra development in >> the merge commit itself, but it looks to me like there's some room for >> more cleanips. No? > > Yes, looks like this define is unused now. I talk to Baolu whether this > can be cleaned up too, Baolu? Yes. PASID_DISABLED is unused after commit 9bfecd058339 ("x86/cpufeatures: Force disable X86_FEATURE_ENQCMD and remove update_pasid()"). and commit 00ecd5401349a ("iommu/vt-d: Clean up unused PASID updating functions") Best regards, baolu