Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <a3665295-6415-0c0b-f53d-87f658150991@opensynergy.com>
Date:   Fri, 5 Nov 2021 10:55:02 +0200
Subject: Re: [PATCH v7 3/3] iio: test: Add test for IIO_VAL_INT_64.
Content-Language: en-US
To:     Lars-Peter Clausen <lars@metafoo.de>,
        Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     Vasyl.Vavrychuk@opensynergy.com, jbhayana@google.com,
        Jonathan Cameron <jic23@kernel.org>,
        linux-iio <linux-iio@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
References: <CAHp75Vd7Wwka37w-6QTXT9vv13bPiygKryBhQTnyvtTpCNU9qw@mail.gmail.com>
 <20211102073300.13376-1-andriy.tryshnivskyy@opensynergy.com>
 <CAHp75VfafpEBccivDRC2AVVJbZL2Kdq2KeR0yf_nwTtDTxvDkg@mail.gmail.com>
 <6d909cca-46a9-3f40-5d4d-97ef2fbe33e9@opensynergy.com>
 <0c449b88-a6fb-76ca-5c13-807f7728f1da@metafoo.de>
From:   Andriy Tryshnivskyy <andriy.tryshnivskyy@opensynergy.com>
In-Reply-To: <0c449b88-a6fb-76ca-5c13-807f7728f1da@metafoo.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dFAwaVBRM1N6MVZlL2c3NFdnNWNBRXpQVUdQckZrU1ZyZGF3Y1ZOWnpvZFkr?=
 =?utf-8?B?Nm5HdEREZmU3b1hIL243RTJaYmF4TmE1VVZhdFFpUFZsREo5cS9rTVZobncw?=
 =?utf-8?B?dXRidisrTXhxaktKNDdvZ1VQOUFrYWtqancralZyaDhDR3JiaE5MT3dIN2Nh?=
 =?utf-8?B?cG1iMDN3ZVZFeUM4Y3JHRk13ZkFReCtFWHJsMS9oc1pSRTEyMHFzMm9qdkF0?=
 =?utf-8?B?UkFNRjZnWE5sd1FQWFcvRUlwRzNXb0pzNytYcW14clV0Nk0vRW9xSWlsTGVp?=
 =?utf-8?B?WnZkL1BUR1JzZ08vVGF5ZmttRUZ1RVQvUXVaQlhVYk5zWlBkSkJrcHlBdjBm?=
 =?utf-8?B?TTZUNm5LNVRvV3dSdVJackVBQzBEcmgxbW14Qm1UMWdrb2JmWWtMcERRR29z?=
 =?utf-8?B?MWtDd2o0VDhUWG1FYlVDc0Uva2dTT011bnJNNHNpYzUwMU16OXpaNVhnRThO?=
 =?utf-8?B?WnNlaVdiUVpZZTZvMTFOZWF2c0NRSFdRTXVJYmNQZjJQc1FPWExDaVBJc1E0?=
 =?utf-8?B?QU5WNGp6ZE9pbVlaM2ZmUkh0TTZmUDUvSzNnRzloWXhydnQ1RlZMazlzSmVT?=
 =?utf-8?B?aFo0MDVUWFlkbHFrOTYrSXhtOUVMcFYzLzRNa055bWR0eVR1WTdERExpVk1o?=
 =?utf-8?B?ME5ESVhCYlJNMG5CWVU2Mkx0Y1RKd21nOGN6SEw2Q1NzUHg5cXA3U0g1T3o4?=
 =?utf-8?B?bmF0ZnZrSnQxdXNtS3lnNmExV1dUVDVETzRWWWFRVGlJRGtRRVZkNjNmUENG?=
 =?utf-8?B?bElRb1RNaWs0OEQwK01CVXowdkk3azMwWnNoTjFpeStJZCtXdHFlNkE5ci9I?=
 =?utf-8?B?RFRtcEZlUkY0RWdLMExvaFlCd1dWTEsxa09JMXg0dHpPVUdrWUVJQU92WEFj?=
 =?utf-8?B?eEVTQ3FvVjlxMjVuaWdIL3NSaXpOZVQwUmc2SnVBS05iTVZQL3A2SDFRbzdh?=
 =?utf-8?B?MnRPSkRKTkwzcFBkeG9HZ0VlUzl4bVZNRFRPTkUvR054VERlT1lrRHExbmc1?=
 =?utf-8?B?QXcvQlA1SjFmbWZpVUQ1OFplZnE1Uzl2WTlrWVBhY1pFV1hreFdQTnhDWVBL?=
 =?utf-8?B?eE1EdnUvOW9MUHFEeEpNRDZQLzBjbStYYXdCVFdCdC90NTZ5N0N5MFVGdU9B?=
 =?utf-8?B?cHRPQk1LaDBDYXEwRm8wMVhra2swOVRPYjJnWEkxSk1XbVpsSW83Wmw4Smdz?=
 =?utf-8?B?eFY2bFEwSXFuYkx3V1IxRWdRK0djOVV3aTRFZlpEVDd2ZitXMGpYdVVtWUpz?=
 =?utf-8?B?YVNydzZ5QU1jdnBqRnNoV1V1ZVoxc0paYVpSYStjck1lN1dBZUU2aTRSVjRF?=
 =?utf-8?B?SHZqMlhobWp1WHFkeVZDWGl6MUlvZXdNeE9MQ0tsZlUzbjRTbVJnSlFuUDlI?=
 =?utf-8?B?NGRwVlljSHBmT2ViYmRXM2doTlFmREo5Y3F3bHJHVHNzeDR6R0dxV0R5cjVR?=
 =?utf-8?B?WStCU09ISUZTTDV4aUc5cFFMQmR0TkNWa1NxTkNEVlF0SzNLSUdWS1NaUlJP?=
 =?utf-8?B?UlJVdWpNODMzQUtsbXZ2bW5QeHA5NEE4NzVqZ1dsUnVOYkkxOWJtclJmUDhv?=
 =?utf-8?B?NWNBRTB3Q1hvVEFlUFpoMkZyajdmbXhGeHlNMGtSYjQrTDA5ZDNrdXlSYlJB?=
 =?utf-8?B?OU5nOG9WdTViN1k5czZOTG1kN1R2SjIxZkNpK29HVXErb1NsWnhkWER0Z2Yw?=
 =?utf-8?B?akpMczhBQUhGQ0FSdCtKc2pGRElsVU4zQnJkRTh5VlgwMTF1bHh0dHBvcW9o?=
 =?utf-8?B?cElXcS9ZUWhIMlhjNmZLUi9CZlFFTTVPcWlyK2tUOUpTM1NMTE81dkNkSHZI?=
 =?utf-8?B?OEdvRHk5a0xDZTZuOWdIUVVzYXJIM0dhbTNEK0xDTUp6czdFYS91Qlp5UVBX?=
 =?utf-8?B?aGFEdU91SXZ4ZXVrMHpCMzR4NmxZdWh3R29xTUZiZ0tRQTF3TFR5YnFMQ3BF?=
 =?utf-8?B?dFJPK2NQTi9OdFhHM04zYUFNZVVYUWlqQXVDZDdDNVVNTVlEZ2R1UDJiQ2Ns?=
 =?utf-8?B?cnhOdVFrY0krWGhBeUFwc0d2dU16MUFHZkZDWTBIcEtDM1BFU2RXOEFGb0VK?=
 =?utf-8?B?aFR3aUxsVFZVeFJodDcvd3Eydkd2UHRVVjRFQUhRVHEzWGV5enJEKzFLLzBY?=
 =?utf-8?B?bFlRQktOVVl6bndkM1ZhdzlXQnZoanBKYVlCTTZ4SVZkdmYxZEdwMGRLRVF1?=
 =?utf-8?Q?FhUjCBPduAb0rwIgbdJRNmQ=3D?=
X-OriginatorOrg: opensynergy.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 487cf7b8-afdb-4aec-820f-08d9a039f556
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6359.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Nov 2021 08:55:04.0262
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 800fae25-9b1b-4edc-993d-c939c4e84a64
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iHHkoqz/wAfaAgCCAvHAVWT3iGw0I8P+xqumwvINMPiyqxliPnvkkswMRsSV2/NsHRdsqadJ5jXhu7O9FaE76g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0402MB3733
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 05.11.21 10:50, Lars-Peter Clausen wrote:
> CAUTION: This email originated from outside of the organization.
> Do not click links or open attachments unless you recognize the sender 
> and know the content is safe.
>
>
> On 11/5/21 9:45 AM, Andriy Tryshnivskyy wrote:
>> On 02.11.21 10:11, Andy Shevchenko wrote:
>>
>>> CAUTION: This email originated from outside of the organization.
>>> Do not click links or open attachments unless you recognize the
>>> sender and know the content is safe.
>>>
>>>
>>> On Tue, Nov 2, 2021 at 9:33 AM Andriy Tryshnivskyy
>>> <andriy.tryshnivskyy@opensynergy.com> wrote:
>>> Now it's good with format, but you have missed the commit message.
>>
>> Actually commit massage contains a header only (no body message), but
>> I can add body message too.
>> Thanks!
>>
>>>
>>>> Signed-off-by: Andriy Tryshnivskyy
>>>> <andriy.tryshnivskyy@opensynergy.com>
>>> ...
>>>
>>>> +static void iio_test_iio_format_value_integer_64(struct kunit *test)
>>>> +{
>>>> +       char *buf = kunit_kmalloc(test, PAGE_SIZE, GFP_KERNEL);
>>> Shouldn't this be checked against NULL?
>>
>> Good question. Truly speaking I've made new test similar to other. And
>> no other tests has a check for NULL.
>>
> The other tests not having it is my fault. There should be a
> KUNIT_ASSERT_NOT_ERR_OR_NULL(test, buf) under the allocation.
>
Understood. Then If you wouldn't mind I will add assert to other tests too.