Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 5 Nov 2021 09:52:13 +0100
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Haimin Zhang <tcs.kernel@gmail.com>
Cc:     linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
        Haimin Zhang <tcs_kernel@tencent.com>,
        TCS Robot <tcs_robot@tencent.com>
Subject: Re: [PATCH 2/2] USB: ehci_brcm_hub_control: replace wIndex-1 with
 temp
Message-ID: <YYTwveXGgNKXCfpk@kroah.com>
References: <20211105083357.29715-1-tcs_kernel@tencent.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211105083357.29715-1-tcs_kernel@tencent.com>
Precedence: bulk

On Fri, Nov 05, 2021 at 04:33:57PM +0800, Haimin Zhang wrote:
> In function `ehci_brcm_hub_control`, like following code,  
> it filters out the case where the upper byte of wIndex is nonzero, 
> so it need be replaced with temp.

I do not understand this text, can you try to reword it?

And you have trailing whitespace.

And why use `?

> ```

What is this for?  Changelog comments are not in markdown format.

> 	if ((typeReq == GetPortStatus) &&
> 	    (wIndex && wIndex <= ports) &&       // need to be replaced

What does this comment mean?

> 	    ehci->reset_done[wIndex-1] &&
> 	    time_after_eq(jiffies, ehci->reset_done[wIndex-1]) &&
> 	    (ehci_readl(ehci, status_reg) & PORT_RESUME)) {
> ```
> 
> Signed-off-by: Haimin Zhang <tcs_kernel@tencent.com>
> Reported-by: TCS Robot <tcs_robot@tencent.com>

Again, lines need to be in different order, and your from: line is not
correct.

Also, you need an individual email address, not a group email alias for
your contributions.  We work with individuals, not groups.


> ---
>  drivers/usb/host/ehci-brcm.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/host/ehci-brcm.c b/drivers/usb/host/ehci-brcm.c
> index a1e3290e5459..efcfca162126 100644
> --- a/drivers/usb/host/ehci-brcm.c
> +++ b/drivers/usb/host/ehci-brcm.c
> @@ -73,9 +73,9 @@ static int ehci_brcm_hub_control(
>  	 * of RESUME
>  	 */
>  	if ((typeReq == GetPortStatus) &&
> -	    (wIndex && wIndex <= ports) &&
> -	    ehci->reset_done[wIndex-1] &&
> -	    time_after_eq(jiffies, ehci->reset_done[wIndex-1]) &&
> +	    (temp < ports) &&

Where did temp come from?

thanks,

greg k-h