Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp2649558pxb; Fri, 5 Nov 2021 02:13:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwwjykGSawsV9f6vRBMtmDBdc8GseCjwD5j1yr4BXPmPUcUZyNuz9FuxVzYWRCF0y1s1TA7 X-Received: by 2002:a02:2b06:: with SMTP id h6mr8022149jaa.144.1636103617406; Fri, 05 Nov 2021 02:13:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1636103617; cv=none; d=google.com; s=arc-20160816; b=U/NPtgIh5aCDBFmcfqZdWxYRmTBf4dHi5dCIAQVRQnGdwiTd/KVZycCoOjlfKkX16f RddyudTLgMDR4rLC/gkzUSgpPdQU3MqQxiEyVh8AAnL+W5DBLFN/IE0c+Pay/EFAlOsQ l4yCdxJ7jx5VbiA4QMyp95S3/+f9H26RHHwgfXeGCzQckJBC4plQg1ZPhQz6GNmn+FqL Z8MC/EVN80zCiU7ZrYCQFk5tvAj0bbp7jUm6LxnhVdCidy7CfnRF8PdtYOybRL5t9wLY ID698fwN19HoNQptgzOc2XNinBYRJUJiziqVO3T2T1p/qa+ZhcACfCR0zZ2y015p2hvr a9aw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ytqJC3tzZimA/vKcRado/QdQBzzBwoUDJjRTyS4f9aA=; b=gOkZfCRvdz0tDf3aWf4ThemhzhYKfsclqY0E/MCQLM+Xv+KkhLTXvc4yVIgfaYiT4q oZbV/sr3Pqa0ovxuO8Zoyxjfpw1zAhNCY3oPuafj5G/mZRRknMCjBINLHfPYMtMMA/gu K8idQPFMqTC00T8+VcWQQhAZeVUSfWgpEwIRw/3hfdm9gjEbbR5C26Eq6Y/WtYLm2EkT 1tTycjpKDC/0jam76hokJneJm0f8I2WyhsrrIZn4Bm2aS7UxndtrR94vuuH8gznbCE8r fvtytuPPbHJENmwgnEyBWs/viRQFA9BvqkatTCPIod4nWT06YoAtjBhbYt3koSJtj7Gb Oufw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@goldelico.com header.s=strato-dkim-0002 header.b=jBH7QDTr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q17si10455789jah.106.2021.11.05.02.13.25; Fri, 05 Nov 2021 02:13:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@goldelico.com header.s=strato-dkim-0002 header.b=jBH7QDTr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232923AbhKEJJI (ORCPT + 99 others); Fri, 5 Nov 2021 05:09:08 -0400 Received: from mo4-p03-ob.smtp.rzone.de ([85.215.255.100]:31809 "EHLO mo4-p03-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232839AbhKEJIz (ORCPT ); Fri, 5 Nov 2021 05:08:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1636103155; s=strato-dkim-0002; d=goldelico.com; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=ytqJC3tzZimA/vKcRado/QdQBzzBwoUDJjRTyS4f9aA=; b=jBH7QDTr7g+eR7GD+GQ5tp/rN31LiCz0PazLAjszxI+5qTXi4kcuIF7vo/iz3HNp21 PFd7/Kg6/OldVyrnFqPDBPP0krA+ldkRV1g82STC5sTXsgebkU/2Z51nmiwXfQcZyjB3 0pA0C5VSXwgsY7CBW7KJJ2wWB4V4O45wkKhqi0QSzweV5m9xV0cWD7FWnS39F4SOTePl VBdAU9UNgttvNd/fq/Bu+Tgia60EXnWYaTzxMywfDpRBB+XumHWxmLE0H7NDwwXjNqjY scRCjHZ8hBkMMr/UYr4nDVMhpPzC1TsVD2wqfV6GstaobF+y/kjndisnifFgr8ObMCGx 9TcQ== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":JGIXVUS7cutRB/49FwqZ7WcJeFKiMhflhwDubTJ9o12DNOsPj0lByOdfL1X0" X-RZG-CLASS-ID: mo00 Received: from iMac.fritz.box by smtp.strato.de (RZmta 47.34.1 DYNA|AUTH) with ESMTPSA id 902c63xA595s8uP (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Fri, 5 Nov 2021 10:05:54 +0100 (CET) From: "H. Nikolaus Schaller" To: Ulf Hansson , =?UTF-8?q?J=C3=A9r=C3=B4me=20Pouiller?= , Avri Altman , Shawn Lin , Linus Walleij , Tony Lindgren , Bean Huo Cc: notasas@gmail.com, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, letux-kernel@openphoenux.org, kernel@pyra-handheld.com, "H. Nikolaus Schaller" Subject: [RFC v4 6/6] mmc: host: omap_hsmmc: revert special init for wl1251 Date: Fri, 5 Nov 2021 10:05:51 +0100 Message-Id: <229fef6d6c3956b108b040fc34e8c8f3c710f377.1636103151.git.hns@goldelico.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Replaces: commit f6498b922e57 ("mmc: host: omap_hsmmc: add code for special init of wl1251 to get rid of pandora_wl1251_init_card") Requires: commit ("mmc: core: transplant ti,wl1251 quirks from to be retired omap_hsmmc") After moving the wl1251 quirks from omap_hsmmc_init_card() to wl1251_quirk() and sdio_card_init_methods[] we can remove omap_hsmmc_init_card() completely. This also removes the specialization on the combination of omap_hsmmc and wl1251. Related-to: commit f6498b922e57 ("mmc: host: omap_hsmmc: add code for special init of wl1251 to get rid of pandora_wl1251_init_card") Related-to: commit 2398c41d6432 ("omap: pdata-quirks: remove openpandora quirks for mmc3 and wl1251") Related-to: commit f9d50fef4b64 ("ARM: OMAP2+: omap3-pandora: add wifi support") Signed-off-by: H. Nikolaus Schaller --- drivers/mmc/host/omap_hsmmc.c | 36 ----------------------------------- 1 file changed, 36 deletions(-) diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index 6960e305e0a39..9749639ea8977 100644 --- a/drivers/mmc/host/omap_hsmmc.c +++ b/drivers/mmc/host/omap_hsmmc.c @@ -1504,41 +1504,6 @@ static void omap_hsmmc_set_ios(struct mmc_host *mmc, struct mmc_ios *ios) omap_hsmmc_set_bus_mode(host); } -static void omap_hsmmc_init_card(struct mmc_host *mmc, struct mmc_card *card) -{ - struct omap_hsmmc_host *host = mmc_priv(mmc); - - if (card->type == MMC_TYPE_SDIO || card->type == MMC_TYPE_SD_COMBO) { - struct device_node *np = mmc_dev(mmc)->of_node; - - /* - * REVISIT: should be moved to sdio core and made more - * general e.g. by expanding the DT bindings of child nodes - * to provide a mechanism to provide this information: - * Documentation/devicetree/bindings/mmc/mmc-card.txt - */ - - np = of_get_compatible_child(np, "ti,wl1251"); - if (np) { - /* - * We have TI wl1251 attached to MMC3. Pass this - * information to the SDIO core because it can't be - * probed by normal methods. - */ - - dev_info(host->dev, "found wl1251\n"); - card->quirks |= MMC_QUIRK_NONSTD_SDIO; - card->cccr.wide_bus = 1; - card->cis.vendor = 0x104c; - card->cis.device = 0x9066; - card->cis.blksize = 512; - card->cis.max_dtr = 24000000; - card->ocr = 0x80; - of_node_put(np); - } - } -} - static void omap_hsmmc_enable_sdio_irq(struct mmc_host *mmc, int enable) { struct omap_hsmmc_host *host = mmc_priv(mmc); @@ -1667,7 +1632,6 @@ static struct mmc_host_ops omap_hsmmc_ops = { .set_ios = omap_hsmmc_set_ios, .get_cd = mmc_gpio_get_cd, .get_ro = mmc_gpio_get_ro, - .init_card = omap_hsmmc_init_card, .enable_sdio_irq = omap_hsmmc_enable_sdio_irq, }; -- 2.33.0