Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <6d909cca-46a9-3f40-5d4d-97ef2fbe33e9@opensynergy.com>
Date:   Fri, 5 Nov 2021 10:45:26 +0200
Subject: Re: [PATCH v7 3/3] iio: test: Add test for IIO_VAL_INT_64.
Content-Language: en-US
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     Vasyl.Vavrychuk@opensynergy.com, jbhayana@google.com,
        Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        linux-iio <linux-iio@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
References: <CAHp75Vd7Wwka37w-6QTXT9vv13bPiygKryBhQTnyvtTpCNU9qw@mail.gmail.com>
 <20211102073300.13376-1-andriy.tryshnivskyy@opensynergy.com>
 <CAHp75VfafpEBccivDRC2AVVJbZL2Kdq2KeR0yf_nwTtDTxvDkg@mail.gmail.com>
From:   Andriy Tryshnivskyy <andriy.tryshnivskyy@opensynergy.com>
In-Reply-To: <CAHp75VfafpEBccivDRC2AVVJbZL2Kdq2KeR0yf_nwTtDTxvDkg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bXYyMmY2SlNaZGdBMGxHbVozaUJwdGJnS3NaMlRnNGdsZCtrRi8vbXo1SWxn?=
 =?utf-8?B?YmQ0bDczWCszckQ5aWd3VGZ2R242dHE0Uk1yc2IvV3hXNEN6RVp3QTBqUkk0?=
 =?utf-8?B?N1V2cXNPUkJKc1ZzelpFV3NZWjJnN29CK3MrRHFnUmdmSTVMK0RKS3I2OXRq?=
 =?utf-8?B?VjJOZUJnVVlsa04rNkJkQXdTdkpCNlFPZmM1U3UyMCtUTmgxb0M1SWdBSmdQ?=
 =?utf-8?B?TytBb0VMQlU3eWxnRkNzS3JnNmhIeTQxajk4ZVhheHZwaHdBTVhQZ3phbXpq?=
 =?utf-8?B?bXdUQWFlYlFqZEtYOGdNSjJsWHVpNzBCMEtXb1FHRHErNHFRWUM2R0VFTWJi?=
 =?utf-8?B?Mnl3b0VPbktJS3RZd2piSVZVbnVkcWlaajJHMHVxMFlidGdZUHZqdXc4MWpW?=
 =?utf-8?B?bnI2b0Z0Z0hTNGNMbEVrSkNqOWkyU2I3a0VpbVZrazIyUTFFZmIxb0EyZjU3?=
 =?utf-8?B?S2xjd20xem5qUnNsRjFOQmFSakFzSTY0WVdzUjlkc0E4WDcrWklKYVB1Sk5n?=
 =?utf-8?B?WkZVZHZ0SklpazlnYnJ1S0d3WUdEa0sxYWt0YnhnWDh5dTVBeERuMUZkcS9W?=
 =?utf-8?B?dTZZdXJkTU1NblYxZ2ppWmNtRk83V1BtWUJWZUoveDIxMVN0RmZLL0NPSzY4?=
 =?utf-8?B?bzdCZUx2SXJHNEVCbEVxdGhQTi9VQ1UydWcvNHZhREVjdWZoa0lNbXp5RjU3?=
 =?utf-8?B?L3hETWpzZXdOVTdyRndkMExOR3pmOEpHNmprMFZkWFpaS2U0QzNpNUJ0Wjdq?=
 =?utf-8?B?S1pTRVN3UjZodkhlNTVKVkNtZTI4c2ZOeTBWQnFBS1N1V2EvSGJhWEJjampF?=
 =?utf-8?B?MlJOcDBoS0VKTjJEdkVBUkhtWTQySytUSlRUeVE4eXhTV2pTYi9CQkpVcDNx?=
 =?utf-8?B?a0FDMmt0b2ZZOFJYaENlbXdQN05hVkp3bFFsRTBOWnVvT2JrWDBOVTlkZXFs?=
 =?utf-8?B?QzJCalNvREFBUjJ1cjh1TkJDQ3hFQlBna2FsNWgybVd4TEVmQjVxNGNGMm1K?=
 =?utf-8?B?RlpkelUwOUppNkpic1hKUlZnZUFYcGhRUDlqMHpSZWltTzZCV2VPSHNZTWF5?=
 =?utf-8?B?VE01Nm5NZmRja3VCeU5uMXBCaDlPUDN0ckZOeFFCOGtHVGlmd0dSZzIzVUhv?=
 =?utf-8?B?eHJ3eTdkNVYzZkxrVzBFd2RuL0tLMG82dm9mUzBJSDFQeDNYOXRNZTlHcmJC?=
 =?utf-8?B?SHFQWVZ0VStqYjBLdEVxNmpHWU1EcTlyUjNUdnZNYS9nYXVJQlgxSUE0SlRJ?=
 =?utf-8?B?OXhvZ0FYY2d1Z1RKRjdRUjRyeGVHcHU2ZHYxOFBnMG5JajdYd09GSVpkZTJM?=
 =?utf-8?B?UVhXL0FFMDRxRmxiY0ZjNU5QZEFZMkF2M3ZsM1lDQmJ1cUo3OThmUTljL0ZS?=
 =?utf-8?B?SXNsaGc3aXhXL2hFM0J0eVZHU2JkY1FRVEs3N3VxdWhCZDQxMlJIUnB6akZM?=
 =?utf-8?B?Ni9tRG45VGJ6VDBPOU53Ym9ueGVJYkdJZ0owS0JSeDVqQ2YvdnJIdStuanBD?=
 =?utf-8?B?alRjeHNZYm5FRS95UHQvQTZ0bUNDMU42SUJ4K2U4QWJCYmRUSjE2aVRXeTMx?=
 =?utf-8?B?YXJ6MVdSWUs3eWFKRGt6QUMzbVVpSEU2anZ5VG1OM3B0eEV3WGw4SE1rTzRv?=
 =?utf-8?B?ME5WYmFIbTBEdkhITVdWcWRFdTVERzhLL2MwTWJpNE5lcm1wc2F5c0QvOTVh?=
 =?utf-8?B?U0xJUlJ2VVZvTUIzdlREb2o3VTRVTzRhYTQrWnBjOHBkOHhOZjZoZGkrelpu?=
 =?utf-8?B?WGVzRUFZVGdSclJKcE9YeiszalhiWnV3UnpuK2ZldDk4anpLOXJGREo3b3A2?=
 =?utf-8?B?bDBuMEhVV2FIRnVuV2lJK29YcTZYbjFsSms4ekc4eS9LbWtsRGgzQWNPTXZy?=
 =?utf-8?B?VFBJVjlXM2JmYllhZFllVFBaT0VCcjVpT3ZCUEY5OFF0MWIwS0xSWlQwNktP?=
 =?utf-8?B?Zm9UWFc5VFBWV1JvUi9pUmY3cnZiUGtoNGpyM1Fpa0ZZTlBmRmZLMnRZNHZq?=
 =?utf-8?B?ZW1UQ0VsZ2JZWFVnZFlJVWo1akdYQnI5bEQrRG1KMzNEOWMrQ0VhVmV2T3FN?=
 =?utf-8?B?QTk3NjZ4OWpCVkw2aWRnQ0J2R3IzNXMxajl5VHF4SDI0S25XdEREeW1rM3FL?=
 =?utf-8?B?VW90RERCa3E1Uk1ZZzE5QWNORnRPK3dXUkdOV3pQOEU4c2lmaDVRWEFuVHZ6?=
 =?utf-8?Q?vf/bO7+lkCdmYl3hUQsz0a8=3D?=
X-OriginatorOrg: opensynergy.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fe47da52-030b-4190-39e8-08d9a0389e32
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6359.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Nov 2021 08:45:28.3209
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 800fae25-9b1b-4edc-993d-c939c4e84a64
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 03IOXrbsBH/1B8uQPC5RFqHxDsEh+bYgog6GOAnwDhZxDY7HPIwSV0/rk+Flosc3QxU8JvU040YYSbF8foaeRA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB6375
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 02.11.21 10:11, Andy Shevchenko wrote:

> CAUTION: This email originated from outside of the organization.
> Do not click links or open attachments unless you recognize the sender and know the content is safe.
>
>
> On Tue, Nov 2, 2021 at 9:33 AM Andriy Tryshnivskyy
> <andriy.tryshnivskyy@opensynergy.com> wrote:
> Now it's good with format, but you have missed the commit message.

Actually commit massage contains a header only (no body message), but I can add body message too.
Thanks!

>
>> Signed-off-by: Andriy Tryshnivskyy <andriy.tryshnivskyy@opensynergy.com>
> ...
>
>> +static void iio_test_iio_format_value_integer_64(struct kunit *test)
>> +{
>> +       char *buf = kunit_kmalloc(test, PAGE_SIZE, GFP_KERNEL);
> Shouldn't this be checked against NULL?

Good question. Truly speaking I've made new test similar to other. And no other tests has a check for NULL.

>> +       s64 value;
>> +       int values[2];
>> +       int ret;
> Reversed xmas tree ordering?

I will correct it. Thanks!

>> +       value = 24;
>> +       values[0] = lower_32_bits(value);
>> +       values[1] = upper_32_bits(value);
>> +       ret = iio_format_value(buf, IIO_VAL_INT_64, 2, values);
> ARRAY_SIZE()?

Will use ARRAY_SIZE(). Thanks!

>> +       IIO_TEST_FORMAT_EXPECT_EQ(test, buf, ret, "24\n");
>> +
>> +       value = -24;
>> +       values[0] = lower_32_bits(value);
>> +       values[1] = upper_32_bits(value);
>> +       ret = iio_format_value(buf, IIO_VAL_INT_64, 2, values);
>> +       IIO_TEST_FORMAT_EXPECT_EQ(test, buf, ret, "-24\n");
>> +
>> +       value = 0;
>> +       values[0] = lower_32_bits(value);
>> +       values[1] = upper_32_bits(value);
>> +       ret = iio_format_value(buf, IIO_VAL_INT_64, 2, values);
>> +       IIO_TEST_FORMAT_EXPECT_EQ(test, buf, ret, "0\n");
>> +
>> +       value = 4294967295;
> Is this UINT_MAX?

Yes. It's UINT_MAX. I will use a constant. Thanks!

>> +       values[0] = lower_32_bits(value);
>> +       values[1] = upper_32_bits(value);
>> +       ret = iio_format_value(buf, IIO_VAL_INT_64, 2, values);
>> +       IIO_TEST_FORMAT_EXPECT_EQ(test, buf, ret, "4294967295\n");
>> +       value = -4294967295;
> Is this -UINT_MAX?

Yes. It's -UINT_MAX. I will use a constant. Thanks!

>> +       values[0] = lower_32_bits(value);
>> +       values[1] = upper_32_bits(value);
>> +       ret = iio_format_value(buf, IIO_VAL_INT_64, 2, values);
>> +       IIO_TEST_FORMAT_EXPECT_EQ(test, buf, ret, "-4294967295\n");
>> +
>> +       value = LLONG_MAX;
>> +       values[0] = lower_32_bits(value);
>> +       values[1] = upper_32_bits(value);
>> +       ret = iio_format_value(buf, IIO_VAL_INT_64, 2, values);
>> +       IIO_TEST_FORMAT_EXPECT_EQ(test, buf, ret, "9223372036854775807\n");
>> +
>> +       value = LLONG_MIN;
>> +       values[0] = lower_32_bits(value);
>> +       values[1] = upper_32_bits(value);
>> +       ret = iio_format_value(buf, IIO_VAL_INT_64, 2, values);
>> +       IIO_TEST_FORMAT_EXPECT_EQ(test, buf, ret, "-9223372036854775808\n");
>> +}
> --
> With Best Regards,
> Andy Shevchenko
>
Thank you for review!


Regards,
Andriy.