Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp2938103pxb; Fri, 5 Nov 2021 07:11:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzU6qwPtcOtKtqb1rnXQOWLU6ttdKOtrAiZ6YT0CLDDYLga74tQ6CGScM9UBJt3XI3UiLYD X-Received: by 2002:a17:906:9459:: with SMTP id z25mr10432998ejx.331.1636121467235; Fri, 05 Nov 2021 07:11:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1636121467; cv=none; d=google.com; s=arc-20160816; b=niBfrLa89RK02o/9bTDQRl+jHQjyFex3Xvps+Q9d83w3ADGEVc9eHjqOw4eaTDBlkG 5M0m/Dl4ARvV6UBSS2pfyKSf123H7Ec2WoCaGvWjedYnMT5q9QDCaM69Dt8z7I12BMLW ZHikOp1s1gd7j5C1KDusLRmrt7aBdbY+z+ya61VvHgQ/FSx/6/Ii4kw0V4pebT1cEPPV KKETxK42aBDlxyUdGWJb9FQ3soSEvB9UVJ82nUDzaIdd/rha0UWYaUgeCiQzme8PaTRt XM1CyLIQ4zRpH5Z6PWkfxr8mk8mBUvrNmOo9HZSFZUmIA7tMaRy77P0gaTGZvyMIASBX rciA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from; bh=lsd6MVj/PkW8Z0FMNwXCorpREimBaApsu+37AqeonLY=; b=SSx06+dqJhVZos1WypVJjxg49p4DkTI8GQno3Yahs/KcVqjyPx/Jcn0UmXfwZfN6od 7gTAD+XttRwSALhroQnXNeSVzWHKiKSrNcQj7JC++Q4TGqxv7UVF+b/RBJpbF4OZofYk MmObUw0Cv22/8qnSTaSOE0Th7YBqbvFBpjAg3QMf12TYVN/XaMC+KUYharIX7fAohnzJ 6L8gkyDI3SnFM1Wh9WOWwMFXziLIsEoKcQOWOIqnjvOqXF+ZH4Wh1XPtrJNysPpMxRYd 8OIZrQpyDimdC2Nd0YJjH2IP8o4Z6kRPYflw0b0DNpP/YJzZmijuoZXR9L70ZwwgpWIk ADng== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e14si14568494eje.649.2021.11.05.07.10.39; Fri, 05 Nov 2021 07:11:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233117AbhKEOKi (ORCPT + 99 others); Fri, 5 Nov 2021 10:10:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232410AbhKEOKf (ORCPT ); Fri, 5 Nov 2021 10:10:35 -0400 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [IPv6:2404:9400:2:0:216:3eff:fee2:21ea]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 52BA8C061205 for ; Fri, 5 Nov 2021 07:07:55 -0700 (PDT) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4Hm2QZ0DvKz4xbP; Sat, 6 Nov 2021 01:07:50 +1100 (AEDT) From: Michael Ellerman To: Christophe Leroy , Michael Ellerman , Paul Mackerras , Benjamin Herrenschmidt Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org In-Reply-To: <3d5800b0bbcd7b19761b98f50421358667b45331.1635520232.git.christophe.leroy@csgroup.eu> References: <3d5800b0bbcd7b19761b98f50421358667b45331.1635520232.git.christophe.leroy@csgroup.eu> Subject: Re: [PATCH] powerpc/8xx: Fix Oops with STRICT_KERNEL_RWX without DEBUG_RODATA_TEST Message-Id: <163612125412.2515705.13745636929777214451.b4-ty@ellerman.id.au> Date: Sat, 06 Nov 2021 01:07:34 +1100 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 29 Oct 2021 17:10:45 +0200, Christophe Leroy wrote: > Until now, all tests involving CONFIG_STRICT_KERNEL_RWX were done with > DEBUG_RODATA_TEST to check the result. But now that > CONFIG_STRICT_KERNEL_RWX is selected by default, it came without > CONFIG_DEBUG_RODATA_TEST and led to the following Oops > > [ 6.830908] Freeing unused kernel image (initmem) memory: 352K > [ 6.840077] BUG: Unable to handle kernel data access on write at 0xc1285200 > [ 6.846836] Faulting instruction address: 0xc0004b6c > [ 6.851745] Oops: Kernel access of bad area, sig: 11 [#1] > [ 6.857075] BE PAGE_SIZE=16K PREEMPT CMPC885 > [ 6.861348] SAF3000 DIE NOTIFICATION > [ 6.864830] CPU: 0 PID: 1 Comm: swapper Not tainted 5.15.0-rc5-s3k-dev-02255-g2747d7b7916f #451 > [ 6.873429] NIP: c0004b6c LR: c0004b60 CTR: 00000000 > [ 6.878419] REGS: c902be60 TRAP: 0300 Not tainted (5.15.0-rc5-s3k-dev-02255-g2747d7b7916f) > [ 6.886852] MSR: 00009032 CR: 53000335 XER: 8000ff40 > [ 6.893564] DAR: c1285200 DSISR: 82000000 > [ 6.893564] GPR00: 0c000000 c902bf20 c20f4000 08000000 00000001 04001f00 c1800000 00000035 > [ 6.893564] GPR08: ff0001ff c1280000 00000002 c0004b60 00001000 00000000 c0004b1c 00000000 > [ 6.893564] GPR16: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 > [ 6.893564] GPR24: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 c1060000 > [ 6.932034] NIP [c0004b6c] kernel_init+0x50/0x138 > [ 6.936682] LR [c0004b60] kernel_init+0x44/0x138 > [ 6.941245] Call Trace: > [ 6.943653] [c902bf20] [c0004b60] kernel_init+0x44/0x138 (unreliable) > [ 6.950022] [c902bf30] [c001122c] ret_from_kernel_thread+0x5c/0x64 > [ 6.956135] Instruction dump: > [ 6.959060] 48ffc521 48045469 4800d8cd 3d20c086 89295fa0 2c090000 41820058 480796c9 > [ 6.966890] 4800e48d 3d20c128 39400002 3fe0c106 <91495200> 3bff8000 4806fa1d 481f7d75 > [ 6.974902] ---[ end trace 1e397bacba4aa610 ]--- > > [...] Applied to powerpc/next. [1/1] powerpc/8xx: Fix Oops with STRICT_KERNEL_RWX without DEBUG_RODATA_TEST https://git.kernel.org/powerpc/c/c12ab8dbc492b992e1ea717db933cee568780c47 cheers