Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   =?ISO-8859-1?Q?J=E9r=F4me?= Pouiller <jerome.pouiller@silabs.com>
To:     Ulf Hansson <ulf.hansson@linaro.org>,
        Avri Altman <avri.altman@wdc.com>,
        Shawn Lin <shawn.lin@rock-chips.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Tony Lindgren <tony@atomide.com>,
        Bean Huo <beanhuo@micron.com>,
        "H. Nikolaus Schaller" <hns@goldelico.com>
Cc:     notasas@gmail.com, linux-mmc@vger.kernel.org,
        linux-kernel@vger.kernel.org, letux-kernel@openphoenux.org,
        kernel@pyra-handheld.com
Subject: Re: [RFC v4 2/6] mmc: core: allow to match the device tree to apply quirks
Date:   Fri, 05 Nov 2021 15:27:44 +0100
Message-ID: <4570288.hTGhjlNkSs@pc-42>
Organization: Silicon Labs
In-Reply-To: <e072de2b480103dbebd941f35be96197534642ee.1636103151.git.hns@goldelico.com>
References: <cover.1636103151.git.hns@goldelico.com> <e072de2b480103dbebd941f35be96197534642ee.1636103151.git.hns@goldelico.com>
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?T1bmLEOwxhCv/aSSFUgSp2RDEMDfmoUCSuKxqN8mAwBB4XCFOJmTeV0oSv?=
 =?iso-8859-1?Q?UtncAckCAcXZYGed4d/jyaBEJ33s6B716rwh4q15ilH4dFfax3sZA5e7tX?=
 =?iso-8859-1?Q?aIolSRn3XJsoQPvkYdETYar5BDDpNHDXPgdhvTKtMifKsdbbBJPUUhKx4V?=
 =?iso-8859-1?Q?JvCRdD/sAd7S7gYrDCU67/mYoHRvl9DSSJci90+lOlta/7YHZq318h6osg?=
 =?iso-8859-1?Q?MBd7WQlO/P/5dUGpKPP6uyeRRmbwOMSdWgYvY25zAuE7GI/d2jVOCrRQor?=
 =?iso-8859-1?Q?qfiGn9jqY+HuduEkcGfvD39gamw/STdbCbOsAF2ClLMDDcZPegoL/ppXgX?=
 =?iso-8859-1?Q?Ws5mdnEBBXT9A3MHM6kuMEl7R6ONJ9+BufkHckH/JOO2U1yQDt9Vcesyn/?=
 =?iso-8859-1?Q?6Mp9Ej+rvFjV+eppTiWy8fygF8m1VxfAPTspNqcML/+KkJ2qj+REd3ya/D?=
 =?iso-8859-1?Q?xshWhh9rQ3YjSgKxCscDRyQRaz6ljRyZCPzl3/8jbaxNy6XHbENPBgpWGr?=
 =?iso-8859-1?Q?XYmFtDqzJ6RvbZAz4xVL3ACmewzCJVACH9bjWlrBJniJo/KDcmCJ+mPBAp?=
 =?iso-8859-1?Q?i93ah6Hmadqv06pJXHuhgagwJIWH18ZVjXw0R++KjppPjaepeSGHh6JTZu?=
 =?iso-8859-1?Q?v1dg4rOuMSy8z8JipE1c4zfsUwgARcHdpWnsTBkus9o3dVqcBIlzh9LOui?=
 =?iso-8859-1?Q?Lt/5WwVumC5BshnIJKgGO1eDdfHdMR02j/mPK1OQOi/VryqGGbp0nHWtRh?=
 =?iso-8859-1?Q?ftJKKtQ+5aON/z40xi8ZuTldIExUJs2oqauaiEgOIT0OGtLk03E+lcSutE?=
 =?iso-8859-1?Q?IcFEaTvdhdCDjf5K70kVmXHzhKCFFU1Id21v4z+X1DlaZeMrLSL1Q+YGgs?=
 =?iso-8859-1?Q?GAfucrbIhKNbpVV1ue3/2LTtZ2AXKGvaClRcUoRdRLeve0GEkElxUvQymK?=
 =?iso-8859-1?Q?HX15k48zvO8LWdhZIU7Q6ptX5bygur0q0MUR+BQ0o0GqOucbd/jKi+gmQ6?=
 =?iso-8859-1?Q?cybolvJxBJE8n7lZ8ZSF6EEpGvhVIVBJZSf8HIkhF3nXP5M+K88Gdl/h0K?=
 =?iso-8859-1?Q?NybC0tce4vjiPcXimqDufU3BH/j2TfV15uXioQ+0pX7GeUfxDxP0twu2I+?=
 =?iso-8859-1?Q?uUWjGlrgvSpQFRUgPgO0ZRSdKwKajVa1UND+O4nM8uqktTMaaSrKsD5rvU?=
 =?iso-8859-1?Q?9TPPEJ1WvG+ZSq1dtI4PCANLevapx5YeAzkJDH/lG4xgjiKSINFx664XLO?=
 =?iso-8859-1?Q?ixx0rpNv2BTL9dsLC4IE9ysw3a6hfOnM29DBOYubs+ysK2E2E71lnUIOso?=
 =?iso-8859-1?Q?EXt0Sgjf2S7Rou7I0vSPbPdsakWicHHL4WvYtvGdDLNmZ1bRa2FfIxsBWF?=
 =?iso-8859-1?Q?cYvA7s/weF8BiWwefKx7vR9atewysuJ2qDeXjaQkU1S73lBMqV/3GDpqHS?=
 =?iso-8859-1?Q?cDLqc2TggbK47j8TLb9j/qoY6ax51MQQYqrFPaPRd1l2dSus+cQgjtVsL8?=
 =?iso-8859-1?Q?udFwasi3jsGwxBbOyoeSCdaHRzYtudlOlmDHTJEKPd3s5dFJmBtiR7YTS5?=
 =?iso-8859-1?Q?m5Eq2VgzbUY32d+MlsuaAp94RHIJfPYkXbU9pFFeU65DbRYGdbz63cqDVJ?=
 =?iso-8859-1?Q?SQPHnImSRzWAmsoQILZFJ8XscpndFZEQqhwaPIMV4juuNkGCrb+Pbj6BF/?=
 =?iso-8859-1?Q?7HX9mu38cSjXBeYeVyc=3D?=
X-OriginatorOrg: silabs.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 617afb62-72bf-45f4-ceac-08d9a06873c5
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5657.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Nov 2021 14:27:53.9167
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +xCyVvhH1y99pcoJ/SJLSzRYx32Gn8etOmabDcULmeHbdvw4+qD2tm8K3jBis2bla2Nst+ENxtXR9JCYWLj05A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5642
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Friday 5 November 2021 10:05:47 CET H. Nikolaus Schaller wrote:
> From: J=E9r=F4me Pouiller <jerome.pouiller@silabs.com>
>=20
> MMC subsystem provides a way to apply quirks when a device match some
> properties (VID, PID, etc...) Unfortunately, some SDIO devices does not
> comply with the SDIO specification and does not provide reliable VID/PID
> (eg. Silabs WF200).
>=20
> So, the drivers for these devices rely on device tree to identify the
> device.
>=20
> This patch allows the MMC to also rely on the device tree to apply a
> quirk.
>=20
> Signed-off-by: J=E9r=F4me Pouiller <jerome.pouiller@silabs.com>

Thank you for to have taken care of that (Maybe, you would like to add a
"Co-developed-by:" tag).


> ---
>  drivers/mmc/core/card.h   |  3 +++
>  drivers/mmc/core/quirks.h | 17 +++++++++++++++++
>  2 files changed, 20 insertions(+)
>=20
> diff --git a/drivers/mmc/core/card.h b/drivers/mmc/core/card.h
> index 7bd392d55cfa5..a3204c19861a4 100644
> --- a/drivers/mmc/core/card.h
> +++ b/drivers/mmc/core/card.h
> @@ -59,6 +59,9 @@ struct mmc_fixup {
>         /* for MMC cards */
>         unsigned int ext_csd_rev;
>=20
> +       /* Match against functions declared in device tree */
> +       const char **of_compatible;
> +
>         void (*vendor_fixup)(struct mmc_card *card, int data);
>         int data;
>  };
> diff --git a/drivers/mmc/core/quirks.h b/drivers/mmc/core/quirks.h
> index c7ef2d14b359f..ee591fd8aeca2 100644
> --- a/drivers/mmc/core/quirks.h
> +++ b/drivers/mmc/core/quirks.h
> @@ -10,6 +10,7 @@
>   *
>   */
>=20
> +#include <linux/of.h>
>  #include <linux/mmc/sdio_ids.h>
>=20
>  #include "card.h"
> @@ -145,6 +146,19 @@ static const struct mmc_fixup __maybe_unused sdio_fi=
xup_methods[] =3D {
>         END_FIXUP
>  };
>=20
> +static inline bool mmc_fixup_of_compatible_match(struct mmc_card *card,
> +                                                const char *const *compa=
t_list)
> +{
> +       struct device_node *np;
> +
> +       for_each_child_of_node(mmc_dev(card->host)->of_node, np) {
> +               if (of_device_compatible_match(np, compat_list))
> +                       return true;

Intel robot complains about of_device_compatible_match():

    ERROR: modpost: "of_device_compatible_match" [drivers/mmc/core/mmc_core=
.ko] undefined!

I think we have to add this line:

    EXPORT_SYMBOL(of_device_compatible_match);

in drivers/of/base.c

> +       }
> +
> +       return false;
> +}
> +
>  static inline void mmc_fixup_device(struct mmc_card *card,
>                                     const struct mmc_fixup *table)
>  {
> @@ -173,6 +187,9 @@ static inline void mmc_fixup_device(struct mmc_card *=
card,
>                         continue;
>                 if (rev < f->rev_start || rev > f->rev_end)
>                         continue;
> +               if (f->of_compatible &&
> +                   !mmc_fixup_of_compatible_match(card, f->of_compatible=
))
> +                       continue;
>=20
>                 dev_dbg(&card->dev, "calling %ps\n", f->vendor_fixup);
>                 f->vendor_fixup(card, f->data);
> --
> 2.33.0
>=20
>=20

--=20
J=E9r=F4me Pouiller