Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp2980402pxb; Fri, 5 Nov 2021 07:52:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyNdPbR6OKT8pKsq13C72RofK6phwxAK4w/wpd5g0XgJJbLi48WU1bcLTHMoSTqZJC+c5sj X-Received: by 2002:a05:6e02:1e0c:: with SMTP id g12mr38928731ila.86.1636123927181; Fri, 05 Nov 2021 07:52:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1636123927; cv=none; d=google.com; s=arc-20160816; b=PEvwF+MBTIbNEPTHdyUFi6Ux+QDgL1HBNya8aIyazWB3PH51sUCTmSNjfg1Renpu3B SF+xCzDj21R2BTbyqr9hUvR+MK3QXf/IfWNKj/snOQRoN7LXsUjSs7Je0oPivt9Jxms9 fmTKDVT/O2hF1K+/POh5ecPpA9DZHh/LnTM0E007tf3uS3+KoMKQJaVf++PDMokFDAbl 3Cp2NAiJDmzJGnQPPG3iS4PZUr8FYAeGx8k1GIGfQuJhJT2CyP0GetRZwBPYa5wkDBSL 4RTbivAOKRlMfmk+O4dXrBVY6h7aXFpw3wGOXfHAXCvc5CQvJr+ABiDw3ehBcSHpknkG NqWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=gQsuB8XBsrJBaWNFhN3LvUJXy+zm4oaU6rIwr/f/wq4=; b=rT5rdAyXNiUmR578OX58Uxgq8U4yUXsloTCid88ftPyytHdnfzWckhsP3n9FDJEV7w 9uMzCgh9Wd+uoYNjwCd0zAOmdZ3Dy6x8bB7aX/nyi6RSHO+P3a01aomWNmOCWwbvzLop DMfbC79JsVvyxcTk51XmgcP+tan1//08IndNFKZflPgrtpdOVPxD+rVPF3PMnMOl/iVv 2senJ1TreLFLJ030jG8YSZIvy9Cr/f3XWKE5OuGcO1TN854LxGont9J7O8lZsg/6JNUf pUL9PpPXDWs91bDWo9mBk2hMFY8j5rXPOTgYISxinM/z1ztlwxzbZz0PaFLN5GYqg0zO lBwA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m3si17198304iov.8.2021.11.05.07.51.53; Fri, 05 Nov 2021 07:52:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233208AbhKEOwt (ORCPT + 99 others); Fri, 5 Nov 2021 10:52:49 -0400 Received: from mga04.intel.com ([192.55.52.120]:19995 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229680AbhKEOwq (ORCPT ); Fri, 5 Nov 2021 10:52:46 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10158"; a="230634321" X-IronPort-AV: E=Sophos;i="5.87,212,1631602800"; d="scan'208";a="230634321" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Nov 2021 07:50:05 -0700 X-IronPort-AV: E=Sophos;i="5.87,212,1631602800"; d="scan'208";a="668261911" Received: from smile.fi.intel.com ([10.237.72.184]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Nov 2021 07:50:03 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1mj0XM-003pNt-Uz; Fri, 05 Nov 2021 16:49:48 +0200 Date: Fri, 5 Nov 2021 16:49:48 +0200 From: Andy Shevchenko To: lianzhi chang Cc: linux-kernel@vger.kernel.org, dmitry.torokhov@gmail.com, gregkh@linuxfoundation.org, jirislaby@kernel.org, 282827961@qq.com Subject: Re: [PATCH v12] tty: Fix the keyboard led light display problem Message-ID: References: <20211105134816.13982-1-changlianzhi@uniontech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211105134816.13982-1-changlianzhi@uniontech.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 05, 2021 at 09:48:16PM +0800, lianzhi chang wrote: > Switching from the desktop environment to the tty environment, > the state of the keyboard led lights and the state of the keyboard > lock are inconsistent. This is because the attribute kb->kbdmode > of the tty bound in the desktop environment (Xorg) is set to > VC_OFF, which causes the ledstate and kb->ledflagstate > values of the bound tty to always be 0, which causes the switch > from the desktop When to the tty environment, the LED light > status is inconsistent with the keyboard lock status. > In order to ensure that the keyboard LED lights are displayed > normally during the VT switching process, when the VT is > switched, the current VT LED configuration is forced to be issued. ... > Suggested-by: Andy Shevchenko Not me, it's Dmitry who suggested the solution. Sorry I wasn't crystal clear about this part. ... > v11: > Supplement the signature of the collaborator. You have v12 in the subject... -- With Best Regards, Andy Shevchenko