Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <ecf6ba8e-8273-0d77-5ceb-3ad44179d3a3@gmail.com>
Date:   Fri, 5 Nov 2021 13:36:20 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.1
Subject: Re: [PATCH v2] staging: r8188eu: os_dep: remove the goto statement
Content-Language: en-US
To:     Greg KH <gregkh@linuxfoundation.org>,
        Saurav Girepunje <saurav.girepunje@gmail.com>
Cc:     Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
        straube.linux@gmail.com, martin@kaiser.cx,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
        saurav.girepunje@hotmail.com
References: <YYKvWeyqd71pYSqM@Sauravs-MacBook-Air.local>
 <YYT/LibxFzssNUJN@kroah.com>
From:   Pavel Skripkin <paskripkin@gmail.com>
In-Reply-To: <YYT/LibxFzssNUJN@kroah.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/5/21 12:53, Greg KH wrote:
> Right after this, ret8 is set, but never checked, which looks like a bug
> to me.  Can you work on fixing that after I take this patch?
> 
> thanks,
> 
> greg k-h
> 

ret8 is returned from this function, but as I said [1] it can be just 
removed. It will be always set to _SUCCESS.


[1] 
https://lore.kernel.org/linux-staging/f26b4aec-c0a1-8c93-b34e-8b1a36ac81b3@gmail.com/


With regards,
Pavel Skripkin