Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp3059267pxb; Fri, 5 Nov 2021 09:06:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwmDmQOUA5qtfoOdHlKnYE5BmYeKl8HhDkCdWjZKed+9FpdxjPve6CXpEzkPmXDmhwf3G52 X-Received: by 2002:a05:6402:d59:: with SMTP id ec25mr55553836edb.214.1636128399279; Fri, 05 Nov 2021 09:06:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1636128399; cv=none; d=google.com; s=arc-20160816; b=RqCTq43zfOp2LTLuoUIirtJEWa68rlCtjk3fwTHGQvzpieJ0G1F0sUsZKeu0lGRBDw wN49MKfiBp5bjkFiaGwt6uY3dAQ8YE+zzF5WKlUVOcjVs1mPf0MYvBPIURLU9A4712vt /x6UWoEsnY/jUPMsdSv5jBbK/MZ/rNdmA/DUVeKofKrgIVq4Cxj+NHy1QqByabCKnP0j wDpE7/lnA9keBFuVON3RWUPDqxwPsQDlrUxbpQ9oqhGw9nolCV0b6n8QeWKE1k0sFadn v6KnH2uhvAzR3R0zXN8qDYl8n2uVk8JK1fb6ndlpbWAo80KcsBHPTi9AAXVLDDs/kJ67 Ms1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :mime-version:accept-language:in-reply-to:references:message-id:date :thread-index:thread-topic:subject:cc:to:from; bh=Zi2q5zVtl7iBQbJzVOGw1+kWzucZp9xDr3NQ9tj7lMI=; b=ohEUuLkWDMuarPrG0yL5Owo/dDZEcNb1N2dh9nC3y+7nycOTRyt6WWWOBjz27JhLoI TmVf6f7DiSSqwsQu/VseFZRV/xinM91RL7EW325PgtWnCW/y76iiXNVVwOMUkEaktp2R L1WZDGT94PWahw8jXSBScw2kFH8QF210KivuxCWZ0r03Tfk3+pUfvuWbOUjDC7kX3u1Z Xngn6gSxT7W18A1roAhPWSeN6+BFedm15e5unkpZtu6boxGu4G8DDnrHCcenREVtGF9H 5fn+9vfgwLKQBKJIGCcYm2590Rhcr4k91TTPv3zqq/EEb/36jE3shulgmPniLi671bHa 1gow== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=aculab.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v15si12098383edx.515.2021.11.05.09.06.07; Fri, 05 Nov 2021 09:06:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=aculab.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232435AbhKELdY convert rfc822-to-8bit (ORCPT + 99 others); Fri, 5 Nov 2021 07:33:24 -0400 Received: from eu-smtp-delivery-151.mimecast.com ([185.58.86.151]:52206 "EHLO eu-smtp-delivery-151.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229529AbhKELdX (ORCPT ); Fri, 5 Nov 2021 07:33:23 -0400 Received: from AcuMS.aculab.com (156.67.243.121 [156.67.243.121]) (Using TLS) by relay.mimecast.com with ESMTP id uk-mta-285-i4H1R1XWNb-mEq-pU1oHjA-1; Fri, 05 Nov 2021 11:30:41 +0000 X-MC-Unique: i4H1R1XWNb-mEq-pU1oHjA-1 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b:0:994c:f5c2:35d6:9b65) by AcuMS.aculab.com (fd9f:af1c:a25b:0:994c:f5c2:35d6:9b65) with Microsoft SMTP Server (TLS) id 15.0.1497.24; Fri, 5 Nov 2021 11:30:40 +0000 Received: from AcuMS.Aculab.com ([fe80::994c:f5c2:35d6:9b65]) by AcuMS.aculab.com ([fe80::994c:f5c2:35d6:9b65%12]) with mapi id 15.00.1497.024; Fri, 5 Nov 2021 11:30:40 +0000 From: David Laight To: 'Yang Guang' , "anton.ivanov@cambridgegreys.com" CC: "jdike@addtoit.com" , "johannes.berg@intel.com" , "linux-kernel@vger.kernel.org" , "linux-um@lists.infradead.org" , "richard@nod.at" , "yang.guang5@zte.com.cn" , "zealci@zte.com.cn" Subject: RE: [PATCH v2] um: use swap() to make code cleaner Thread-Topic: [PATCH v2] um: use swap() to make code cleaner Thread-Index: AQHX0g0JzvytdeFoH0ShjyqJj7xKbqv0zFIg Date: Fri, 5 Nov 2021 11:30:40 +0000 Message-ID: References: <7f95e669-fba3-32e6-cdb9-41fb415b3b82@cambridgegreys.com> <80d5d60030f9f4c0d299e139597f67c562f1d6b2.1636092427.git.yang.guang5@zte.com.cn> In-Reply-To: <80d5d60030f9f4c0d299e139597f67c562f1d6b2.1636092427.git.yang.guang5@zte.com.cn> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=C51A453 smtp.mailfrom=david.laight@aculab.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yang Guang > Sent: 05 November 2021 06:19 > > Use the macro 'swap()' defined in 'include/linux/minmax.h' to avoid > opencoding it. Is there any real point to any of these patches?? If I'm reading a 'random' piece of code I now have to assume that swap() is something that 'magically' exchanges two items. This requires more brain-power than parsing the three lines that do an actual swap. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)