Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <f5900f54-dddd-6dd4-ce13-a8bdfa58b6ad@linux.ibm.com>
Date:   Fri, 5 Nov 2021 13:37:37 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
Subject: Re: [GIT PULL] first round of SCSI updates for the 5.15+ merge window
Content-Language: en-US
To:     James Bottomley <James.Bottomley@HansenPartnership.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        "Martin K. Petersen" <martin.petersen@oracle.com>
Cc:     linux-scsi <linux-scsi@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
References: <b13f25e87fd8d4ed027ef64aba8ebd7273c4b8b8.camel@HansenPartnership.com>
From:   Steffen Maier <maier@linux.ibm.com>
In-Reply-To: <b13f25e87fd8d4ed027ef64aba8ebd7273c4b8b8.camel@HansenPartnership.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
Precedence: bulk

Hi James,

On 11/5/21 13:14, James Bottomley wrote:
> a move to register core sysfs files
> earlier, which means they're available to KOBJ_ADD processing, which
> necessitates switching all drivers to using attribute groups.

I seem to be missing?:

https://lore.kernel.org/linux-scsi/163478764102.7011.9375895285870786953.b4-ty@oracle.com/t/#mab0eeb4a8d8db95c3ace0013bfef775736e124cb
("scsi: core: Fix early registration of sysfs attributes for scsi_device")
https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?h=5.16/scsi-staging&id=3a71f0f7a51259b3cb95d79cac1e19dcc5e89ce9
https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?h=5.16/scsi-queue&id=3a71f0f7a51259b3cb95d79cac1e19dcc5e89ce9

Without that, v5.16-rc1 will have a sysfs regression in 14 low level drivers 
(quoted below).

> git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-misc
> 
> The short changelog is:

> Bart Van Assche (143):
>        scsi: core: Remove two host template members that are no longer used
>        scsi: usb: Switch to attribute groups

>        scsi: smartpqi: Switch to attribute groups

>        scsi: myrs: Switch to attribute groups
>        scsi: myrb: Switch to attribute groups

>        scsi: mpt3sas: Switch to attribute groups
>        scsi: megaraid_sas: Switch to attribute groups

>        scsi: ipr: Switch to attribute groups

>        scsi: hpsa: Switch to attribute groups

>        scsi: cxlflash: Switch to attribute groups

>        scsi: aacraid: Switch to attribute groups
>        scsi: 53c700: Switch to attribute groups

>        scsi: zfcp: Switch to attribute groups

>        scsi: firewire: sbp2: Switch to attribute groups
>        scsi: ata: Switch to attribute groups
>        scsi: core: Register sysfs attributes earlier

> And the diffstat:

>   drivers/scsi/scsi_sysfs.c                       |  54 +--

>   include/scsi/scsi_device.h                      |   7 +-


-- 
Mit freundlichen Gruessen / Kind regards
Steffen Maier

Linux on IBM Z and LinuxONE

https://www.ibm.com/privacy/us/en/
IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Gregor Pillen
Geschaeftsfuehrung: Dirk Wittkopp
Sitz der Gesellschaft: Boeblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294