Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp3062535pxb; Fri, 5 Nov 2021 09:09:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy+gQ4pH5W4BoiLnOoxSCFnp7osZK6MaTxPnz6IBzTIxvk248fWCRCzE2Tct9shd1lMk/A7 X-Received: by 2002:a05:6e02:12e4:: with SMTP id l4mr13784190iln.65.1636128562087; Fri, 05 Nov 2021 09:09:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1636128562; cv=none; d=google.com; s=arc-20160816; b=bYpA/eSI/5zhI+Xt1lZIfly4/Q7JLBb31Nuv/Roj3hPPn1PzcfSOCMdF7sIK0ZBgVu wn5bPPgDnEym+HyfqzUSJ6UW/MVHKGn1hGQAHqOi7oi0A1aGvTB3B192f/Rj3ZkkSZ2z s/FMQy1hjTtYdmPFowRX/VieB1SblIbpMzhxY6uxwh16uVZGskmcWYlMA9EYZTLx0BPu 5TWBCbnF4lQtW1D05fspju+1zWEwQTCq13Ql6khjHFnBRsz1S2UzwDWBeOoGSQRD1NiV +TB4kidhEygBs8AijvES0BB+2CmMvaV8PkCzzpDtZK/DL5e62kRTXuzt9O5cMzDvfvsg /6Rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:dkim-signature:dkim-signature:from; bh=9/u7nlX+6ERlKO2c5VX5W4zDFoPxQ1St3+7wALdbJ/Y=; b=tZM8z3Tcm/xZlD1nDBFIFFG0d7Ozzz0gyRzvQiOt188QMTdLx/0JWgtPh9vQT12LJo t1FjcYIeOl5uq8ivX8b64OF2XfZqBpO950uDl/cG5y/mEPBJkWGgbY5wyKpg4A3+gIMo eZc85dVjN/K9XSEDhe7ikRTIjSYE2Wty1AP3Co+pkjD4cL5B/W9SedT7gFFTMN9d9e1y bY7yh9mg2swb5ZD0fcIARq6e/l94mW5mI7KMuFpKAu68SHqk67GbpehNH49PF8RjbjDe joE9qZNmAFWcfpsCpjNHsV9FAYWbgiYIBcxLxRg4LsCgsG1UwORAT/50YQt7Fe6q5LBW JAuQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=QJQLgPyc; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m3si17349571ilu.139.2021.11.05.09.09.08; Fri, 05 Nov 2021 09:09:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=QJQLgPyc; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232711AbhKENQr (ORCPT + 99 others); Fri, 5 Nov 2021 09:16:47 -0400 Received: from Galois.linutronix.de ([193.142.43.55]:40794 "EHLO galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232616AbhKENQn (ORCPT ); Fri, 5 Nov 2021 09:16:43 -0400 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1636118043; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9/u7nlX+6ERlKO2c5VX5W4zDFoPxQ1St3+7wALdbJ/Y=; b=QJQLgPycTbOzwLhKth6ieU6SZ9aj1KWPZUbPkCyj9bKDoppTIWBVx2VzeC2UftVUM7bOSP zkSj1e/qnZFODR+mjmhwF7UGnOhokTME+NUzSLWYVm+2D4B0JJ2/1yfzb5LVZmbzK9wa6l a+nWpEj85KWleP8i5B6FXn8dd178sakkcGOX7yCUbT5JB+9B5TTVbBCuGFZufaE4vRGJ0u M5sWV+jgzMdiDuEvXAEsmY5IlPQT7hn+srkNyIrvGWpQx/zqdq//9E/KMzanNObj9fMTN7 39TU4ZMUsRlCro1zLn8rsV1oN2FOArFwqQPx0eB1vu5yi/9EYjfjqzBac2+C6A== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1636118043; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9/u7nlX+6ERlKO2c5VX5W4zDFoPxQ1St3+7wALdbJ/Y=; b=3SZlC2cLzI9gKkoFBgmiY65Z5k8/TYekVIUOncR4iRLvHpw2a7HAF4Peb5wuJvPYnSKvJp GnmnM3oK7DaNvmCA== To: Marc Zyngier , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Bjorn Helgaas , Rui Salvaterra , kernel-team@android.com Subject: Re: [PATCH 0/2] PCI: MSI: Deal with devices lying about their masking capability In-Reply-To: <20211104180130.3825416-1-maz@kernel.org> References: <20211104180130.3825416-1-maz@kernel.org> Date: Fri, 05 Nov 2021 14:14:02 +0100 Message-ID: <87ilx64ued.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 04 2021 at 18:01, Marc Zyngier wrote: > Rui reported[1] that his Nvidia ION system stopped working with 5.15, > with the AHCI device failing to get any MSI. A rapid investigation > revealed that although the device doesn't advertise MSI masking, it > actually needs it. Quality hardware indeed. > > Anyway, the couple of patches below are an attempt at dealing with the > issue in a more or less generic way. > > [1] https://lore.kernel.org/r/CALjTZvbzYfBuLB+H=fj2J+9=DxjQ2Uqcy0if_PvmJ-nU-qEgkg@mail.gmail.com > > Marc Zyngier (2): > PCI: MSI: Deal with devices lying about their MSI mask capability > PCI: Add MSI masking quirk for Nvidia ION AHCI > > drivers/pci/msi.c | 3 +++ > drivers/pci/quirks.c | 6 ++++++ > include/linux/pci.h | 2 ++ > 3 files changed, 11 insertions(+) Groan. Reviewed-by: Thomas Gleixner