Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Lukasz Stelmach <l.stelmach@samsung.com>
To:     Arnd Bergmann <arnd@kernel.org>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Jason Gunthorpe <jgg@ziepe.ca>, Arnd Bergmann <arnd@arndb.de>,
        Nathan Chancellor <nathan@kernel.org>,
        Alexander Lobakin <alobakin@pm.me>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH 1/2] ax88796c: fix ioctl callback
In-Reply-To: <20211105092954.1771974-1-arnd@kernel.org> (Arnd Bergmann's
        message of "Fri, 5 Nov 2021 10:29:39 +0100")
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
Date:   Fri, 05 Nov 2021 14:19:21 +0100
Message-ID: <dleftj5yt6loyu.fsf%l.stelmach@samsung.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-="; micalg="pgp-sha256";
        protocol="application/pgp-signature"
CMS-TYPE: 201P
References: <20211105092954.1771974-1-arnd@kernel.org>
        <CGME20211105131932eucas1p284bdb650732ceff3c8326ed578f22b1a@eucas1p2.samsung.com>
Precedence: bulk

--=-=-=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

It was <2021-11-05 pi=C4=85 10:29>, when Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The timestamp ioctls are now handled by the ndo_eth_ioctl() callback,

Actually neither the driver nor the chip support
timstamping. ax88796c_ioctl() simply wraps phy_mii_ioctl(). I believe
you swapped commit messages between this and the other patch in the
series.

> not the old ndo_do_ioctl(), but oax88796 introduced the
                                 ^^^=20
Typo here.=20

> function for the old way.

At first I though =E2=80=94 What did I mess up again? But then saw a7605370=
7dbf
is quite a new thing and ndo_do_ioctl() is still there, so my builds
didn't fail. Thanks, for the patch.

> Move it over to ndo_eth_ioctl() to actually allow calling it from
> user space.
>
> Fixes: a97c69ba4f30 ("net: ax88796c: ASIX AX88796C SPI Ethernet Adapter D=
river")
> Fixes: a76053707dbf ("dev_ioctl: split out ndo_eth_ioctl")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> It would be best to completely remove the .ndo_do_ioctl() callback
> to avoid this problem in the future, but I'm still unsure whether
> we want to just remove the ancient wireless and localtalk drivers
> instead of fixing them.
> ---
>  drivers/net/ethernet/asix/ax88796c_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Acked-by: Lukasz Stelmach <l.stelmach@samsung.com>

> diff --git a/drivers/net/ethernet/asix/ax88796c_main.c b/drivers/net/ethe=
rnet/asix/ax88796c_main.c
> index 4b0c5a09fd57..8994f2322268 100644
> --- a/drivers/net/ethernet/asix/ax88796c_main.c
> +++ b/drivers/net/ethernet/asix/ax88796c_main.c
> @@ -934,7 +934,7 @@ static const struct net_device_ops ax88796c_netdev_op=
s =3D {
>  	.ndo_stop		=3D ax88796c_close,
>  	.ndo_start_xmit		=3D ax88796c_start_xmit,
>  	.ndo_get_stats64	=3D ax88796c_get_stats64,
> -	.ndo_do_ioctl		=3D ax88796c_ioctl,
> +	.ndo_eth_ioctl		=3D ax88796c_ioctl,
>  	.ndo_set_mac_address	=3D eth_mac_addr,
>  	.ndo_set_features	=3D ax88796c_set_features,
>  };

=2D-=20
=C5=81ukasz Stelmach
Samsung R&D Institute Poland
Samsung Electronics

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEXpuyqjq9kGEVr9UQsK4enJilgBAFAmGFL1kACgkQsK4enJil
gBBgawf/RllvbArEsDJkUKjH7yGlJ3Xg/bcC40kDl7k3/LBv43X1f45915LoyJr6
QN9rZFxJt7bLjb7gIFuoZr7YzrXL6G+zT6eIiSNj12bLmBIQO9Q56emT5cDtGap4
xSjVzQII7JG7Lp5jnjIOpZTWg9O48taICkDCUw838QXGoZZzFCJvtMBGQ97nx3FK
/abRaW/NM+IGsK9EbEpIFVLFlRUIotRSLaSgaB9HoT+Xm9aXBZanuaSSTLMiA4GO
TnSUR0c18bACN2l9mIuegXXVV8T2jDrolujgYlNeXKmKVVmtNH9nwfexcinG6WgA
yjKe4VajNq2+hl6o/kkchWlrgUoT9A==
=sDKN
-----END PGP SIGNATURE-----
--=-=-=--