Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 2/2] USB: ehci_brcm_hub_control: replace wIndex-1 with
 temp
To:     Greg KH <gregkh@linuxfoundation.org>,
        Haimin Zhang <tcs.kernel@gmail.com>,
        Al Cooper <alcooperx@gmail.com>
Cc:     linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
        Haimin Zhang <tcs_kernel@tencent.com>,
        TCS Robot <tcs_robot@tencent.com>
References: <20211105083357.29715-1-tcs_kernel@tencent.com>
 <YYTwveXGgNKXCfpk@kroah.com>
From:   Florian Fainelli <f.fainelli@gmail.com>
Message-ID: <d5b698db-5fc0-2d62-2b6e-4c0d70903fa0@gmail.com>
Date:   Fri, 5 Nov 2021 09:09:05 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <YYTwveXGgNKXCfpk@kroah.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/5/21 1:52 AM, Greg KH wrote:
> On Fri, Nov 05, 2021 at 04:33:57PM +0800, Haimin Zhang wrote:
>> In function `ehci_brcm_hub_control`, like following code,  
>> it filters out the case where the upper byte of wIndex is nonzero, 
>> so it need be replaced with temp.
> 
> I do not understand this text, can you try to reword it?
> 
> And you have trailing whitespace.
> 
> And why use `?
> 
>> ```
> 
> What is this for?  Changelog comments are not in markdown format.
> 
>> 	if ((typeReq == GetPortStatus) &&
>> 	    (wIndex && wIndex <= ports) &&       // need to be replaced
> 
> What does this comment mean?
> 
>> 	    ehci->reset_done[wIndex-1] &&
>> 	    time_after_eq(jiffies, ehci->reset_done[wIndex-1]) &&
>> 	    (ehci_readl(ehci, status_reg) & PORT_RESUME)) {
>> ```
>>
>> Signed-off-by: Haimin Zhang <tcs_kernel@tencent.com>
>> Reported-by: TCS Robot <tcs_robot@tencent.com>
> 
> Again, lines need to be in different order, and your from: line is not
> correct.
> 
> Also, you need an individual email address, not a group email alias for
> your contributions.  We work with individuals, not groups.

Also, would you mind copying the people who are remotely involved with
this piece of code, like Al? Thank you
-- 
Florian