Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Valentin Schneider <valentin.schneider@arm.com>
To:     Yafang Shao <laoar.shao@gmail.com>, mingo@redhat.com,
        peterz@infradead.org, juri.lelli@redhat.com,
        vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
        rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
        bristot@redhat.com
Cc:     linux-kernel@vger.kernel.org, Yafang Shao <laoar.shao@gmail.com>
Subject: Re: [RFC PATCH 1/4] stop_machine: Move cpu_stop_done into stop_machine.h
In-Reply-To: <20211104145713.4419-2-laoar.shao@gmail.com>
References: <20211104145713.4419-1-laoar.shao@gmail.com> <20211104145713.4419-2-laoar.shao@gmail.com>
Date:   Fri, 05 Nov 2021 17:00:58 +0000
Message-ID: <87bl2ytu45.mognet@arm.com>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

On 04/11/21 14:57, Yafang Shao wrote:
> Move struct cpu_stop_done into the stop_machine.h, then it can be resued
> by the functions outside of stop_maichine.c.
>

The nr_todo & ret faff is only required for multi_stop scenarios, which
isn't your use-case. AFAICT you don't need to export this, you just need a
struct completion somewhere (and maybe a ret, but I'm not even sure about
that).