Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Thomas Gleixner <tglx@linutronix.de>
To:     "Bae, Chang Seok" <chang.seok.bae@intel.com>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        "bp@alien8.de" <bp@alien8.de>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Subject: Re: [PATCH 4/4] intel_idle: Add SPR support with AMX INIT-state
In-Reply-To: <0B7F49C0-B850-45BC-BEC9-60DF3E2D88C5@intel.com>
References: <20211104225226.5031-1-chang.seok.bae@intel.com>
 <20211104225226.5031-5-chang.seok.bae@intel.com> <878ry24qpb.ffs@tglx>
 <0B7F49C0-B850-45BC-BEC9-60DF3E2D88C5@intel.com>
Date:   Fri, 05 Nov 2021 18:26:27 +0100
Message-ID: <8735oa4ipo.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

On Fri, Nov 05 2021 at 16:03, Bae, Chang Seok wrote:
> On Nov 5, 2021, at 07:33, Thomas Gleixner <tglx@linutronix.de> wrote:
>> On Thu, Nov 04 2021 at 15:52, Chang S. Bae wrote:
>>> +static __cpuidle int intel_idle_tile(struct cpuidle_device *dev,
>>> +				     struct cpuidle_driver *drv, int index)
>>> +{
>>> +	fpu_idle_fpregs();
>> 
>> That's redundant because arch_cpu_idle_enter() is invoked before the
>> actual idle mechanism. 
>
> I think the way this series is shaped makes confusion, sorry.
>
> Since PATCH3 and PATCH4 are in debate -- which approach should be chosen, it
> was decided to post both and let just one of them be selected. E.g., if PATCH3
> is right, then PATCH4 should be abandoned.

My bad. I should have read the cover letter before complaining.

> I think PATCH3 is better. Maybe PATCH4 should not be sent together to avoid
> such confusion.

Yes. patch 3 is way better than patch 4.

Thanks,

        tglx