Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 5 Nov 2021 18:27:01 +0100
From:   =?utf-8?Q?Fran=C3=A7ois-Xavier?= Carton <fx.carton91@gmail.com>
To:     Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>
Cc:     Jiri Kosina <jikos@kernel.org>, linux-input@vger.kernel.org,
        Ash Logan <ash@heyquark.com>,
        Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.ne@posteo.net>,
        =?utf-8?Q?Barnab=C3=A1s_P=C5=91cze?= <pobrn@protonmail.com>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        linux-kernel@vger.kernel.org,
        "Daniel J. Ogorchock" <djogorchock@gmail.com>
Subject: Re: [PATCH v3 0/4] HID: wiiu-drc: Add a driver for the Wii U gamepad
Message-ID: <YYVpZWuil2aTnROx@reblochon>
Mail-Followup-To: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>,
        Jiri Kosina <jikos@kernel.org>, linux-input@vger.kernel.org,
        Ash Logan <ash@heyquark.com>,
        Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.ne@posteo.net>,
        =?utf-8?Q?Barnab=C3=A1s_P=C5=91cze?= <pobrn@protonmail.com>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        linux-kernel@vger.kernel.org,
        "Daniel J. Ogorchock" <djogorchock@gmail.com>
References: <20210502232836.26134-1-linkmauve@linkmauve.fr>
 <20210519085924.1636-1-linkmauve@linkmauve.fr>
 <20210921150837.ingexwsauvxgluca@luna>
 <nycvar.YFH.7.76.2110191112490.12554@cbobk.fhfr.pm>
 <20211019092737.kudgdeulghx2ig3m@luna>
 <nycvar.YFH.7.76.2110191128540.12554@cbobk.fhfr.pm>
 <20211104112137.n3q7vy23z3dztmn5@luna>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20211104112137.n3q7vy23z3dztmn5@luna>
Precedence: bulk

On Thu, Nov 04, 2021 at 12:21:37PM +0100, Emmanuel Gil Peyrot wrote:
> On Tue, Oct 19, 2021 at 11:30:06AM +0200, Jiri Kosina wrote:
> > On Tue, 19 Oct 2021, Emmanuel Gil Peyrot wrote:
> […]
> > > Another driver I’d like to submit eventually is the GameCube Controller 
> > > Adapter for Wii U, which does exactly what its name says, but being an 
> > > external USB adapter it also works on any USB computer; would it make 
> > > sense to develop it alongside the current driver, just because it is 
> > > sold by the same company?
> > 
> > We generally group the support for HID devices in drivers based on the 
> > producing company, with a few exceptions where it doesn't make sense.
> 
> Speaking of which, would you want me to also merge hid-wiimote into
> hid-nintendo?  Or is there a reason it is separate besides legacy?
> 

Would naming the drivers with a "nintendo-" prefix while keeping them
separate be an acceptable solution? Since these drivers share no common
code, merging them will result in a big driver with different parts for
unrelated hardware (save for the maker company), which doesn't seem
right.

For the gamecube adapter driver, I'd prefer to keep it separate; but
I'll integrate it to hid-nintendo as Emmanuel did for the wii-u if
that's the preferred option.