Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp3317479pxb; Fri, 5 Nov 2021 13:32:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyltUoMYYrqzyJ8E+aHhqy7Ae2xUNRZwOCXVahpdMse/gCGsKJuxz2CnrIqmATLIzOzfdoe X-Received: by 2002:a05:6638:150d:: with SMTP id b13mr4877824jat.101.1636144364470; Fri, 05 Nov 2021 13:32:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1636144364; cv=none; d=google.com; s=arc-20160816; b=gKnV83W2Ib3/UPJDs2puyOnjQpVEdvLuYOMkfAnRY4xYbCUYdzVM5HQcUgCx4XMQjr ju1RIbK7ab1Qcf3PDqHa7S3ZC70uL8lRFlSFCXs5ewcucQPwU/pRWksQI4htiGHzM9nR 2zwHZsMyfJCStcpu+outk8x2SwH1nKqJ0ihACDIhr7/Sj7SM1TSI4rneTVeGvp0DnMLe t8t+9ZxsIC8JlWyjrUcUnz06aR5fily2BeM2YxIEVXZLd8E4wED+MN4oVQnBVLVpN7+Y snlE/0chBWfJk4hyRyftnuXaTS/74i+djgUOWoNDkHOdqN4zNBLKMABDaDddzB34Jf5I esgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:sender:dkim-signature; bh=jsvXQTkPuXvEKsz2BDFEDOM0ZuSLuIw8escE4BaHrCw=; b=J9u02nM5eJL59QY/NhbcEDsvJc6sx/1HEC6sk4QX3rw4czXw5aRIH/dHKwIMr/VxRx 4pmHkn7Ov5Xs8hFXWpb1Zxp7i4qlQyKVhl7kfThymce7imL5f2YpDS/Zlna7If4wGomX xz7BsaV7+yoWxbq962lVD6CX60mWFWMkv9CE8uv/8ZAfkyEdB8Z75lm/mGs/cKW6mpuG zFrm3L3NTLZ6MLLsZPAzxBNG1iUd5JHbFNEE/yaGOplVX8vdL5ynS/za8GilDSMr6Huz TyrF6gHVBZPKmEDcaSaMHm+bWWFywxUJNABRJbcYg99Oo4lp24Mn7AcVNMC2TOj1NZZD uVMA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=LXH08+q9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v5si12325546iox.83.2021.11.05.13.32.31; Fri, 05 Nov 2021 13:32:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=LXH08+q9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233425AbhKEURW (ORCPT + 99 others); Fri, 5 Nov 2021 16:17:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49200 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233232AbhKEURS (ORCPT ); Fri, 5 Nov 2021 16:17:18 -0400 Received: from mail-oo1-xc35.google.com (mail-oo1-xc35.google.com [IPv6:2607:f8b0:4864:20::c35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B94DC061714; Fri, 5 Nov 2021 13:14:38 -0700 (PDT) Received: by mail-oo1-xc35.google.com with SMTP id y186-20020a4a45c3000000b002bcf06b1c38so3410150ooa.6; Fri, 05 Nov 2021 13:14:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=jsvXQTkPuXvEKsz2BDFEDOM0ZuSLuIw8escE4BaHrCw=; b=LXH08+q9S8j0k0XZ7MODQ5SnxZjdPgD0CTQ19Sd80canoPwqG6Z5nGwatbsBc8Svu2 GfRJF8HaV/xdQ9lJMkAW5jCjwN9YCfDcvCug4yudBMpI+Fkhi/h6qUlBs4R9jWcenDNW tiQevnY0L4wgntxXL0bDi2jX+tiBMAZkg8GuuJ8snj31hQi4YGCom3ifqH2bq+8NjKX4 UJVLg5BGlnxx1gaa3gdq61AIqh5oyMuNOBVGNwVPPhv0EDLpCbnBbdex6Kc8Fqnojvbx 92pc4WkSgAyZ8jTAe5XrT9cilj6MD8r5DDqvunGEwZ3cF04gWp+FfsvuPRCJ9w8BW4gl edlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=jsvXQTkPuXvEKsz2BDFEDOM0ZuSLuIw8escE4BaHrCw=; b=Gue4ErhckhwkaYFP1MzB8H+OG194mIgWxbCtObyY5avTSSeOnRUcUu8i1Fe6sZAyHd ULKyVE3FFti0JLeL6DdjmIdsnvycsY9gMapESzdyHIj2sGu2UjDTiiOEQNdYgImFgLUa 2te3B4lUWoIXOERGg64qVsxWUva3kTx0N+MqVf3Z1K/UYlcXsrziy2400ihe6e8kwfrL MaGB9PBwW1fDhy5Bcg3s3Fjmm3/XNrA5upvRMwdcVpcnA+qzXIsOh3ZhcOBop15k2sAl HGfC0bhg+KVKhteFs7h8Ggx8gpdqQcAUuuso+CmHk/n+95siK6ATzVVNdxZETW9Qm3t5 7LMg== X-Gm-Message-State: AOAM531esmnLAmKEyqVv7rkf6hGXD3A9Qs/cj83StsVj5Mb08Q5ShooO V/AywuQLFATLLLIwSSwkQCEAc4NEsRY= X-Received: by 2002:a4a:b2c2:: with SMTP id l2mr1355918ooo.93.1636143277191; Fri, 05 Nov 2021 13:14:37 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id p133sm2886249oia.11.2021.11.05.13.14.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Nov 2021 13:14:36 -0700 (PDT) Sender: Guenter Roeck Subject: Re: [PATCH net v4] net: marvell: prestera: fix hw structure laid out To: Volodymyr Mytnyk , netdev@vger.kernel.org Cc: Taras Chornyi , Mickey Rachamim , Serhiy Pshyk , Andrew Lunn , Arnd Bergmann , Geert Uytterhoeven , Denis Kirjanov , Volodymyr Mytnyk , Taras Chornyi , "David S. Miller" , Jakub Kicinski , Vadym Kochan , Yevhen Orlov , linux-kernel@vger.kernel.org References: <1636130964-21252-1-git-send-email-volodymyr.mytnyk@plvision.eu> From: Guenter Roeck Message-ID: <8a5d8e0c-730e-0426-37f1-180c78f7d402@roeck-us.net> Date: Fri, 5 Nov 2021 13:14:33 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <1636130964-21252-1-git-send-email-volodymyr.mytnyk@plvision.eu> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/5/21 9:49 AM, Volodymyr Mytnyk wrote: > From: Volodymyr Mytnyk > > The prestera FW v4.0 support commit has been merged > accidentally w/o review comments addressed and waiting > for the final patch set to be uploaded. So, fix the remaining > comments related to structure laid out and build issues. > > Reported-by: kernel test robot > Fixes: bb5dbf2cc64d ("net: marvell: prestera: add firmware v4.0 support") > Signed-off-by: Volodymyr Mytnyk The patch does not apply to the mainline kernel, so I can not test it there. It does apply to linux-next, and m68k:allmodconfig builds there with the patch applied. However, m68k:allmodconfig also builds in -next with this patch _not_ applied, so I can not really say if it does any good or bad. In the meantime, the mainline kernel (as of v5.15-10643-gfe91c4725aee) still fails to build. Guenter