Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v3 12/21] cpufreq: amd: add amd-pstate performance
 attributes
To:     Huang Rui <ray.huang@amd.com>,
        "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        Shuah Khan <skhan@linuxfoundation.org>,
        Borislav Petkov <bp@suse.de>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@kernel.org>,
        Giovanni Gherdovich <ggherdovich@suse.cz>,
        linux-pm@vger.kernel.org
Cc:     Deepak Sharma <deepak.sharma@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        Mario Limonciello <mario.limonciello@amd.com>,
        Steven Noonan <steven@valvesoftware.com>,
        Nathan Fontenot <nathan.fontenot@amd.com>,
        Jinzhou Su <Jinzhou.Su@amd.com>,
        Xiaojian Du <Xiaojian.Du@amd.com>,
        linux-kernel@vger.kernel.org, x86@kernel.org
References: <20211029130241.1984459-1-ray.huang@amd.com>
 <20211029130241.1984459-13-ray.huang@amd.com>
From:   Nathan Fontenot <nafonten@amd.com>
Message-ID: <d0418254-37c2-347c-52e5-a9de72bc08d5@amd.com>
Date:   Fri, 5 Nov 2021 13:50:49 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
In-Reply-To: <20211029130241.1984459-13-ray.huang@amd.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YlFlWVNFcEJ5WnQyeGgzWnRlNjZMZFhTYlR4TGNGWnQ4UDd1YW9icGhiYW5z?=
 =?utf-8?B?aXFUVHNPVTBhNFhpVjlTdXdWZ1ZjL0F5ZTQ5ajhPNTg0ZVN6N1ZibXpWN3pl?=
 =?utf-8?B?VjNyMURsYkZUYjgwSWV6dUxvWWk5bE02T1ZLemhyMWNWb1RzeWxiaFFXSXRa?=
 =?utf-8?B?UGlzcTRlZS9FZ1loeEFHbmNVRjM2Y2lSbVJFN2ljSzdRSk1tR2FCN2YrODAz?=
 =?utf-8?B?L2tZdzJuVjhXV0R3U0dzTEhZRWZCN2xOSGhnc2oxOWdTTFFvNnVNS05TREh0?=
 =?utf-8?B?ZGtEZlpoaG9QaUF6OTEwdEdXay9KTFJEay9CeWo3a21QZHhtQkRqQ1Z1REw1?=
 =?utf-8?B?RFB0a3dwZDZTanR6QmxQOXc4YnZabjdyVUlJQW1CeUx4L2ZDZWxXdllJaDBZ?=
 =?utf-8?B?ajdaYk9EbXNDSzNnb0owN2tNUFlFb3loT2J4SEJZRFFTdThpT0hjZkVxSW1j?=
 =?utf-8?B?WGZvbFIzQjlYTWoyTlFOWWJMTWhobTZYV0FuMnd4cFFPamdabGl3b1ZuQmVI?=
 =?utf-8?B?QzhkelRwZ2Jqam1XV1dvc1RGSFU3bXE5RDh5QkFhUjFCUnRoMkJ4LzBHa1RG?=
 =?utf-8?B?REROVkdoQXZ3SUVpall6RDI4ZldkamJuZWlSQUhQak95Ukw2TjgrTk1EQ1Bj?=
 =?utf-8?B?dE81aUhWWXV2bmVSS2ZzdHpyM2RUU01kN0kvZXZETFpPMTd5eVVERjZTekJR?=
 =?utf-8?B?R09SUnhPUENEdUhLY1VNdnNsdVowQkxhQ0F1SktoaS9Yck1sd0t3MDhDVndU?=
 =?utf-8?B?dmFubEtxOTVjb0lwZDJWUEQ2ZE9rdWhvYWhDU04weDdOVXViS3U1TFU3N1Ur?=
 =?utf-8?B?Q0hkdmpUYTliTkM1YjJubVNFbTNVTVBUdERVbERrSmhNT2dEMUkvQWQ4V3hi?=
 =?utf-8?B?U2U4M2JHRGRleXpXeWZleEE1cjMrc3l5TjRrRitOK2x3SlN4eHgyTlFHWGZV?=
 =?utf-8?B?ZUpCQVF1UE9PeUszVWt3V0NmNDh2SzZYdDZpRnRwcElzb1c0aHVMK3U2NFBE?=
 =?utf-8?B?WCswY05NWi9ObDNkUXNmMHJHbUUwbTYwR2F5aUxLZ01XREFzTEhiSnQ4TExI?=
 =?utf-8?B?dTAvTGxNaU5KY3hiNEJQdVg3NGt0S1ZMT2NSNVgyR1RleDBDbDRWMmxUMUk1?=
 =?utf-8?B?Y2pTLzE2bGNvd3pvZDFqREF0a1ZRYWJOUmp2UFlJWkdtZkxwRjRIWTZtZ0JP?=
 =?utf-8?B?NTVyUjhnR29OYmhXbHRlZ3JFNFdPRTU0dTMwQkFObHAxcGlhanBncDRJMzMx?=
 =?utf-8?B?dTRQTXh6NjVzVDRJSVNZOEFmYzBJTjZpcjFobVlZWnZoNlNXL2hicXo2emRT?=
 =?utf-8?B?ajM0UzIvVWU5RXY3aGhwQ2xkOHJjcjAyL2RTQ283Ny9hMmNTaEVOaVh4OGo5?=
 =?utf-8?B?R3hCSDJiR3ptVXplUnJENmhyNm5lNTl6ZGh0T0xEKzE2c0JhT084dElZYm1U?=
 =?utf-8?B?QWQ4K3J1Mlhic2RQREZoT1JrQWt0Q0tud3JESGVLdHFMeTVRbmR6RjYzRDcx?=
 =?utf-8?B?SG1NMTh3djVBRmVEZUpiVVVlUDMvUW5kdWdiVmd3a2k4Z1RCMFE2SWFuWnpw?=
 =?utf-8?B?ZXMySTRvZVFPNkxQRUFJQ1ZoSzRWQjdlMlpPVlZlcU9ablVRY2tPeUROTGk1?=
 =?utf-8?B?YU0zUGlhVGNhLzFSMGdBbHVQUG03VjJuOUJTMEViSENJSThLQkRhbHJFOXFM?=
 =?utf-8?B?Q3U3MXBJVzNjOFhPOE05YTNyNm5UMnBwenZDa3hmS2lOTE8wZWREM3RZWENw?=
 =?utf-8?B?djJ0MXZlWDhXTzFpR0xWRTcvcDJTRHVLYWVNRU1zMExTRnJ6cjExUmxSdEdZ?=
 =?utf-8?B?aTI2a0xyaWRERkU4RHBteTRqcVYyK2E3elJSdjlJODJhVFJTck9aUGFlOFVz?=
 =?utf-8?B?b2NaY096ZzNMM0ZKNjIyNkc2a09iYnd5MWVMd0tYQmMrcHFtM2hPc0EyTkNi?=
 =?utf-8?B?YXU2NVNqcFFWN1hXNk1jdzlIKzloMWk0dHliRHZkb0hpSjhFN1lCaFpsb0h1?=
 =?utf-8?B?V05PcTlpTmM4ZHZ2TmlSMy9FSWUrZ0gycE05d1pGQk5rc3hxSXRMYW9Idnov?=
 =?utf-8?B?RVZXZllqRTBjeDFDRWsvRjVmVXRXRVBuRzhzNTZjaTcvSEpsdjdxc2drRVg0?=
 =?utf-8?B?cHFyYTdhcWJ0RmlrSEJnL2VtTk9wdS95aWNuazFnOWpRZVNXVnN5d0hhOG05?=
 =?utf-8?B?Vzd0eUdZZXJ0UDQwSDRYUDZOMjRzb0lRTHFHK1VzOVo2L3JuNUI5OUxuaVRw?=
 =?utf-8?Q?/Co/ZyEemYioHhbTpZbokIblTu7O7psF/5Gdgzggqw=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0423de2a-6829-4f3e-21aa-08d9a08d316e
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB4720.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Nov 2021 18:50:53.1848
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: voro8JOInpm8C411MmGnASNZbKDxU5t61JNXiwTI4fXgejZiYxi9PfQZi9qxUthXXc0sAzk6/A474ZaUAXKebA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4576
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/29/21 8:02 AM, Huang Rui wrote:
> Introduce sysfs attributes to get the different level amd-pstate
> performances.

Can you explain why we need to provide duplicate sysfs entries for
these values?

Each one of these are already created by the drivers/acpi code and exist
in sysfs (see /sys/devices/system/cpu/cpuX/acpi_cppc).

-Nathan

> 
> Signed-off-by: Huang Rui <ray.huang@amd.com>
> ---
>  drivers/cpufreq/amd-pstate.c | 53 ++++++++++++++++++++++++++++++++++++
>  1 file changed, 53 insertions(+)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 8cf1e80f44e0..58ee50bf492b 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -536,14 +536,67 @@ static ssize_t show_amd_pstate_lowest_nonlinear_freq(struct cpufreq_policy *poli
>  	return sprintf(&buf[0], "%u\n", freq);
>  }
>  
> +static ssize_t show_amd_pstate_highest_perf(struct cpufreq_policy *policy,
> +					    char *buf)
> +{
> +	u32 perf;
> +	struct amd_cpudata *cpudata = policy->driver_data;
> +
> +	perf = READ_ONCE(cpudata->highest_perf);
> +
> +	return sprintf(&buf[0], "%u\n", perf);
> +}
> +
> +static ssize_t show_amd_pstate_nominal_perf(struct cpufreq_policy *policy,
> +					    char *buf)
> +{
> +	u32 perf;
> +	struct amd_cpudata *cpudata = policy->driver_data;
> +
> +	perf = READ_ONCE(cpudata->nominal_perf);
> +
> +	return sprintf(&buf[0], "%u\n", perf);
> +}
> +
> +static ssize_t show_amd_pstate_lowest_nonlinear_perf(struct cpufreq_policy *policy,
> +						     char *buf)
> +{
> +	u32 perf;
> +	struct amd_cpudata *cpudata = policy->driver_data;
> +
> +	perf = READ_ONCE(cpudata->lowest_nonlinear_perf);
> +
> +	return sprintf(&buf[0], "%u\n", perf);
> +}
> +
> +static ssize_t show_amd_pstate_lowest_perf(struct cpufreq_policy *policy,
> +					   char *buf)
> +{
> +	u32 perf;
> +	struct amd_cpudata *cpudata = policy->driver_data;
> +
> +	perf = READ_ONCE(cpudata->lowest_perf);
> +
> +	return sprintf(&buf[0], "%u\n", perf);
> +}
> +
>  cpufreq_freq_attr_ro(amd_pstate_max_freq);
>  cpufreq_freq_attr_ro(amd_pstate_nominal_freq);
>  cpufreq_freq_attr_ro(amd_pstate_lowest_nonlinear_freq);
>  
> +cpufreq_freq_attr_ro(amd_pstate_highest_perf);
> +cpufreq_freq_attr_ro(amd_pstate_nominal_perf);
> +cpufreq_freq_attr_ro(amd_pstate_lowest_nonlinear_perf);
> +cpufreq_freq_attr_ro(amd_pstate_lowest_perf);
> +
>  static struct freq_attr *amd_pstate_attr[] = {
>  	&amd_pstate_max_freq,
>  	&amd_pstate_nominal_freq,
>  	&amd_pstate_lowest_nonlinear_freq,
> +	&amd_pstate_highest_perf,
> +	&amd_pstate_nominal_perf,
> +	&amd_pstate_lowest_nonlinear_perf,
> +	&amd_pstate_lowest_perf,
>  	NULL,
>  };
>  
>