Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 5 Nov 2021 19:25:04 -0700
From:   Dmitry Torokhov <dmitry.torokhov@gmail.com>
To:     Alistair Francis <alistair@alistair23.me>
Cc:     linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
        mylene.josserand@free-electrons.com, linus.walleij@linaro.org,
        andreas@kemnade.info, rydberg@bitmath.org, robh+dt@kernel.org,
        alistair23@gmail.com
Subject: Re: [PATCH v2 4/4] ARM: dts: imx7d: remarkable2: Enable the cyttsp5
Message-ID: <YYXngKCBbAkkxEKj@google.com>
References: <20211103114830.62711-1-alistair@alistair23.me>
 <20211103114830.62711-5-alistair@alistair23.me>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211103114830.62711-5-alistair@alistair23.me>
Precedence: bulk

On Wed, Nov 03, 2021 at 09:48:30PM +1000, Alistair Francis wrote:
> +	tsc@24 {
> +		compatible = "cypress,tt21000";
> +		reg = <0x24>;
> +
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_touch>;
> +		interrupt-parent = <&gpio1>;
> +		interrupts = <14 IRQ_TYPE_EDGE_FALLING>;
> +		reset-gpios = <&gpio1 13 0>;

Reset lines are almost universally active low. Are you sure it is active
high in your case?

Thanks.

-- 
Dmitry