Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp3916642pxb; Sat, 6 Nov 2021 03:10:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyrSLk6QjItJzgm4/TKnw+JRnBZGRxWiQjnwmKa+y81GwFE6hSPjZekX6C86LjZadIbdq0G X-Received: by 2002:a17:906:f74a:: with SMTP id jp10mr22554059ejb.358.1636193409316; Sat, 06 Nov 2021 03:10:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1636193409; cv=none; d=google.com; s=arc-20160816; b=Fy9j87mgku95mHG6YgZ/vuJRUdbVLJjgKB83u1mlebamaRAaBSHRoSENUIBUtAPt8V 5sT39VznhKVdQf2VCj37YF+m2HAsFZGH8li/zKlcRZgaofk5RSi5waDrgAcScGuCjjyd EYJ83hLlkbT663U2sm30MJWUR+sAu74vvfjjfeofn/3GCyUsO4PaPSc04yeoMEhdSACu ezS4fB1WW1DmoPRLv3tsz/dOgUBqEmhUWHMgT6T5ydEAKhV6nSQkmOkCHnzV5Z2RdfpX n5BT9tCsTLB8b3SqirzPxWDGgu+U6w9HnW+0GHn6F5TQgc0b5oqlecQ5mGIloxW12yXo 6fuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=+gVb27+0cY4DiwAHwAsXU2s0nYpAc3YO/54kHRVF8vA=; b=LZNZ3+/WNIlbhtermVfzfh5iVPzCYfS1EC4wvHosGId4yerBmEkpYU35VrWcErFA1c NuVdjCEx/LKU1iILP84q6oKu0L4JYe1S0fs6tR6PuFpS/gZ/P7DKDO+KPkBXYCCaEKs4 wbWLO+pgaMHQBzT9nyC5wofXtjwyNg7gcouBF5BK/H7AIHW6hMh0qfdLH20H1TPdKCsj 1BTfIdjgu9n0HAJHh38T3rNuArBbtec5fmWGRbMScxfU3KkjBdHEAary7gM8CpysnR2b kJyBgAAsoLxVmDxxEqLT+P1vF+rVzlHLrAuyMTykny+pULfKX767g3jDcnC9Uj6JhivE RQjQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Gb4YNvDS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ds9si8637297ejc.479.2021.11.06.03.09.45; Sat, 06 Nov 2021 03:10:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Gb4YNvDS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232730AbhKFCvS (ORCPT + 99 others); Fri, 5 Nov 2021 22:51:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:45356 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232660AbhKFCvR (ORCPT ); Fri, 5 Nov 2021 22:51:17 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id C772261165; Sat, 6 Nov 2021 02:48:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1636166917; bh=0Q1qqv0Kd+XHjRnxqFbShLNfYNLIMdw5y4oufaAhDS4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Gb4YNvDSSDZFfNy9+aDPxKGQD1jvht4qYsXou3UIpuTwKh0UHrX3ROeI4qah5teq3 d+Gtr0vUqsdv1fkiLN7HT0/vwKnczkn3voMZI/bnb2JuwoNpi+KmGCXgNiZCVwmI9m x6JORCrpThK0rxEr3VBw/j7bTXoVaLEEi1uvMFaN3Rh/ZL3fmYAoLlbxeSsCyMFa4r fIpOybRzqACxEvSWWI9WzJxc+Rr5AnrjtJmesM/YYm1Cg5nCG+iHT7kY4yy2T83ieT 93LR2U7HexAaRZDphjjgNcGRBNT388Hv9vDPFq8+oDIZAFJpg9nYItFrfmV9KLcoUU sjPNu+5hoeh6Q== Date: Fri, 5 Nov 2021 19:48:35 -0700 From: Jakub Kicinski To: Jiasheng Jiang Cc: krzysztof.kozlowski@canonical.com, yashsri421@gmail.com, davem@davemloft.net, rdunlap@infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] NFC: nfcmrvl: add unanchor after anchor Message-ID: <20211105194835.43270314@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <1636016141-3645490-1-git-send-email-jiasheng@iscas.ac.cn> References: <1636016141-3645490-1-git-send-email-jiasheng@iscas.ac.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 4 Nov 2021 08:55:41 +0000 Jiasheng Jiang wrote: > In the error path, the anchored urb is unanchored. > But in the successful path, the anchored urb is not. > Therefore, it might be better to add unanchor(). > > Fixes: f26e30c ("NFC: nfcmrvl: Initial commit for Marvell NFC driver") Apart from answering Krzysztof's comment please also mend the Fixes tag. The hash should be at least 12 digits long.