Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2] drivers/coresight: ultrasoc: Add System Memory Buffer
 driver
To:     Randy Dunlap <rdunlap@infradead.org>, <mathieu.poirier@linaro.org>,
        <suzuki.poulose@arm.com>, <mike.leach@linaro.org>
CC:     <coresight@lists.linaro.org>, <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>, <linuxarm@huawei.com>
References: <20211105012012.86635-1-liuqi115@huawei.com>
 <af9dbbbf-64f0-f3c6-fa30-4e306e6156d2@infradead.org>
From:   "liuqi (BA)" <liuqi115@huawei.com>
Message-ID: <477a4a27-2cd7-e9bc-363c-577271abac93@huawei.com>
Date:   Sat, 6 Nov 2021 15:31:20 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101
 Thunderbird/68.6.0
MIME-Version: 1.0
In-Reply-To: <af9dbbbf-64f0-f3c6-fa30-4e306e6156d2@infradead.org>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-GB
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 2021/11/5 9:36, Randy Dunlap wrote:
> On 11/4/21 6:20 PM, Qi Liu wrote:
>> diff --git a/drivers/hwtracing/coresight/ultrasoc/Kconfig 
>> b/drivers/hwtracing/coresight/ultrasoc/Kconfig
>> new file mode 100644
>> index 000000000000..c18c25bf9df3
>> --- /dev/null
>> +++ b/drivers/hwtracing/coresight/ultrasoc/Kconfig
>> @@ -0,0 +1,12 @@
>> +# SPDX-License-Identifier: MIT
>> +#
>> +# ultrasoc configuration
>> +#
>> +config ULTRASOC_SMB
>> +    tristate "Ultrasoc system memory buffer drivers"
>> +        depends on ARM64 && CORESIGHT
> 
> The "depends" line should be indented with a tab instead of spaces...
> 
ah, yes, my editor might be set incorrectly, thanks for the reminder, 
I'll correct it next time.

Qi
>> +    help
>> +      This enables support for the Ultrasoc system memory buffer
>> +      driver that is responsible for receiving the trace data from
>> +      Coresight ETM devices and storing them to a system buffer
>> +      respectively.
> 
>