Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20211104145713.4419-1-laoar.shao@gmail.com> <20211104145713.4419-2-laoar.shao@gmail.com>
 <87bl2ytu45.mognet@arm.com>
In-Reply-To: <87bl2ytu45.mognet@arm.com>
From:   Yafang Shao <laoar.shao@gmail.com>
Date:   Sat, 6 Nov 2021 15:30:49 +0800
Message-ID: <CALOAHbArZ90h8yn4mzQhBDEwStA6eNffXx1K=E=Wro61AvDkGA@mail.gmail.com>
Subject: Re: [RFC PATCH 1/4] stop_machine: Move cpu_stop_done into stop_machine.h
To:     Valentin Schneider <valentin.schneider@arm.com>
Cc:     Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Juri Lelli <juri.lelli@redhat.com>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Benjamin Segall <bsegall@google.com>,
        Mel Gorman <mgorman@suse.de>,
        Daniel Bristot de Oliveira <bristot@redhat.com>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, Nov 6, 2021 at 1:01 AM Valentin Schneider
<valentin.schneider@arm.com> wrote:
>
> On 04/11/21 14:57, Yafang Shao wrote:
> > Move struct cpu_stop_done into the stop_machine.h, then it can be resued
> > by the functions outside of stop_maichine.c.
> >
>
> The nr_todo & ret faff is only required for multi_stop scenarios, which
> isn't your use-case. AFAICT you don't need to export this, you just need a
> struct completion somewhere (and maybe a ret, but I'm not even sure about
> that).

Right. nr_todo is for stopping two and more cpus.  We really don't
need it if we only support stopping one cpu.
I will change it.

-- 
Thanks
Yafang