Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1636130964-21252-1-git-send-email-volodymyr.mytnyk@plvision.eu>
 <8a5d8e0c-730e-0426-37f1-180c78f7d402@roeck-us.net> <VI1P190MB0734F38F35521218A02CF2048F8E9@VI1P190MB0734.EURP190.PROD.OUTLOOK.COM>
In-Reply-To: <VI1P190MB0734F38F35521218A02CF2048F8E9@VI1P190MB0734.EURP190.PROD.OUTLOOK.COM>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Sat, 6 Nov 2021 09:42:09 +0100
Message-ID: <CAMuHMdWXLU64wxnJe82ede0ALrQM6ie+7czy4WtUfGLDufWX4g@mail.gmail.com>
Subject: Re: [PATCH net v4] net: marvell: prestera: fix hw structure laid out
To:     Volodymyr Mytnyk <volodymyr.mytnyk@plvision.eu>
Cc:     Guenter Roeck <linux@roeck-us.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Taras Chornyi <taras.chornyi@plvision.eu>,
        Mickey Rachamim <mickeyr@marvell.com>,
        Serhiy Pshyk <serhiy.pshyk@plvision.eu>,
        Andrew Lunn <andrew@lunn.ch>, Arnd Bergmann <arnd@arndb.de>,
        Denis Kirjanov <dkirjanov@suse.de>,
        Volodymyr Mytnyk <vmytnyk@marvell.com>,
        Taras Chornyi <tchornyi@marvell.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Vadym Kochan <vkochan@marvell.com>,
        Yevhen Orlov <yevhen.orlov@plvision.eu>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Volodymyr,

On Fri, Nov 5, 2021 at 11:42 PM Volodymyr Mytnyk
<volodymyr.mytnyk@plvision.eu> wrote:
> > > From: Volodymyr Mytnyk <vmytnyk@marvell.com>
> > >
> > > The prestera FW v4.0 support commit has been merged
> > > accidentally w/o review comments addressed and waiting
> > > for the final patch set to be uploaded. So, fix the remaining
> > > comments related to structure laid out and build issues.
> > >
> > > Reported-by: kernel test robot <lkp@intel.com>
> > > Fixes: bb5dbf2cc64d ("net: marvell: prestera: add firmware v4.0 support")
> > > Signed-off-by: Volodymyr Mytnyk <vmytnyk@marvell.com>
> >
> > The patch does not apply to the mainline kernel, so I can not test it there.
> > It does apply to linux-next, and m68k:allmodconfig builds there with the patch
> > applied. However, m68k:allmodconfig also builds in -next with this patch _not_
> > applied, so I can not really say if it does any good or bad.
> > In the meantime, the mainline kernel (as of v5.15-10643-gfe91c4725aee)
> > still fails to build.

>         The mainline kernel doesn't have the base ("net: marvell: prestera: add firmware v4.0 support") commit yet, so the patch will not be applied.

Mainline has this broken commit as of Nov 2.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds