Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\))
Subject: Re: [RFC v4 2/6] mmc: core: allow to match the device tree to apply
 quirks
From:   "H. Nikolaus Schaller" <hns@goldelico.com>
In-Reply-To: <4570288.hTGhjlNkSs@pc-42>
Date:   Sat, 6 Nov 2021 15:31:05 +0100
Cc:     Ulf Hansson <ulf.hansson@linaro.org>,
        Avri Altman <avri.altman@wdc.com>,
        Shawn Lin <shawn.lin@rock-chips.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Tony Lindgren <tony@atomide.com>,
        Bean Huo <beanhuo@micron.com>, notasas@gmail.com,
        linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
        letux-kernel@openphoenux.org, kernel@pyra-handheld.com
Content-Transfer-Encoding: quoted-printable
Message-Id: <7121F069-56C7-402C-BA82-A922B1A36587@goldelico.com>
References: <cover.1636103151.git.hns@goldelico.com>
 <e072de2b480103dbebd941f35be96197534642ee.1636103151.git.hns@goldelico.com>
 <4570288.hTGhjlNkSs@pc-42>
To:     =?utf-8?B?SsOpcsO0bWUgUG91aWxsZXI=?= <jerome.pouiller@silabs.com>
Precedence: bulk

Hi J=C3=A9r=C3=B4me,

> Am 05.11.2021 um 15:27 schrieb J=C3=A9r=C3=B4me Pouiller =
<jerome.pouiller@silabs.com>:
>=20
> On Friday 5 November 2021 10:05:47 CET H. Nikolaus Schaller wrote:
>> From: J=C3=A9r=C3=B4me Pouiller <jerome.pouiller@silabs.com>
>>=20
>> MMC subsystem provides a way to apply quirks when a device match some
>> properties (VID, PID, etc...) Unfortunately, some SDIO devices does =
not
>> comply with the SDIO specification and does not provide reliable =
VID/PID
>> (eg. Silabs WF200).
>>=20
>> So, the drivers for these devices rely on device tree to identify the
>> device.
>>=20
>> This patch allows the MMC to also rely on the device tree to apply a
>> quirk.
>>=20
>> Signed-off-by: J=C3=A9r=C3=B4me Pouiller <jerome.pouiller@silabs.com>
>=20
> Thank you for to have taken care of that (Maybe, you would like to add =
a
> "Co-developed-by:" tag).

Well, I just have taken your and Ulf's proposal and done 90% copy&paste.
So there wasn't much development, just editing...

>=20
>=20
>> ---
>> drivers/mmc/core/card.h   |  3 +++
>> drivers/mmc/core/quirks.h | 17 +++++++++++++++++
>> 2 files changed, 20 insertions(+)
>>=20
>> +static inline bool mmc_fixup_of_compatible_match(struct mmc_card =
*card,
>> +                                                const char *const =
*compat_list)
>> +{
>> +       struct device_node *np;
>> +
>> +       for_each_child_of_node(mmc_dev(card->host)->of_node, np) {
>> +               if (of_device_compatible_match(np, compat_list))
>> +                       return true;
>=20
> Intel robot complains about of_device_compatible_match():
>=20
>    ERROR: modpost: "of_device_compatible_match" =
[drivers/mmc/core/mmc_core.ko] undefined!
>=20
> I think we have to add this line:
>=20
>    EXPORT_SYMBOL(of_device_compatible_match);
>=20
> in drivers/of/base.c

I had seen the krobot message as well but could not figure out
what it meant...

But with your hint it indeed looks like an omission in drivers/of/base.c
Having something exported in include/linux/of.h but code not
marked EXPORT_SYMBOL...

That needs a separate patch. I'll add one with a

Reported-by: kernel test robot <lkp@intel.com>
Reported-by: J=C3=A9r=C3=B4me Pouiller <jerome.pouiller@silabs.com>

and some Fixes: tag. Since it has a different audience I think
I should post it separately.

BTW: krobot noted the same issue for mmc_of_find_child_device()
in drivers/mmc/core/core.c (which we do not touch in this series).
But maybe it should be fixed as well.

So let's wait for more comments and then I may distribute a [PATCH v1].
Or should I do a [PATCH v5] to continue version counting?

BR,
Nikolaus