Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp4467706pxb; Sat, 6 Nov 2021 14:41:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwvihk9puzqXjwokIRAEVnwhKGlFgqRhr6snBnTtmuw3ui1Fe/1bS9DFp3/r+PTuvpuu+5X X-Received: by 2002:a17:906:1290:: with SMTP id k16mr84089616ejb.566.1636234899978; Sat, 06 Nov 2021 14:41:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1636234899; cv=none; d=google.com; s=arc-20160816; b=h0Pt98nt0kww7umAEI/AVhF9ANpk5uIByv6xXDxHlJ9AUBZ/nJc/v9/YhMw3pYF7v7 ZrIE1/D7vDUOpEdjvzE/ZLpezAwPvLI0HZ0ZOPh6He9eiHaqEwwq0Bh7OiXRC0JO+Hiu LuCt/F+bbbu7xemvzpxaD9oj59sagzLiUQIDrfb6NXKgAyznLd+cHhGVxF+hsfJ5qtSv ifyZAf0rULldeRXL0V7phuiyn+NmHCv/RvJEH5/oA2yohiIWBfMN0gKa1S0gSILVr0Dk PgSLDDkUtKvBoCPAbJL5VOxwlP8TjDWz7E++6ZlDSxqeQPnoN0LyRY50+cBAPAjP0ljL MMHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=FBNebcsvS/cRRNAlmJ1pCmjuCsDA9A9PI8pbUeBapkI=; b=oGuuKO36GbhBDsYf1nZaYeiNoUqRotEX8EYMNHZIzf1BUKPUq3MZbQeECUu9PUHztS w+YlFXavztPCroEug8PlmfTGtainc76AnhE2biig9YO9vrqJm1cpnYysMX1hfqfUIw0R M5rRoc/LdEOUSo+abDghR8XBRqcXa0OX4ARDG1ud6/4IoauutZi7UixN0GbvndA0WPbz amhFXJZVd3aP0gSMRRXVd+HNkCpvtG2s/IwV4faFOB5alPJLHuiQ8tBZt3i04m5dShyZ skiftWdq/Cvajy4b3xqJg2QO5iPjV/Xvctgwaf0UFhI8DYmrSAjLc1tQbR4BAyn/EsVr RQHg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e26si17523135edq.301.2021.11.06.14.41.17; Sat, 06 Nov 2021 14:41:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234085AbhKFS6k (ORCPT + 99 others); Sat, 6 Nov 2021 14:58:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34454 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229968AbhKFS6k (ORCPT ); Sat, 6 Nov 2021 14:58:40 -0400 Received: from andre.telenet-ops.be (andre.telenet-ops.be [IPv6:2a02:1800:120:4::f00:15]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27ACCC061570 for ; Sat, 6 Nov 2021 11:55:55 -0700 (PDT) Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed20:91c6:551:e507:741f]) by andre.telenet-ops.be with bizsmtp id F6vr2600C4BJ5g4016vrgE; Sat, 06 Nov 2021 19:55:54 +0100 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1mjQr1-00AdOS-Fg; Sat, 06 Nov 2021 19:55:51 +0100 Received: from geert by rox.of.borg with local (Exim 4.93) (envelope-from ) id 1mjQr0-006cdY-Si; Sat, 06 Nov 2021 19:55:50 +0100 From: Geert Uytterhoeven To: Jens Axboe , Luis Chamberlain Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven , noreply@ellerman.id.au Subject: [PATCH -next] ataflop: Add missing semicolon to return statement Date: Sat, 6 Nov 2021 19:55:49 +0100 Message-Id: <20211106185549.1578444-1-geert@linux-m68k.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org drivers/block/ataflop.c: In function ‘ataflop_probe’: drivers/block/ataflop.c:2023:2: error: expected expression before ‘if’ 2023 | if (ataflop_alloc_disk(drive, type)) | ^~ drivers/block/ataflop.c:2023:2: error: ‘return’ with a value, in function returning void [-Werror=return-type] drivers/block/ataflop.c:2011:13: note: declared here 2011 | static void ataflop_probe(dev_t dev) | ^~~~~~~~~~~~~ Fixes: 46a7db492e7a2740 ("ataflop: address add_disk() error handling on probe") Reported-by: noreply@ellerman.id.au Signed-off-by: Geert Uytterhoeven --- Feel free to fold into the commit that introduced the issue. --- drivers/block/ataflop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/ataflop.c b/drivers/block/ataflop.c index de8c3785899a5de3..bf769e6e32fef92b 100644 --- a/drivers/block/ataflop.c +++ b/drivers/block/ataflop.c @@ -2019,7 +2019,7 @@ static void ataflop_probe(dev_t dev) if (drive >= FD_MAX_UNITS || type >= NUM_DISK_MINORS) return; if (unit[drive].disk[type]) - return + return; if (ataflop_alloc_disk(drive, type)) return; if (add_disk(unit[drive].disk[type])) -- 2.25.1