Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 6 Nov 2021 23:01:27 +0100
From:   Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= <kw@linux.com>
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc:     kishon@ti.com, lorenzo.pieralisi@arm.com, bhelgaas@google.com,
        linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
        kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] PCI: endpoint: Use 'bitmap_zalloc()' when applicable
Message-ID: <YYb7NwlYcmsdw8AR@rocinante>
References: <01eba3c86137eb348f8cce69f500222bd7c72c57.1635058203.git.christophe.jaillet@wanadoo.fr>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <01eba3c86137eb348f8cce69f500222bd7c72c57.1635058203.git.christophe.jaillet@wanadoo.fr>
Precedence: bulk

Hi Christophe,

> 'mem->bitmap' is a bitmap. So use 'bitmap_zalloc()' to simplify code,
> improve the semantic and avoid some open-coded arithmetic in allocator
> arguments.
> 
> Also change the corresponding 'kfree()' into 'bitmap_free()' to keep
> consistency.

Thank you!

> Finally, while at it, axe the useless 'bitmap' variable and use
> 'mem->bitmap' directly.

Personally, I would keep the bitmap variable - this might be what Bjorn
would also prefer, as I believe he prefers not to store what is a "failed"
state of sorts in a target variable directly, if memory serves me right.

[...]
> @@ -49,10 +49,8 @@ int pci_epc_multi_mem_init(struct pci_epc *epc,
>  			   unsigned int num_windows)
>  {
>  	struct pci_epc_mem *mem = NULL;
> -	unsigned long *bitmap = NULL;
>  	unsigned int page_shift;
>  	size_t page_size;
> -	int bitmap_size;
>  	int pages;
>  	int ret;
>  	int i;
> @@ -72,7 +70,6 @@ int pci_epc_multi_mem_init(struct pci_epc *epc,
>  			page_size = PAGE_SIZE;
>  		page_shift = ilog2(page_size);
>  		pages = windows[i].size >> page_shift;
> -		bitmap_size = BITS_TO_LONGS(pages) * sizeof(long);
>  
>  		mem = kzalloc(sizeof(*mem), GFP_KERNEL);
>  		if (!mem) {
> @@ -81,8 +78,8 @@ int pci_epc_multi_mem_init(struct pci_epc *epc,
>  			goto err_mem;
>  		}
>  
> -		bitmap = kzalloc(bitmap_size, GFP_KERNEL);
> -		if (!bitmap) {
> +		mem->bitmap = bitmap_zalloc(pages, GFP_KERNEL);
> +		if (!mem->bitmap) {
>  			ret = -ENOMEM;
>  			kfree(mem);
>  			i--;
> @@ -92,7 +89,6 @@ int pci_epc_multi_mem_init(struct pci_epc *epc,
>  		mem->window.phys_base = windows[i].phys_base;
>  		mem->window.size = windows[i].size;
>  		mem->window.page_size = page_size;
> -		mem->bitmap = bitmap;
>  		mem->pages = pages;
>  		mutex_init(&mem->lock);
>  		epc->windows[i] = mem;
> @@ -106,7 +102,7 @@ int pci_epc_multi_mem_init(struct pci_epc *epc,
>  err_mem:
>  	for (; i >= 0; i--) {
>  		mem = epc->windows[i];
> -		kfree(mem->bitmap);
> +		bitmap_free(mem->bitmap);
>  		kfree(mem);
>  	}
>  	kfree(epc->windows);
> @@ -145,7 +141,7 @@ void pci_epc_mem_exit(struct pci_epc *epc)
>  
>  	for (i = 0; i < epc->num_windows; i++) {
>  		mem = epc->windows[i];
> -		kfree(mem->bitmap);
> +		bitmap_free(mem->bitmap);
>  		kfree(mem);
>  	}
>  	kfree(epc->windows);

Thank you!

Reviewed-by: Krzysztof Wilczyński <kw@linux.com>

	Krzysztof