Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20211106104053.98761-1-ajaygargnsit@gmail.com>
 <CAHp75VdY8aoF+dCm0j7EA-53BFaWdepvYYv7h5MVz2kVWagOOA@mail.gmail.com>
 <CAHP4M8Vdj4Eb8q773BeHvsW9n6t=3n1WznuXAR4fZCNi1J6rOg@mail.gmail.com> <CAHp75VcZArNXhY2T5RmSmrFrAvd4YGRfpByBb4hYLccNwGDyVA@mail.gmail.com>
In-Reply-To: <CAHp75VcZArNXhY2T5RmSmrFrAvd4YGRfpByBb4hYLccNwGDyVA@mail.gmail.com>
From:   Ajay Garg <ajaygargnsit@gmail.com>
Date:   Sun, 7 Nov 2021 03:36:35 +0530
Message-ID: <CAHP4M8WYR5QvEoc8PRQ8CYFa0C4hx=_Fy4PTiqmpqFkXc59jXA@mail.gmail.com>
Subject: Re: [PATCH v2] tty: vt: keyboard: initialize "kbs" so that kfree(kbs)
 runs fine even if kbs is not kmalloced.
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     Pavel Skripkin <paskripkin@gmail.com>,
        Greg KH <gregkh@linuxfoundation.org>,
        "jirislaby@kernel.org" <jirislaby@kernel.org>,
        "kernel@esmil.dk" <kernel@esmil.dk>,
        "open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Thanks Andy, v3-patch has been posted at :
https://lore.kernel.org/linux-serial/20211106220315.392842-1-ajaygargnsit@g=
mail.com/T/#u

Many thanks to Pavel and Andy for the review/help throughout.
Let's continue on the v3-patch thread-link.

>
> It=E2=80=99s fine to add default case as I suggested. The problem with yo=
ur contribution is in the commit message. Selling point would be (according=
 to the below) the smatch complain with the idea of having default case  in=
 general.
>
> So something like:
> =3D=3D=3D
> The smatch tool gives a warning on the code in ...
>
> warning: ...
>
> This usually happens when switch has no default case and static analyzers=
 and even sometimes compilers can=E2=80=99t prove that all possible values =
are covered.
>
> ...
>
> =3D=3D=3D
>