Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <b7520698-44ef-55db-2b0f-ed47cd7d8b71@gmail.com>
Date:   Sun, 7 Nov 2021 01:25:54 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.1
Subject: Re: [PATCH v3] tty: vt: keyboard: add default switch-case, to handle
 smatch-warnings in method vt_do_kdgkb_ioctl
Content-Language: en-US
To:     Ajay Garg <ajaygargnsit@gmail.com>
Cc:     gregkh@linuxfoundation.org, jirislaby@kernel.org,
        andriy.shevchenko@linux.intel.com, kernel@esmil.dk,
        linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20211106220315.392842-1-ajaygargnsit@gmail.com>
 <8d0346ba-4819-c25e-f208-0b51116d9147@gmail.com>
 <CAHP4M8VmPTiWjVa_PEMs+XT0VzsoAw8BuO-KBo08Uwuf=T1WFw@mail.gmail.com>
From:   Pavel Skripkin <paskripkin@gmail.com>
In-Reply-To: <CAHP4M8VmPTiWjVa_PEMs+XT0VzsoAw8BuO-KBo08Uwuf=T1WFw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/7/21 01:17, Ajay Garg wrote:
> On Sun, Nov 7, 2021 at 3:42 AM Pavel Skripkin <paskripkin@gmail.com> wrote:
>>
>> On 11/7/21 01:03, Ajay Garg wrote:
>> > diff --git a/drivers/tty/vt/keyboard.c b/drivers/tty/vt/keyboard.c
>> > index c7fbbcdcc346..b83e7669658d 100644
>> > --- a/drivers/tty/vt/keyboard.c
>> > +++ b/drivers/tty/vt/keyboard.c
>> > @@ -2090,6 +2090,12 @@ int vt_do_kdgkb_ioctl(int cmd, struct kbsentry __user *user_kdgkb, int perm)
>> >
>> >               ret = 0;
>> >               break;
>> > +     default: {
>> > +             kbs = NULL;
>> > +             ret = -ENOIOCTLCMD;
>> > +
>> > +             break;
>> > +     }
>>
>> Are these brackets needed here? There are no local variables inside
>> default case.
> 
> Hmm,
> 
> * case KDGKBSENT: uses braces.
> * case KDSKBSENT: does not use braces.
> 
> I based the layout for default-case on the same lines as case
> KDGKBSENT: , as I prefer explicit braces :)
> 

I am not against these braces, but I, honestly, dislike them, because 
`case : {` syntax looks ugly _to me_.

KDGKBSENT uses it because of local variable `len` and not using them 
will cause build error.

I didn't find any strict requirements to not use brackets when there is 
no local variable, so it's up to maintainers (again).


Anyway, thank for respinning :)


With regards,
Pavel Skripkin