Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20211106220315.392842-1-ajaygargnsit@gmail.com>
 <8d0346ba-4819-c25e-f208-0b51116d9147@gmail.com> <CAHP4M8VmPTiWjVa_PEMs+XT0VzsoAw8BuO-KBo08Uwuf=T1WFw@mail.gmail.com>
 <b7520698-44ef-55db-2b0f-ed47cd7d8b71@gmail.com>
In-Reply-To: <b7520698-44ef-55db-2b0f-ed47cd7d8b71@gmail.com>
From:   Ajay Garg <ajaygargnsit@gmail.com>
Date:   Sun, 7 Nov 2021 08:51:29 +0530
Message-ID: <CAHP4M8UXCb_6tAqDAZuKSUO=Y=U4wAk1C8v-MJbDCPOAV9+tFg@mail.gmail.com>
Subject: Re: [PATCH v3] tty: vt: keyboard: add default switch-case, to handle
 smatch-warnings in method vt_do_kdgkb_ioctl
To:     Pavel Skripkin <paskripkin@gmail.com>
Cc:     gregkh@linuxfoundation.org, jirislaby@kernel.org,
        andriy.shevchenko@linux.intel.com, kernel@esmil.dk,
        linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

> >
>
> I am not against these braces, but I, honestly, dislike them, because
> `case : {` syntax looks ugly _to me_.
>
> KDGKBSENT uses it because of local variable `len` and not using them
> will cause build error.

Ahh, that explains the difference.

Floated the v4 patch at :
https://lore.kernel.org/linux-serial/20211107031721.4734-1-ajaygargnsit@gmail.com/T/#u

so that consistency is maintained in the styling.

Let's continue on the v4-patch link now.

Thanks again Pavel.


>
> I didn't find any strict requirements to not use brackets when there is
> no local variable, so it's up to maintainers (again).
>
>
> Anyway, thank for respinning :)
>
>
>
> With regards,
> Pavel Skripkin