Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp5167391pxb; Sun, 7 Nov 2021 06:34:28 -0800 (PST) X-Google-Smtp-Source: ABdhPJywXfTRVa6kLOpRXO8ndP2iOyd1F7ILRGWwpouxVNNh3P83KKoXdfZK+nnZaUbJWTWgXv45 X-Received: by 2002:a17:907:75f0:: with SMTP id jz16mr40380383ejc.77.1636295668441; Sun, 07 Nov 2021 06:34:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1636295668; cv=none; d=google.com; s=arc-20160816; b=HvE5LR8qULuw3KNTDcAWcSShQr3rzI4mhqlwWnlf+jV46LRKbkBuL64eQoPOvPwUYb MTT8IqbTxKrduBOtlVhDjyL/lipDTYA3B9K3oDF+v/jsWZkNR/0Nwx77RBVdG8Qgnkz1 7LSv/0P7Iq6Uwrq/WLI7jYne42GsUtU1tXd4dNBW3d18NaOB64KMMvS1KMHYUJjddsH4 TYDKRe7m6GMh7eksOgDDwvv5hgCfEiGUy8jdVULYsArWAxj+2gCi0aChLwA4dter9Bvd SQdZFub7mrWUoXiRsNN0pg71v3XAxEbNEl2kA6V44EBxBorER8txWPRbzPaQFL8M6c2d NW/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=RkodyJdoWaZmfWDESGtm3oqOy1fHb2BMmSwsrnm1V6w=; b=Q2YoDiFefBzFbaVBB5fwfGwMkycOrugYJ4bWkukEpY3n1x9jFyGDp0lKTOiIwJR1o0 jogTov2X0jiW5oOlasqx4F+X6U0GEpMYK/W9StOcoBmsyK/kZn02Nw7J5OtWoYwYQg9x YAnfnmWHQNNU3CMKp27+QPedvEEVwB4hHuJuY82lNWtSPPm1y6BOjQPZtbobdxzWNX/4 B/r7Msdpnm7jCtKi7/Ue5mmXQAtCF4esVDTVBEiplY+BwhV6+2HPcNckAmaTzDOwmNAt J4WPnBtnb8cxD/JRkwdJh23kFh24aaJfgPyUuNBMoO+HUKyUQpbRXCv5meFXDerRRm34 DCSQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y22si24067499edc.223.2021.11.07.06.33.52; Sun, 07 Nov 2021 06:34:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233533AbhKGBlT (ORCPT + 99 others); Sat, 6 Nov 2021 21:41:19 -0400 Received: from p-impout009aa.msg.pkvw.co.charter.net ([47.43.26.140]:40071 "EHLO p-impout009.msg.pkvw.co.charter.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229566AbhKGBlS (ORCPT ); Sat, 6 Nov 2021 21:41:18 -0400 X-Greylist: delayed 427 seconds by postgrey-1.27 at vger.kernel.org; Sat, 06 Nov 2021 21:41:18 EDT Received: from 2603-8090-2005-39b3-0000-0000-0000-1025.res6.spectrum.com.com ([24.31.246.181]) by cmsmtp with ESMTP id jX1qm3piEE1BbjX1rmQA09; Sun, 07 Nov 2021 01:31:27 +0000 X-Authority-Analysis: v=2.4 cv=X+2XlEfe c=1 sm=1 tr=0 ts=61872c6f a=cAe/7qmlxnd6JlJqP68I9A==:117 a=cAe/7qmlxnd6JlJqP68I9A==:17 a=pGLkceISAAAA:8 a=VwQbUJbxAAAA:8 a=yQdBAQUQAAAA:8 a=0x8QZmvYvHxge1C1EjMA:9 a=AjGcO6oz07-iQ99wixmX:22 a=SzazLyfi1tnkUD6oumHU:22 From: Larry Finger To: gregkh@linuxfoundation.org Cc: phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Larry Finger , Zameer Manji , Stable Subject: [PATCH] staging: r8188eu: Fix breakage introduced when 5G code was removed Date: Sat, 6 Nov 2021 20:31:23 -0500 Message-Id: <20211107013123.14624-1-Larry.Finger@lwfinger.net> X-Mailer: git-send-email 2.33.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CMAE-Envelope: MS4xfAcj5TPV50mOcoyuoqfs9znVi4v7h8Z/+IznGBCGZrTJb9YE/8fu0sDuaDtxGXhCfWs6BRwET1Je+fB/K/dr2z0CKCz1aoNC9ynjBFejO979hGAQ3lX3 O3ei6eAWrJhuUeRLrMVe+KY+QwDGjcHm4ejAXt5DD+qg46mRiGxwZRH5ZNL8togiIf0eFPvSljSkccqLSsOXsdtXsv4zXSsX6sCG/Ne5XxZs/sUk/ww25yb1 6IYDOk7yO2KIuMQbNWwEsaYEeU4qaBYfblkfg2NM3Vik6xQv9TPcDyreZHvX11sapKE+RgMGbnzAjx+Us8gbF+NCv7xf2LFNNBQl2KTdTMKI+3tzLMZAG8sG 3UG6mvlL+PJdGsxG1cHI+p27p7muq0VAx1YWGbHDcLiX87G1VPMLZPBroarZ/k+fm8W1txAfCTUCVqiGDMlRtxs7VBJ79FUtJ6rkKV3gaQGrkQpcScLfZPkV r8gwV0osyCfElLu1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In commit 221abd4d478a ("staging: r8188eu: Remove no more necessary definitions and code"), two entries were removed from RTW_ChannelPlanMap[], but not replaced with zeros. The position within this table is important, thus the patch broke systems operating in regulatory domains listed later than entry 0x13 in the table. Unfortunately, the FCC entry comes before that point and most testers did not see this problem. Reported-and-tested-by: Zameer Manji Fixes: 221abd4d478a ("staging: r8188eu: Remove no more necessary definitions and code") Cc: Stable # v5.5+ Signed-off-by: Larry Finger --- drivers/staging/r8188eu/core/rtw_mlme_ext.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/r8188eu/core/rtw_mlme_ext.c index 55c3d4a6faeb..d3814174e08f 100644 --- a/drivers/staging/r8188eu/core/rtw_mlme_ext.c +++ b/drivers/staging/r8188eu/core/rtw_mlme_ext.c @@ -107,6 +107,7 @@ static struct rt_channel_plan_map RTW_ChannelPlanMap[RT_CHANNEL_DOMAIN_MAX] = { {0x01}, /* 0x10, RT_CHANNEL_DOMAIN_JAPAN */ {0x02}, /* 0x11, RT_CHANNEL_DOMAIN_FCC_NO_DFS */ {0x01}, /* 0x12, RT_CHANNEL_DOMAIN_JAPAN_NO_DFS */ + (0x00), /* 0x13 */ {0x02}, /* 0x14, RT_CHANNEL_DOMAIN_TAIWAN_NO_DFS */ {0x00}, /* 0x15, RT_CHANNEL_DOMAIN_ETSI_NO_DFS */ {0x00}, /* 0x16, RT_CHANNEL_DOMAIN_KOREA_NO_DFS */ @@ -118,6 +119,7 @@ static struct rt_channel_plan_map RTW_ChannelPlanMap[RT_CHANNEL_DOMAIN_MAX] = { {0x00}, /* 0x1C, */ {0x00}, /* 0x1D, */ {0x00}, /* 0x1E, */ + {0x00}, /* 0x1F, */ /* 0x20 ~ 0x7F , New Define ===== */ {0x00}, /* 0x20, RT_CHANNEL_DOMAIN_WORLD_NULL */ {0x01}, /* 0x21, RT_CHANNEL_DOMAIN_ETSI1_NULL */ -- 2.33.1