Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 7 Nov 2021 23:46:27 +0100
From:   Ansuel Smith <ansuelsmth@gmail.com>
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Jonathan Corbet <corbet@lwn.net>, Pavel Machek <pavel@ucw.cz>,
        John Crispin <john@phrozen.org>, netdev@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-doc@vger.kernel.org, linux-leds@vger.kernel.org
Subject: Re: [RFC PATCH 4/6] leds: trigger: add offload-phy-activity trigger
Message-ID: <YYhXQ3CuVlUmLJIz@Ansuel-xps.localdomain>
References: <20211107175718.9151-1-ansuelsmth@gmail.com>
 <20211107175718.9151-5-ansuelsmth@gmail.com>
 <befc2591-b96b-bac2-3b34-73cd3599049d@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <befc2591-b96b-bac2-3b34-73cd3599049d@infradead.org>
Precedence: bulk

On Sun, Nov 07, 2021 at 02:42:37PM -0800, Randy Dunlap wrote:
> On 11/7/21 9:57 AM, Ansuel Smith wrote:
> > +config LEDS_OFFLOAD_TRIGGER_PHY_ACTIVITY
> > +	tristate "LED Offload Trigger for PHY Activity"
> > +	depends on LEDS_OFFLOAD_TRIGGERS
> > +	help
> > +	  This allows LEDs to be configured to run by HW and offloaded based
> > +	  on some rules. The LED will blink or be on based on the PHY Activity
> > +	  for example on packet receive of based on the link speed.
> 
> Cannot parse:                           of based on
>

Typo. "on packet receive or based on the link speed"
You can find right below all the modes.

> > +	  The current rules are:
> 
> 
> -- 
> ~Randy

-- 
	Ansuel