Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20211107150304.3253-1-sampaio.ime@gmail.com> <20211107150304.3253-3-sampaio.ime@gmail.com>
In-Reply-To: <20211107150304.3253-3-sampaio.ime@gmail.com>
From:   Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Date:   Mon, 8 Nov 2021 12:58:33 +0100
Message-ID: <CANiq72kgm-5CidoN8VRLnWokiDSWsQcMFbaUd4WKOnbPsON9RQ@mail.gmail.com>
Subject: Re: [PATCH 2/2] auxdisplay: charlcd: checking for pointer reference
 before dereferencing
To:     Luiz Sampaio <sampaio.ime@gmail.com>
Cc:     Miguel Ojeda <ojeda@kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sun, Nov 7, 2021 at 4:03 PM Luiz Sampaio <sampaio.ime@gmail.com> wrote:
>
> Check if the pointer lcd->ops->init_display exists before dereferencing it.
> If a driver called charlcd_init() without defining the ops, this would
> return segmentation fault, as happened to me when implementing a charlcd
> driver.  Checking the pointer before dereferencing protects from
> segmentation fault.

It can't hurt -- thanks! I think `EINVAL` makes more sense here, also
we could use `WARN_ON`:

    if (WARN_ON(!lcd->ops->init_display))
        return -EINVAL;

Cheers,
Miguel