Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751423AbXAFQSz (ORCPT ); Sat, 6 Jan 2007 11:18:55 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751427AbXAFQSz (ORCPT ); Sat, 6 Jan 2007 11:18:55 -0500 Received: from ozlabs.org ([203.10.76.45]:54488 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751423AbXAFQSy (ORCPT ); Sat, 6 Jan 2007 11:18:54 -0500 Subject: Re: [patch] paravirt: isolate module ops From: Rusty Russell To: Ingo Molnar Cc: Zachary Amsden , Jeremy Fitzhardinge , Chris Wright , Andrew Morton , linux-kernel@vger.kernel.org, Arjan van de Ven , Adrian Bunk In-Reply-To: <20070106071424.GB11232@elte.hu> References: <20070106000715.GA6688@elte.hu> <459EEDEB.8090800@vmware.com> <1168064710.20372.28.camel@localhost.localdomain> <20070106071424.GB11232@elte.hu> Content-Type: text/plain Date: Sun, 07 Jan 2007 03:18:45 +1100 Message-Id: <1168100325.20372.37.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.8.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1202 Lines: 39 On Sat, 2007-01-06 at 08:14 +0100, Ingo Molnar wrote: > * Rusty Russell wrote: > > > +EXPORT_SYMBOL(clts); > > +EXPORT_SYMBOL(read_cr0); > > +EXPORT_SYMBOL(write_cr0); > > mark these a _GPL export. Perhaps even mark the symbol deprecated, to be > unexported once we fix raid6. OK... > > +EXPORT_SYMBOL(wbinvd); > > +EXPORT_SYMBOL(raw_safe_halt); > > +EXPORT_SYMBOL(halt); > > +EXPORT_SYMBOL_GPL(apic_write); > > +EXPORT_SYMBOL_GPL(apic_read); > > these should be _GPL too. If any module uses it and breaks a user's box > we need that big licensing hint to be able to debug them ... OK. I GPLed the ones which I thought were really obscure, but I was trying to follow existing policy of not _GPL'ing existing symbols. Cheers, Rusty. PS. drm_memory.h has a "drm_follow_page": this forces us to uninline various page tables ops. Can this use follow_page() somehow, or do we need an "__follow_page" export for this case? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/