Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp6352786pxb; Mon, 8 Nov 2021 07:16:02 -0800 (PST) X-Google-Smtp-Source: ABdhPJw9RUEsKmZeY0/+mGocNlGijC+YWXckoILQPUoVe0DmYxJNCSTbk2ZXg6ZdnmGlSpOdCuYb X-Received: by 2002:a17:906:3a0e:: with SMTP id z14mr48142eje.55.1636384561742; Mon, 08 Nov 2021 07:16:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1636384561; cv=none; d=google.com; s=arc-20160816; b=cGF1CtR4saVnemeBDt8umogkrXo1W+Zhcl9GcPCifTIq4c1ePjVzkx6Jhnhz3BiuH6 1E7vxbZvJ+j85WQGrG46wLJKn10DxUzAOvVqsjAsAvidlAqaSg87bWtqc9Tuos8NUNx9 6GSWK0/Gmij2LsUh8L9svV4wO0RQLB0ONog2XqfLIw4fnWV3obzQF3EBhZa5Ewpht959 IYuNtB6WK81vPqsmtjdHbwPxgBt05sSr+H+X2CR4D6BurstrH9w4qTm8tE5PznIoku9D rF7lqksgBDbLQcVeFuvAf7urcVS616hvAUs2gBhjZ36SpL5Z77vpsp2Xq4QNwBQkAYIH 51Nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=15M4Yl0rrZR1vof1Vp2PvMkWcmEEV2kGfIxwU5mDcj0=; b=NHsEAtu5Y2mDX6DsioTdgAfiKcQRMLf1wn+QQDZkoio2aWx4mkBDy6tVIQp8eXuJbI Cj2znzP11aVZJ0MBKMdoMoZqDn77MjzIFGKCWgW+b1wCLQAeoFQpqqODZhSbdwb360zC Jq4uqTZB5+92Fa4TyZb5XeUXAa2YFa02kb398GlsjaodHCnDe1ONJLp0cjHG9V91XCZg e/3BEO9gvzVD4Gpg04Oel4VCdjJaK71QgPf2/Iw+gScB4GnlQdVSLR+eO668nY5SSjok 8IwRak7HQWOjwb6JNpiS9coZUXyuYeOCrQ089VZYsD3Cok8uVE3DQHJMOlFMpZvKqQgJ +T9w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ds11si30275141ejc.465.2021.11.08.07.15.34; Mon, 08 Nov 2021 07:16:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239141AbhKHLVD (ORCPT + 99 others); Mon, 8 Nov 2021 06:21:03 -0500 Received: from mail.netfilter.org ([217.70.188.207]:47120 "EHLO mail.netfilter.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237148AbhKHLVC (ORCPT ); Mon, 8 Nov 2021 06:21:02 -0500 Received: from netfilter.org (unknown [78.30.32.163]) by mail.netfilter.org (Postfix) with ESMTPSA id BC43A6063C; Mon, 8 Nov 2021 12:16:18 +0100 (CET) Date: Mon, 8 Nov 2021 12:18:13 +0100 From: Pablo Neira Ayuso To: cgel.zte@gmail.com Cc: kadlec@netfilter.org, fw@strlen.de, davem@davemloft.net, kuba@kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jing Yao , Zeal Robot Subject: Re: [PATCH] netfilter: xt_IDLETIMER: replace snprintf in show functions with sysfs_emit Message-ID: References: <20211104114911.31214-1-yao.jing2@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20211104114911.31214-1-yao.jing2@zte.com.cn> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 04, 2021 at 11:49:11AM +0000, cgel.zte@gmail.com wrote: > From: Jing Yao > > coccicheck complains about the use of snprintf() in sysfs show > functions: > WARNING use scnprintf or sprintf > > Use sysfs_emit instead of scnprintf, snprintf or sprintf makes more > sense. Applied, thanks.