Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp6379590pxb; Mon, 8 Nov 2021 07:41:53 -0800 (PST) X-Google-Smtp-Source: ABdhPJw7Bj3NKxtzIAcYYz3x5qTOJR1Fezo/MGnu46xBFydep/XplsRn/DYVKprqsoG2VQp1uNRE X-Received: by 2002:a05:6638:22d6:: with SMTP id j22mr34470jat.97.1636386112641; Mon, 08 Nov 2021 07:41:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1636386112; cv=none; d=google.com; s=arc-20160816; b=cdm96GN/1qYpQTCd6lmz01Qp3PcXcCubjT++/j3UjuAx20a5fle0aqfUPCkNQpoBnI Xv9MKaxZBKODbCpGV5omXWHbwHpemirJrwxzxojKoaQDY4rUZjY1hUSkWPH87IUn3ha7 iGUsKsi7zWXg2h88sJ7CSAdWBHmx48W4fBSQq4145vsV4jHA5KkpyMZ4gWDZQgjgKRqb /PSp2ZQpjqwvAE5Ga9DDQo2wmfoQKTbDlD1Cqux7kW8gChVdv4f102zLWdBTnBaeTg9/ gXnIAny/lfGvhA5UG1RX6/4UX2iGoEmcB1v75Zfu0Mx3MRHSX5g+MCn3OlShZeHlW2Vu MyyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=SPOSG9KglBk+gHcv9b2mSKv0Wd75hM315nOKmlGi/r8=; b=x3sLAUh8Os6r/q7idEHgtXJo2P5m+fWkEdkPbo9npZZT/5jVWwBK76WU0Bxzug/+dO ouDL5gLxfar80OcVH9FfV/HTM4LScCPHjrLXrNj37O7xIzpFeZxXlWAh0AaGwg6yYSO0 0ebVhqEiPld2aLCJZoxSn0Z1tZPEZzlQA48sqeJOwJPbZSwyJkXPJDCbO52naObIAKUr s9ymd9XkoLqYVYkYt7jcq3XMVmUlkrjYfB6BhkSIAYPh8xx9beLBfrppKvV6hkHwCgiE pB+6N8V2V8rnq7r1mqzq3qQ+T8Ju8qongvYa9lQejtGhLXkGUI9dZ09zkS8mvFWu/sG2 MfwQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s21si25430947iow.57.2021.11.08.07.41.15; Mon, 08 Nov 2021 07:41:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238676AbhKHKtk (ORCPT + 99 others); Mon, 8 Nov 2021 05:49:40 -0500 Received: from mail.netfilter.org ([217.70.188.207]:46924 "EHLO mail.netfilter.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237306AbhKHKtj (ORCPT ); Mon, 8 Nov 2021 05:49:39 -0500 Received: from netfilter.org (unknown [78.30.32.163]) by mail.netfilter.org (Postfix) with ESMTPSA id 518B76063C; Mon, 8 Nov 2021 11:44:55 +0100 (CET) Date: Mon, 8 Nov 2021 11:46:49 +0100 From: Pablo Neira Ayuso To: Simon Horman Cc: yangxingwu , ja@ssi.bg, kadlec@netfilter.org, fw@strlen.de, davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, lvs-devel@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, corbet@lwn.net, Chuanqi Liu Subject: Re: [PATCH nf-next v6] netfilter: ipvs: Fix reuse connection if RS weight is 0 Message-ID: References: <20211104031029.157366-1-xingwu.yang@gmail.com> <20211104140401.GA16560@vergenet.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20211104140401.GA16560@vergenet.net> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 04, 2021 at 03:04:04PM +0100, Simon Horman wrote: > On Thu, Nov 04, 2021 at 11:10:29AM +0800, yangxingwu wrote: > > We are changing expire_nodest_conn to work even for reused connections when > > conn_reuse_mode=0, just as what was done with commit dc7b3eb900aa ("ipvs: > > Fix reuse connection if real server is dead"). > > > > For controlled and persistent connections, the new connection will get the > > needed real server depending on the rules in ip_vs_check_template(). > > > > Fixes: d752c3645717 ("ipvs: allow rescheduling of new connections when port reuse is detected") > > Co-developed-by: Chuanqi Liu > > Signed-off-by: Chuanqi Liu > > Signed-off-by: yangxingwu > > Acked-by: Simon Horman > > (v5 was acked by Julian, probably that can be propagated here) > > Pablo, please consider this for nf-next at your convenience. Applied this fix to nf, thanks.