Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <6c88b81b-85d5-b997-9b69-02f7d05a54c3@de.ibm.com>
Date:   Mon, 8 Nov 2021 13:50:40 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
Subject: Re: [PATCH] KVM: s390x: add debug statement for diag 318 CPNC data
Content-Language: en-US
To:     Janosch Frank <frankja@linux.ibm.com>,
        Collin Walling <walling@linux.ibm.com>,
        linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
        kvm@vger.kernel.org
Cc:     david@redhat.com, imbrenda@linux.ibm.com
References: <20211027025451.290124-1-walling@linux.ibm.com>
 <4488b572-11bf-72ff-86c0-395dfc7b3f71@linux.ibm.com>
 <28d90d6f-b481-3588-cd33-39624710b7bd@de.ibm.com>
 <7e785ecc-1ddb-9357-e961-4498d1bf59fd@linux.ibm.com>
From:   Christian Borntraeger <borntraeger@de.ibm.com>
In-Reply-To: <7e785ecc-1ddb-9357-e961-4498d1bf59fd@linux.ibm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


Am 08.11.21 um 13:48 schrieb Janosch Frank:
> On 11/8/21 13:04, Christian Borntraeger wrote:
>>
>>
>> Am 08.11.21 um 12:12 schrieb Janosch Frank:
>>> On 10/27/21 04:54, Collin Walling wrote:
>>>> The diag 318 data contains values that denote information regarding the
>>>> guest's environment. Currently, it is unecessarily difficult to observe
>>>> this value (either manually-inserted debug statements, gdb stepping, mem
>>>> dumping etc). It's useful to observe this information to obtain an
>>>> at-a-glance view of the guest's environment, so lets add a simple VCPU
>>>> event that prints the CPNC to the s390dbf logs.
>>>>
>>>> Signed-off-by: Collin Walling <walling@linux.ibm.com>
>>>> ---
>>>>    arch/s390/kvm/kvm-s390.c | 1 +
>>>>    1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
>>>> index 6a6dd5e1daf6..da3ff24eabd0 100644
>>>> --- a/arch/s390/kvm/kvm-s390.c
>>>> +++ b/arch/s390/kvm/kvm-s390.c
>>>> @@ -4254,6 +4254,7 @@ static void sync_regs_fmt2(struct kvm_vcpu *vcpu)
>>>>        if (kvm_run->kvm_dirty_regs & KVM_SYNC_DIAG318) {
>>>>            vcpu->arch.diag318_info.val = kvm_run->s.regs.diag318;
>>>>            vcpu->arch.sie_block->cpnc = vcpu->arch.diag318_info.cpnc;
>>>> +        VCPU_EVENT(vcpu, 2, "setting cpnc to %d", vcpu->arch.diag318_info.cpnc);
>>>>        }
>>>>        /*
>>>>         * If userspace sets the riccb (e.g. after migration) to a valid state,
>>>>
>>>
>>> Won't that turn up for every vcpu and spam the log?
>>
>> only if the userspace always sets the dirty bit (which it should not).
>>
> 
> But that's exactly what it does, no?
> We do a loop over all vcpus and call kvm_s390_set_diag318() which sets the info in kvm_run and sets the diag318 bit in the kvm_dirty_regs.

Yes, ONCE per CPU. And this is exactly what I want to see. (and it did show a bug in qemu that we only set it for one cpu to the correct value).

> 
> @Collin: Could you check that please?