Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <7047ccc5-0927-f304-4d60-181d61344f8b@redhat.com>
Date:   Mon, 8 Nov 2021 13:54:14 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
Subject: Re: [PATCH v3 0/6] Cleanups for the nomodeset kernel command line
 parameter logic
Content-Language: en-US
To:     Thomas Zimmermann <tzimmermann@suse.de>,
        linux-kernel@vger.kernel.org
Cc:     Pekka Paalanen <pekka.paalanen@collabora.com>,
        Jani Nikula <jani.nikula@intel.com>,
        Daniel Vetter <daniel.vetter@ffwll.ch>,
        =?UTF-8?Q?Michel_D=c3=a4nzer?= <michel@daenzer.net>,
        dri-devel@lists.freedesktop.org,
        Peter Robinson <pbrobinson@gmail.com>
References: <20211108121544.776590-1-javierm@redhat.com>
 <509f58a5-5276-5608-e3ba-4694956f6c50@suse.de>
From:   Javier Martinez Canillas <javierm@redhat.com>
In-Reply-To: <509f58a5-5276-5608-e3ba-4694956f6c50@suse.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hello Thomas,

On 11/8/21 13:50, Thomas Zimmermann wrote:
> Hi
> 
> Am 08.11.21 um 13:15 schrieb Javier Martinez Canillas:
>> There is a lot of historical baggage on this parameter. It is defined in
>> the vgacon driver as nomodeset, but its set function is called text_mode()
>> and the value queried with a function named vgacon_text_force().
>>
>> All this implies that it's about forcing text mode for VGA, yet it is not
>> used in neither vgacon nor other console driver. The only users for these
>> are DRM drivers, that check for the vgacon_text_force() return value to
>> determine whether the driver should be loaded or not.
>>
>> That makes it quite confusing to read the code, because the variables and
>> function names don't reflect what they actually do and also are not in the
>> same subsystem as the drivers that make use of them.
>>
>> This patch-set attempts to cleanup the code by moving the nomodseset param
>> to the DRM subsystem and do some renaming to make their intention clearer.
>>
>> This is a v3 of the patches, that address issues pointed out by Jani Nikula
>> in v2: https://lkml.org/lkml/2021/11/4/594
>>
>> Patch #1 and #2 are just trivial cleanups.
>>
>> Patch #3 moves the nomodeset boot option to the DRM subsystem and renames
>> the variables and functions names.
>>
>> Patch #4 removes the relationship between the nomodeset parameter and the
>> CONFIG_VGA_CONSOLE Kconfig symbol.
> 
> On patches 1 to 4
> 
> Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
>

Thanks!
 
>>
>> Patch #5 adds nomodeset to the kernel parameters documentation.
>>
>> Patch #6 improves the message when nomodeset is enabled to make it more
>> accurate and less sensational.
> 
> See my comments on these patches.
>

Yes, agreed with your feedback on these. I'll improve it when posting a v4.

Best regards, -- 
Javier Martinez Canillas
Linux Engineering
Red Hat