Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] ASoC: SOF: build compression interface into snd_sof.ko
To:     Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        Arnd Bergmann <arnd@kernel.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
        Kai Vehmanen <kai.vehmanen@linux.intel.com>
Cc:     Arnd Bergmann <arnd@arndb.de>, Mark Brown <broonie@kernel.org>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Colin Ian King <colin.king@canonical.com>,
        Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        Bud Liviu-Alexandru <budliviu@gmail.com>,
        Paul Olaru <paul.olaru@oss.nxp.com>,
        sound-open-firmware@alsa-project.org, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org
References: <20211108111132.3800548-1-arnd@kernel.org>
 <63c5b1fb-575e-f026-5a76-f08a366f7f38@linux.intel.com>
From:   Daniel Baluta <daniel.baluta@nxp.com>
Message-ID: <bae1a17c-af6e-d77a-19e7-f3f6408951fa@nxp.com>
Date:   Mon, 8 Nov 2021 16:13:29 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
In-Reply-To: <63c5b1fb-575e-f026-5a76-f08a366f7f38@linux.intel.com>
Content-Type: multipart/mixed;
 boundary="------------791C240922A1805F6DA45D2B"
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y0p5U2cyZ0Z6N01oUUJZSEl3N1F0bWFGZ25HMGd3TVFCV3dYck92cXRLaGs2?=
 =?utf-8?B?NFJ4QUdDdkpLTW1naWkvbVBUekVxbGY4OC9abTU4ZkhQMGhETzh0c1diQW81?=
 =?utf-8?B?cVB0enQ3L3drTjFKUW9LRkwxbktFOEN1cDhjY25ETWgwbjN3VHlLbzRoeVlu?=
 =?utf-8?B?QmJkdzRrSzl4a011MjNNM1RLcHJMSm5yazlkeFduZXZGY3o5QkVHdmdsTDdn?=
 =?utf-8?B?S2d5WEV1QTBpM0xDM2plSFdqeXloemZLL2dreFRBanVQY1l2L3YvMk5RN2ND?=
 =?utf-8?B?UHJXWlBaR0xrOUN4RXVHa3IrRmhELzdzSzhvNk1QNnBwbWg4dHdCazI4Mzhz?=
 =?utf-8?B?L3JkMkhTL1ZnM2pVRkhHc1JwL3RIRWNOUzN1TXdYYnExM25WMlI3ZEFUWThH?=
 =?utf-8?B?ZDN3UjRGeldZWXU3YWFSSjFDQlNLZC92Y0txU0lmMStuKzVqaU5DbVZXVlBK?=
 =?utf-8?B?MWZEK0Y2eW1iZmlIeHRtR2x6c0VFcXU2Q2hTVmU1T1JONmUzdVRyVVkyZ00r?=
 =?utf-8?B?bWNBMElObFFCeWZ3VjdJRzAzRnltZzhEWkFpa2FQUkZVOHVOQ21QMHBnQXFO?=
 =?utf-8?B?dmFMc1pXczJ4NTNPYjlYMUJ3Zng3Z1J5Nm0vT29SWmpWUG83TUV5RkVIZWVh?=
 =?utf-8?B?TlZtMVZTL09VVDJ0ZHFDV2dLemJSVVU3dWVVMnFNK2VWbVJMYm01NXdwQzBO?=
 =?utf-8?B?ODBZNi9yWVlaQ2xFcW1reDdRRXliNWR6ejFrcEV0cWQyeUZnRVNIVm9zT1VW?=
 =?utf-8?B?SnRtRE5IQUZna2NQTWh5QVVIUXd3dU9KbzlHM1R2bHhCM0NiR0dlNVFlK0hn?=
 =?utf-8?B?ek03b0pyVVp0YVlnQkpUYWZwdDRmNk1acS9kTFpFd0tCUFhvWXVuNjNYdnVj?=
 =?utf-8?B?a2t1Q1gyb3NLRWZmMzhySXF5MXV6cTZDQm05b1lHdTM0RUkzbWVpTG55UWZ0?=
 =?utf-8?B?WkQ3Rk8yQXlZMEdWR2FVVXZhc3cyNis2Ry9mbndMVVdYY2JkUW1TV2tXNUpv?=
 =?utf-8?B?aEhtUUpWWDgwRDY3SFduaURTWUhBcGtGSU92ZVBXeVFGNkV6MzYwdVlXa2dE?=
 =?utf-8?B?STNlVlRDRGRNZzZDUjdhZHY5NkxhN0ozeFQvVDgzS3d2ZlRMSXUwR3pHenhX?=
 =?utf-8?B?UEJiRFd2OTZzaU1lVmVCT0xjNVJrdmJjUlptTU4zcjFOUXZnWUJlWjF0dVRF?=
 =?utf-8?B?RWRJQVNWSkpiSG56WW9mYWlncG9mRzNsM3VTckkwVUlHSlNPU2o2c3NqNDEy?=
 =?utf-8?B?a3lReTQvaWFJT241dE11V1dmZ21WZ3dhSTdkYk9UVVo2ZU5COHUvb013TnRB?=
 =?utf-8?B?bEYxRjBqaW5JcnE0Q1FqdTMzUjRIc3pOU05zN3JZOG1ONW1OVGJkektreGZK?=
 =?utf-8?B?STh6ZnJSVGozaHdlUW1xK1NnaTJkOWsxZW1aU2lDNnE2RGZ4K3c3cEdnVlly?=
 =?utf-8?B?bUtWU2FKWmlMVDBQY3h2VXhjSFZVcUJOQWgxazcxYlM1ZUpmV1owcFhHUFZN?=
 =?utf-8?B?S1pPR054K0tUczBtdDZ0OU5aSy9wcmFWbVRZbE4xYkFBZ3RySUIybXpCb2VI?=
 =?utf-8?B?Y0t2cXRWU25KQUZFcHdJbzdrLzlqZFJwYVV6VTlsYWQyakUzQTlsRTRCRVJn?=
 =?utf-8?B?cUE3NVpweSt5ZDJweFlRcmRuZTliTWZvTVVuaktBZlMydlFyTXUvdGo1dys4?=
 =?utf-8?B?dUw1emVKRnlLbWU1TVNVdWFlTUd1VG5BMXdZTmtseE9JZ1BsWFJlbXVEejNo?=
 =?utf-8?B?NlV1eGt1Ym9hSmtJTjhrTm9CVjAwYUZKLzFsbk85cTZkY3Yrb2U5Mm1kRTY1?=
 =?utf-8?B?MlkwV3dpSnJ4Wlh3YW1zYThTZlp1Slo5aUUvdG0reDhsRU9jU2F5MVNEZE1U?=
 =?utf-8?B?YjA1RHB1dzNheDRWdEVjeldQMnlWaTFOZWlFWkh3bzh3N3BQRjFDc0dNRGIz?=
 =?utf-8?B?ZVNrTmI2Sm41VjAxcG5XM1JHU2NxL3Q2WkdYalMzYVQ0ZVplT3BKQkVJa01B?=
 =?utf-8?B?UGFhVCtiOExIR09WN3JhUnZjeGhsOWFoSlVkVDFCVVQwWGdPZnVoSitXSGJJ?=
 =?utf-8?B?ZXlVQXZQOXMrcWR1MlFORUpTSXdwTWMyMWNBVlVwTGtacEdrL0plaXdIVFZt?=
 =?utf-8?B?aEgyY096Y2ltUUlzbEJ1bDZjZzJJVklaUXJMMUZzdVFEUXZWdkwvdUNCVE5u?=
 =?utf-8?B?VTIrai9hdTJiSXRQTXRlaTI4MUVURnhnWW9ITEh2SThoczBieHJKcFNVS0JE?=
 =?utf-8?Q?ShEUo6PSLp0tWSeCObfN4XMS3ogStk0zbDCtZJa38Q=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: eb1cbde3-98f1-4b57-cd23-08d9a2c1f1be
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5151.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2021 14:13:31.9726
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QJnB4SzU2kmTHa6K1BOGJiuBtswsLlanldQzYqYShzYK/lkWhAZUVO4j74UFt26PjQst0tzBa75A5zcRQmjqDw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7055
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

--------------791C240922A1805F6DA45D2B
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit


On 11/8/21 3:39 PM, Pierre-Louis Bossart wrote:
>
> On 11/8/21 5:11 AM, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> With CONFIG_SND_SOC_SOF_COMPRESS=m, the compression code is
>> not built into a the main SOF driver when that is built-in:
>>
>> x86_64-linux-ld: sound/soc/sof/ipc.o: in function `ipc_stream_message':
>> ipc.c:(.text+0x5a2): undefined reference to `snd_sof_compr_fragment_elapsed'
>> x86_64-linux-ld: sound/soc/sof/topology.o: in function `sof_dai_load':
>> topology.c:(.text+0x32d1): undefined reference to `snd_sof_compr_init_elapsed_work'
>> x86_64-linux-ld: topology.c:(.text+0x32e1): undefined reference to `snd_sof_compr_init_elapsed_work'
>>
>> Make this a 'bool' symbol so it just decides whether the
>> code gets built at all.
>>
>> Fixes: 858f7a5c45ca ("ASoC: SOF: Introduce fragment elapsed notification API")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> It's Monday morning and my memory is still foggy but I think we fixed
> this problem with https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fthesofproject%2Flinux%2Fpull%2F3180&amp;data=04%7C01%7Cdaniel.baluta%40nxp.com%7C25ac869cfd1040f1be1708d9a2bd3460%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637719755777370422%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=E4K2DPkpLX2SgVJ1K99Qs3uz7l7mS96gIzYlJw9akbg%3D&amp;reserved=0,
> where we changed the Kconfigs for i.MX. We haven't sent this update
> upstream for some reason.
>
> Arnd, can you share the configuration that breaks with the existing
> upstream code, I can check if the problem still exists.


Maybe someone forgot :) to send 
https://github.com/thesofproject/linux/pull/3180/commits/7122edc88d13db8ba835bdb20f7444ae535f9ffa 
upstream.

I think that's me.

Arnd can you run your scripts with 
https://github.com/thesofproject/linux/pull/3180/commits/7122edc88d13db8ba835bdb20f7444ae535f9ffa. 
I also attached the patch

if it's easier to apply.


--------------791C240922A1805F6DA45D2B
Content-Type: text/x-patch; charset=UTF-8;
 name="0001-ASoC-SOF-i.MX-simplify-Kconfig.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0001-ASoC-SOF-i.MX-simplify-Kconfig.patch"

From 8393b756c476a513fc69016d701f22899724fb73 Mon Sep 17 00:00:00 2001
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Date: Mon, 27 Sep 2021 13:54:38 -0500
Subject: [PATCH] ASoC: SOF: i.MX: simplify Kconfig

Follow the Intel example and simplify the Kconfig
a) start from the end-product for 'select' chains
b) use 'depends on' to filter out configurations.
c) use snd-sof-of as a common module without any 'select'

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>
---
 sound/soc/sof/Kconfig     |  4 +++-
 sound/soc/sof/Makefile    |  2 +-
 sound/soc/sof/imx/Kconfig | 46 +++++++++++----------------------------
 3 files changed, 17 insertions(+), 35 deletions(-)

diff --git a/sound/soc/sof/Kconfig b/sound/soc/sof/Kconfig
index 6bb4db87af03..98ba48982736 100644
--- a/sound/soc/sof/Kconfig
+++ b/sound/soc/sof/Kconfig
@@ -40,12 +40,14 @@ config SND_SOC_SOF_ACPI_DEV
 config SND_SOC_SOF_OF
 	tristate "SOF OF enumeration support"
 	depends on OF || COMPILE_TEST
-	select SND_SOC_SOF
 	help
 	  This adds support for Device Tree enumeration. This option is
 	  required to enable i.MX8 devices.
 	  Say Y if you need this option. If unsure select "N".
 
+config SND_SOC_SOF_OF_DEV
+	tristate
+
 config SND_SOC_SOF_COMPRESS
 	tristate
 	select SND_SOC_COMPRESS
diff --git a/sound/soc/sof/Makefile b/sound/soc/sof/Makefile
index 06e5f49f7ee8..1dac5cb4dfd6 100644
--- a/sound/soc/sof/Makefile
+++ b/sound/soc/sof/Makefile
@@ -17,7 +17,7 @@ obj-$(CONFIG_SND_SOC_SOF_NOCODEC) += snd-sof-nocodec.o
 
 
 obj-$(CONFIG_SND_SOC_SOF_ACPI_DEV) += snd-sof-acpi.o
-obj-$(CONFIG_SND_SOC_SOF_OF) += snd-sof-of.o
+obj-$(CONFIG_SND_SOC_SOF_OF_DEV) += snd-sof-of.o
 obj-$(CONFIG_SND_SOC_SOF_PCI_DEV) += snd-sof-pci.o
 
 obj-$(CONFIG_SND_SOC_SOF_INTEL_TOPLEVEL) += intel/
diff --git a/sound/soc/sof/imx/Kconfig b/sound/soc/sof/imx/Kconfig
index 34cf228c188f..9b8d5bb1e449 100644
--- a/sound/soc/sof/imx/Kconfig
+++ b/sound/soc/sof/imx/Kconfig
@@ -11,53 +11,33 @@ config SND_SOC_SOF_IMX_TOPLEVEL
 
 if SND_SOC_SOF_IMX_TOPLEVEL
 
-config SND_SOC_SOF_IMX_OF
-	def_tristate SND_SOC_SOF_OF
-	select SND_SOC_SOF_IMX8 if SND_SOC_SOF_IMX8_SUPPORT
-	select SND_SOC_SOF_IMX8M if SND_SOC_SOF_IMX8M_SUPPORT
-	help
-	  This option is not user-selectable but automagically handled by
-	  'select' statements at a higher level.
-
 config SND_SOC_SOF_IMX_COMMON
 	tristate
+	select SND_SOC_SOF_OF_DEV
+	select SND_SOC_SOF
+	select SND_SOC_SOF_XTENSA
+	select SND_SOC_SOF_COMPRESS
 	help
 	  This option is not user-selectable but automagically handled by
 	  'select' statements at a higher level.
 
-config SND_SOC_SOF_IMX8_SUPPORT
-	bool "SOF support for i.MX8"
-	depends on IMX_SCU=y || IMX_SCU=SND_SOC_SOF_IMX_OF
-	depends on IMX_DSP=y || IMX_DSP=SND_SOC_SOF_IMX_OF
+config SND_SOC_SOF_IMX8
+	tristate "SOF support for i.MX8"
+	depends on IMX_SCU
+	depends on IMX_DSP
+	select SND_SOC_SOF_IMX_COMMON
 	help
 	  This adds support for Sound Open Firmware for NXP i.MX8 platforms.
 	  Say Y if you have such a device.
 	  If unsure select "N".
 
-config SND_SOC_SOF_IMX8
-	tristate
+config SND_SOC_SOF_IMX8M
+	tristate "SOF support for i.MX8M"
+	depends on IMX_DSP
 	select SND_SOC_SOF_IMX_COMMON
-	select SND_SOC_SOF_XTENSA
-	select SND_SOC_SOF_COMPRESS
-	help
-	  This option is not user-selectable but automagically handled by
-	  'select' statements at a higher level.
-
-config SND_SOC_SOF_IMX8M_SUPPORT
-	bool "SOF support for i.MX8M"
-	depends on IMX_DSP=y || IMX_DSP=SND_SOC_SOF_OF
 	help
 	  This adds support for Sound Open Firmware for NXP i.MX8M platforms.
 	  Say Y if you have such a device.
 	  If unsure select "N".
 
-config SND_SOC_SOF_IMX8M
-	tristate
-	select SND_SOC_SOF_IMX_COMMON
-	select SND_SOC_SOF_XTENSA
-	select SND_SOC_SOF_COMPRESS
-	help
-	  This option is not user-selectable but automagically handled by
-	  'select' statements at a higher level.
-
-endif ## SND_SOC_SOF_IMX_IMX_TOPLEVEL
+endif ## SND_SOC_SOF_IMX_TOPLEVEL
-- 
2.27.0


--------------791C240922A1805F6DA45D2B--