Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Valentin Schneider <valentin.schneider@arm.com>
To:     Mike Galbraith <efault@gmx.de>, linux-kernel@vger.kernel.org
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@kernel.org>,
        Frederic Weisbecker <frederic@kernel.org>
Subject: Re: [PATCH] sched: Tweak default dynamic preempt mode selection
In-Reply-To: <5543627ee8ac5337a74de4b9671240d617273607.camel@gmx.de>
References: <20211105104035.3112162-1-valentin.schneider@arm.com> <ff53a94401f8d6abe0303ee381f86bfb475ad354.camel@gmx.de> <8735o6uca5.mognet@arm.com> <5543627ee8ac5337a74de4b9671240d617273607.camel@gmx.de>
Date:   Mon, 08 Nov 2021 15:21:56 +0000
Message-ID: <87zgqesmej.mognet@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On 08/11/21 13:27, Mike Galbraith wrote:
> On Mon, 2021-11-08 at 11:17 +0000, Valentin Schneider wrote:
>> On 06/11/21 05:40, Mike Galbraith wrote:
>> >
>> > Starting with a 5.15 config, to select RT you currently must first
>> > select a model you don't want, then reject PREEMPT_DYNAMIC and you'll
>> > be offered the full menu of models immediately. With your patch added,
>> > that became worse.  After rejecting PREEMPT_DYNAMIC, I had to go
>> > through new 5.15+ options before finally being offered the full menu.
>> >
>>
>> Do you mean at the syncconfig step?
>
> Um, not sure what that is, but it sounds about right.
>
>> I've only really played with upstream
>> arm64 / x86 defconfigs and didn't have to fight with any prompts, though
>> yes for x86 the default-y PREEMPT_DYNAMIC makes it a bit annoying to select
>> PREEMPT_RT.
>
> As long as RT depends on EXPERT it'll be a bit annoying regardless.  I
> just thought it worth mention that what you want now and what RT will
> presumably want upon merge completion appear to be mutually exclusive.
>

Hmm actually I think your approach should work, i.e. have

  config PREEMPT_DYNAMIC
    depends on [...] && !PREEMPT_RT

rather than

  config PREEMPT_RT
    depends on [...] && !PREEMPT_DYNAMIC

This essentially gives priority to the preemption model type over the
preemption model dynamicness, which I think makes sense. I can fold that in
v2.

>       -Mike