Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: Question: SMMUv3 PMU event aliasing
To:     Leo Yan <leo.yan@linaro.org>, <linux-perf-users@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20211108121941.GC1267967@leoy-ThinkPad-X240s>
CC:     "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>
From:   John Garry <john.garry@huawei.com>
Message-ID: <8b24f36b-6459-c13c-bf19-b9f588eb6b8e@huawei.com>
Date:   Mon, 8 Nov 2021 12:41:33 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.1
MIME-Version: 1.0
In-Reply-To: <20211108121941.GC1267967@leoy-ThinkPad-X240s>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 08/11/2021 12:19, Leo Yan wrote:
> Hi John,
> 
> [ + mailing list ]

Hi Leo,

> 
> I'd like to confirm the latest upstream status for SMMUv3 PMU event
> aliasing.
> 
> I see the patch set v6 of "perf pmu-events: Support event aliasing for
> system PMUs" [1] has been landed on the mainline kernel, and as an
> example, imx8mm DDR PMU has been supported as system PMU [2].
> 
> On the other hand, I can see patch set 5 contains the SMMUv3 PMU event
> aliasing with patch "perf vendor events arm64: Add Architected events
> smmuv3-pmcg.json" [3], but this patch was left out in patch set 6 and
> it's never landed on the mainline kernel.
> 
> Could you share current status (or plan) for upstreaming SMMUv3 PMU
> event alias?  Or if there have any block issue to prevent merging the
> changes in the mainline kernel?

This feature should be supported in the SMMUv3 PMU kernel driver and 
perf tool.

However it relies on the SMMU PMU identifier sysfs file to work. This 
relies on SMMU_PMCG_IIDR being set, which is introduced latest spec, 
which not much HW will support yet - see commit 2c255223362e. In theory 
we don't need that for the fixed, non-IMPDEF events, but I did not 
complicate perf tool with that mixed support.

That's the reason for which I paused smmuv3-pmcg.json upstream in [3]. I 
will revive that for new gen HW when concrete IMPDEF events known and 
shared.

Thanks,
John

> 
> Thanks for your help!
> 
> Leo
> 
> [1] https://lore.kernel.org/lkml/1607080216-36968-1-git-send-email-john.garry@huawei.com/
> [2] pmu-events/arch/arm64/freescale/imx8mm/sys/ddrc.json
> [3] https://lore.kernel.org/lkml/1604666153-4187-6-git-send-email-john.garry@huawei.com/
> .
>