Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2 01/10] ASoC: tegra: Fix kcontrol put callback in ADMAIF
To:     Takashi Iwai <tiwai@suse.de>
Cc:     broonie@kernel.org, lgirdwood@gmail.com, perex@perex.cz,
        tiwai@suse.com, thierry.reding@gmail.com, jonathanh@nvidia.com,
        alsa-devel@alsa-project.org, linux-tegra@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <1635947547-24391-1-git-send-email-spujar@nvidia.com>
 <1635947547-24391-2-git-send-email-spujar@nvidia.com>
 <s5ha6ilmiiv.wl-tiwai@suse.de>
From:   Sameer Pujar <spujar@nvidia.com>
Message-ID: <418e4db8-4572-3e29-fb5d-e4c23280a5cc@nvidia.com>
Date:   Mon, 8 Nov 2021 21:38:45 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
In-Reply-To: <s5ha6ilmiiv.wl-tiwai@suse.de>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-GB
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZEhxQjNoYllDQ1daaGdjZVJUWURONVhoSUo2SmhIL3UzRW0wWjZWc080Vks2?=
 =?utf-8?B?R3hydkp0Yyt2RE5VQnNscnlHR2hNVHp5M21PV041LzNUdmdKUnhNK0ZnZDZW?=
 =?utf-8?B?amdmVExNby9MbzQrR0IxRUk3Qk1vWEt6ay9hRmEyN2lyNjN0Vk54Nm1SdkMz?=
 =?utf-8?B?cUlnWURKM2IvMGZpbzQyRnpDRU01cUdyYmYzTlE4d3hTOFR1THpuc09DbEZB?=
 =?utf-8?B?MjU3SVdtZFo4aVFMNVAvMFlmOTl4SVhmNHlubWo1Qm5sb3RVUEZlL3l3aDJw?=
 =?utf-8?B?ZEVSektZYUZvSnBlNnZDNEtQSUVSN3dodzZMdDViTUgvdUFSSE1EVXZsWGhQ?=
 =?utf-8?B?RENBd3JWb3V5b2tTa2R6dGtXTmNGdGRDdzVuSFQrOGd5Mlp2dSt0WjVRaEJo?=
 =?utf-8?B?K1VDcmMySFgzSzRmaWZOTVZIUm9RaHphWC96aTJsNUUwZ2xheDdYaFByMnVo?=
 =?utf-8?B?b0l6RE1UWVdWU2FVQW9XR05wd3M5Z0JhVElEcW5vRUE2Y2s5U2pkRml4SzdC?=
 =?utf-8?B?b0FDbGtLRHBpczlyK2pwNUU5dHhtZFZmZTlGMFZ2c0hwRW9NTkZ5MkpXUWtD?=
 =?utf-8?B?cWxTWTljbkdxTGxsbUdUaGcxaHNjdFUvLzNlT0IxY3V5SjcxZVdlckhJaklQ?=
 =?utf-8?B?TytFSnhQOUtQeXNWVXNYUXBEUGRwN2JhN3R4dDA3dUpVZndTQVVRQnUxc1Iv?=
 =?utf-8?B?UVd4N3pwL3FuK1FPY2xnUWw3WE9oVEJPQ1pIUDBKVU5lRDA4bkpvVnFCSnkz?=
 =?utf-8?B?S2JJUXhzQUJFZnIwTGFzeWlpVEUrVDZNblpsVFB1d2M0Yll1RzlHak5MYVFz?=
 =?utf-8?B?UC9IOGx0enUvYlhscStvTUthQm1lYWsrS0FuTmdtNTV1Q3poT21uY3ZqN1Z0?=
 =?utf-8?B?WE82MnNzazd2d0g2WFUzcENxQTdvVktDR2VIaEZGWFdUS1hpcFBxRzlLblpD?=
 =?utf-8?B?SHB6ZElJMkladXRhZkY1azJNbkVaM1BvdmNnRVV5bFBWOHBvMHc5VmRoM1J2?=
 =?utf-8?B?S1Eybk1UTjRla3pUeDk1cmh6cE1TdTNxMXBXczcvOGRDLzIyLzdZbHl5bXJr?=
 =?utf-8?B?OVZrUnlkSDhlT1VmQkNFb28veHQwTEJ3bUE2eFlXUnViOUVmMWdWaitwK2Zu?=
 =?utf-8?B?dXNjMHBLVlFQNU5laFR4R2VJa1dSOGIyMGgvRjVIZjQzWG1rM2htUVVTUEFZ?=
 =?utf-8?B?VFJXcnp6VUp3S3c3OE0zU2JGTFh4bXMrNlpueDJnOU9mQ1lnZlRsK08wdUEx?=
 =?utf-8?B?N1ZFNXQveU9zMThMVWpINkF4YzRxRWhnb3JlTjFLYlRRUHh1N0ZKWTdOR1BZ?=
 =?utf-8?B?WnlON1NSWDFWcGhJekFvTTRGNzMwSnE4WWs4amFqL2pYc1o1NWV3amFXUGlJ?=
 =?utf-8?B?alpmSVZiWUVRVG5scDRZeDFyd3E2djUzUDdPSFBIemVHbkxoRTV4UXVaS2cv?=
 =?utf-8?B?YVZIVy9mTHNPNmxoWXdjSytBSUNzTXQvam1FYXBTU25mNEtOQ3JwVHp6NFlF?=
 =?utf-8?B?V1Q3aGFqM1NEZ0VKMC96dnJXMWorVHZtcTVsdXgrN1Vmd0pMUFFNL1lWcS9n?=
 =?utf-8?B?cGVpN0hudW13RWpaMTFFcjdQY2p1T0FOVkl5N05FdCs0dHRaOG5sNFhrTnBW?=
 =?utf-8?B?NTZ0V3VoZXRqRlpYSld4ZFBEcVp6REdWNVFxMVAyOUZoSlVWcUxWcFVSSkd0?=
 =?utf-8?B?a1ZTLzVvZnBKT25PUzJvQlUrckw2V3JQK1BUOWk1Y29WQXRMazlRS2RKSG8x?=
 =?utf-8?B?R2tMNHBFeVg4V2JDLzFtUm1WUStUZnd2Vmx2emVjQW9JeEJYbXZBTGxMVlhD?=
 =?utf-8?B?Wit4UXE2SkdmOE5oWmlPYnVJVHlneHNXem9IdUR0THRKQUJsazZOdXZaU2Yr?=
 =?utf-8?B?MVRXRXp6NURqUnlkUmg3Zy9nQTMvdmRSZUlVVUhqb3RKTmFTUkQvZFd1SWVp?=
 =?utf-8?B?c3J3cXR3TjNheDg1WFFkd1BQZnZqMXNRclhkWkFOUTlZVjYya3F3RzBNbXVV?=
 =?utf-8?B?cGNFTXZGVmJrTXAyNFpRaTE2RDF3cmhqZHdTSlhaNkV5U2R5V0lDcXlmWVli?=
 =?utf-8?B?MUV5aS9BOENRMmpSTC9jbVVYSFczWDZDclhFUDN6QUt0YnNLeXZ4UDJjakxV?=
 =?utf-8?B?TERvQ0doT2Vxc0FoOWRycjlKb2tVV2MvS3pIaUpCYmFpZXFMbnF0VUlBR29W?=
 =?utf-8?Q?qzsuqxIH3s+0aWRjD8HJUts=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ae6fce57-634f-4503-ad9a-08d9a2d2147b
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5317.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2021 16:09:02.2277
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TMkSWoUpMBH/6lhEwQMLM5UMa0dQ2pCRa2R8tnFfS67kfwMEgtG0hV+1CAjV1EXsLNzl3zbVVdElB3PoTPP5aQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5045
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 11/3/2021 7:46 PM, Takashi Iwai wrote:
> BTW, independent from this patch set, I noticed that those get/put
> callbacks handle the wrong type.  For enum ctls, you have to use
> ucontrol->value.enumerated.value instead of
> ucontrol->value.integer.value.  The former is long while the latter is
> int, hence they may have different sizes.
>
> Such a bug could be caught if you test once with
> CONFIG_SND_CTL_VALIDATION=y.  It's recommended to test with that
> config once for a new driver code.
>
> So, please submit the fix patch(es) for correcting the ctl value
> types, too.

Thanks for suggesting. I will include fixes for this as well in current 
series.