Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 8 Nov 2021 16:32:33 +0100
From:   Daniel Vetter <daniel@ffwll.ch>
To:     Thomas Zimmermann <tzimmermann@suse.de>
Cc:     Javier Martinez Canillas <javierm@redhat.com>,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
        Jani Nikula <jani.nikula@intel.com>,
        Peter Robinson <pbrobinson@gmail.com>,
        Michel =?iso-8859-1?Q?D=E4nzer?= <michel@daenzer.net>,
        Pekka Paalanen <pekka.paalanen@collabora.com>,
        Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH v3 5/6] Documentation/admin-guide: Document nomodeset
 kernel parameter
Message-ID: <YYlDETv8pVM+0SJo@phenom.ffwll.local>
Mail-Followup-To: Thomas Zimmermann <tzimmermann@suse.de>,
        Javier Martinez Canillas <javierm@redhat.com>,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
        Jani Nikula <jani.nikula@intel.com>,
        Peter Robinson <pbrobinson@gmail.com>,
        Michel =?iso-8859-1?Q?D=E4nzer?= <michel@daenzer.net>,
        Pekka Paalanen <pekka.paalanen@collabora.com>
References: <20211108121544.776590-1-javierm@redhat.com>
 <20211108121544.776590-6-javierm@redhat.com>
 <0f152d33-6362-b04b-6661-1d5cd7f32015@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <0f152d33-6362-b04b-6661-1d5cd7f32015@suse.de>
Precedence: bulk

On Mon, Nov 08, 2021 at 01:48:24PM +0100, Thomas Zimmermann wrote:
> Hi
> 
> Am 08.11.21 um 13:15 schrieb Javier Martinez Canillas:
> > The nomodeset kernel command line parameter is not documented. Its name
> > is quite vague and is not intuitive what's the behaviour when it is set.
> > 
> > Document in kernel-parameters.txt what actually happens when nomodeset
> > is used. That way, users could know if they want to enable this option.
> > 
> > Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
> > ---
> > 
> > (no changes since v1)
> > 
> >   Documentation/admin-guide/kernel-parameters.txt | 4 ++++
> >   1 file changed, 4 insertions(+)
> > 
> > diff --git Documentation/admin-guide/kernel-parameters.txt Documentation/admin-guide/kernel-parameters.txt
> > index 91ba391f9b32..ed9859fd0734 100644
> > --- Documentation/admin-guide/kernel-parameters.txt
> > +++ Documentation/admin-guide/kernel-parameters.txt
> > @@ -3521,6 +3521,10 @@
> >   			shutdown the other cpus.  Instead use the REBOOT_VECTOR
> >   			irq.
> > +	nomodeset	Disable kernel modesetting. DRM drivers will not be
> > +			loaded when this kernel boot parameter is used. The
> > +			simpledrm driver is the only DRM driver that loads.
> > +
> 
> That's misleading and to the general admin it might not be clear what
> simpledrm is about. Rather say something like
> 
>  Disable kernel modesetting. DRM drivers will not perform
>  display-mode changes or accelerated rendering. Only the
>  system framebuffer will be available for use. Requires the
>  firmware or boot loader to setup the display. Useful as
>  fallback, or for testing and debugging.

Yeah I think that's much clearer. With that wording:

Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>

> 
> Best regards
> Thomas
> 
> >   	nomodule	Disable module load
> >   	nopat		[X86] Disable PAT (page attribute table extension of
> > 
> 
> -- 
> Thomas Zimmermann
> Graphics Driver Developer
> SUSE Software Solutions Germany GmbH
> Maxfeldstr. 5, 90409 N?rnberg, Germany
> (HRB 36809, AG N?rnberg)
> Gesch?ftsf?hrer: Ivo Totev


-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch