Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Maciej S. Szmigiero" <maciej.szmigiero@oracle.com>
Subject: Re: [PATCH v5.5 18/30] KVM: Don't make a full copy of the old memslot
 in __kvm_set_memory_region()
To:     Sean Christopherson <seanjc@google.com>
Cc:     James Morse <james.morse@arm.com>,
        Alexandru Elisei <alexandru.elisei@arm.com>,
        Suzuki K Poulose <suzuki.poulose@arm.com>,
        Atish Patra <atish.patra@wdc.com>,
        David Hildenbrand <david@redhat.com>,
        Cornelia Huck <cohuck@redhat.com>,
        Claudio Imbrenda <imbrenda@linux.ibm.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>,
        Joerg Roedel <joro@8bytes.org>,
        linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu,
        linux-mips@vger.kernel.org, kvm@vger.kernel.org,
        kvm-ppc@vger.kernel.org, kvm-riscv@lists.infradead.org,
        linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
        Ben Gardon <bgardon@google.com>, Marc Zyngier <maz@kernel.org>,
        Huacai Chen <chenhuacai@kernel.org>,
        Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>,
        Paul Mackerras <paulus@ozlabs.org>,
        Anup Patel <anup.patel@wdc.com>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Albert Ou <aou@eecs.berkeley.edu>,
        Christian Borntraeger <borntraeger@de.ibm.com>,
        Janosch Frank <frankja@linux.ibm.com>,
        Paolo Bonzini <pbonzini@redhat.com>
References: <20211104002531.1176691-1-seanjc@google.com>
 <20211104002531.1176691-19-seanjc@google.com>
Message-ID: <829b0c0b-7735-51d7-3728-b8fd1d54e92d@oracle.com>
Date:   Tue, 9 Nov 2021 01:41:09 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
In-Reply-To: <20211104002531.1176691-19-seanjc@google.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cjNralRtVFRLc2pQSVJaMEFaaDJxb3FKbjBPV3lTWTVla3RJb3VzeFg3Tm1W?=
 =?utf-8?B?Mkl0OTJwM3Rqa2N3dkxpeGp3ZWRzRkViTlh1Q3A2ZFZsTlBaZElxcDhBQjlp?=
 =?utf-8?B?MVZza1hDcHprcVBTaVVRNk04b2tyNEk0Zis0RGhIbW9ycWtVZFlyM0dKS2kw?=
 =?utf-8?B?YXFQMDdqa3pEbjh6WnBScStJb2NESFFZVkJidFdMMy8raG5JYTVyU01PNXlF?=
 =?utf-8?B?cTh1dFFVM2VzMFJ0TUhLbiszOGJUYUNlN1ZrQkVuOVVDM0lDY2FkSjQvOUEr?=
 =?utf-8?B?UlEwaGFQOTYwYzFFMWZCNTQ1S0llekVFRlp1TDFTUHFqMTE5Ny91U0J4TVl2?=
 =?utf-8?B?azZ5c3lNcmpFWktGMjFlcURGRG1GUFY5OWhpZ3AvRWpIM1dVQUZhcWJyVElW?=
 =?utf-8?B?aWdOczlzcmlnRkhJNXlsazhPSFhjR2h0WjFHeC9rRTVKWm5FckpEVUI1dlNB?=
 =?utf-8?B?L2Zkams2K3BuRHdBTWJ3eFYvREZSeGJRNXdkRlZzRk1kWnAzelhKbmsweERB?=
 =?utf-8?B?QjVwbTk1cEVnQm1XRkpwaGtaN3Rrd2w4cTZVWFN6a0tqSVZGS3d5Q3lEN2RS?=
 =?utf-8?B?MldQckdxZlljemJIQkhVNUhHSlR4aTFjNlQ5TkRxMjVtNzFhQ2FxMUlBU2ZK?=
 =?utf-8?B?OTFiK2l6NGhpVzJyZE5ESlFpYXZ6VTMrUG54THUyMjBxcEoraDZpRWQzek9n?=
 =?utf-8?B?YnpPR1g1MWNjekpwNFVqM1hWOU11VHBXWEhsRzhDNVNpQ0Y5RDB1WWFYQXNI?=
 =?utf-8?B?dEdnK2JvMGpqVWU2LzVDQmlhN1FmSldtWXlBWE40Q3A0T1dsZkFyWkd0WXdH?=
 =?utf-8?B?SDgvcHlaYjVPczF2ZmFSdndpZzFFTmxvQ01uVkF1UU5hYURJYlJzSkcvOE5r?=
 =?utf-8?B?YllMcE5PZUt6Y0NIL2dsY0MxU2V0SVJCcDVxY3JWcmlaaFV2aC9LWXE5UUph?=
 =?utf-8?B?aUh1bGJjYURmTkdxZjZJL1UzY3o1T0NkZHZMQmQxdkJUQjVkRlJqRnJZZVVY?=
 =?utf-8?B?TDFqSkwyMFZXNkJkdzRuRzNzVGFhWU1XRk9jdjVDUTFMMTY1V0hHODFWLzdT?=
 =?utf-8?B?NS9kaWt2M3FqZzdBbWpWNkUyVVdqQ0w4aDNkSTQ2Q1R6THVjMTJRcE1YUXh2?=
 =?utf-8?B?NTk5VDFtd0FtY0EvMnRURk9rZXIyQjVHL0Zxbk9DczFNV1FkTmxnZml4QXIy?=
 =?utf-8?B?bGhGS2ZuOFZqVzFUWGM0L0cvUEtlTnhOMVp1ZGw3eTgzTW83by9qcXlXNU9K?=
 =?utf-8?B?WTY4N2VRS3VuSmY0RWROajJmSEgralpjVzArNkNubkJCYXRsMStRMmgvaWF4?=
 =?utf-8?B?TFl2Q0NybjFRMkVVU20xZ25tL0RmQ21WNmwrUDNtdWRnalRMTlQ3Wko5NHMz?=
 =?utf-8?B?eElFTDE1VlNMaGNmMGNwTllOb1ZVbVFMeWtFUldLMWt6aEdhS0paOVFCUFlm?=
 =?utf-8?B?M21wYWxHVVZsalVjRXVLN0hDdkltb3lhVEhKTEdTK1NqQmVJd0p4NmFkU01p?=
 =?utf-8?B?TnpHOExVdDRMa2FEb0pITzM1bWNVUGltV1J4M25rUDNTMzgxSGhxNExndHdr?=
 =?utf-8?B?bURybDZOR2tNVlJqUFg2MHVjU0lHNzlhTXEyTEd1RnRsNDY0VGE2UXZvSFFE?=
 =?utf-8?B?ekduZ0k4eDVOK3ZZTXB3cDdDbmhUNFZsV2J3WEdITDNmT0tHcEJUdEdtamJK?=
 =?utf-8?B?b0E5WllOMU5LTXV1ekZiRldtUk5aSURFaFJjRUNvSHhtQzFSMnNQQnVyazVD?=
 =?utf-8?B?b1FCZHdLV2NhOFh4Ty9TdGZma244QXJIcGRSOVVENEpRS1YzeDdwdE5TclFY?=
 =?utf-8?B?RnFGaDE1RzJYNFJkQmh3RVRwWCtKa3FteDY1cS9RQzU4eS83ZjU5a014SzFq?=
 =?utf-8?B?bEM3MnBrTUhvckRUMjdmQjZOcEo2Z3IvUzFBZWFPYXd6K0l6N082all0L2x5?=
 =?utf-8?B?RlhXZGRCeTMxckxWVUdnSldBNEs0TEtqTHVuK2Y0QzNhWGhGTll4RFUyckZI?=
 =?utf-8?B?Vis3QS9HdVZUNk1rbm9DazZhOVhnYktUQzFMMkVyMzJMOTl1OUIwbEZOSnRj?=
 =?utf-8?B?OEZpN0FCaGxJOXJ2b1FzenVkdXBCcnRkamtlZVd3eHk2M2xHQjBreFJuN3I0?=
 =?utf-8?B?OHMweHZIZ2dNMDJBWENacjVaQjc0K0lpZ3Z1cS8wN2t4NSt1SzFKZ0xiOXpa?=
 =?utf-8?B?Tkg5WjBMNHNOcEFpM00xMm5va1FnUFY3dHRGcEoybm8xOXdyMTZnUi9hYkF5?=
 =?utf-8?B?aTA5akZRRkJXNnQybzlWQ0lGSktBPT0=?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4f1e54b4-f8f5-4c8c-4595-08d9a319a5bc
X-MS-Exchange-CrossTenant-AuthSource: CH2PR10MB4008.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2021 00:41:20.1134
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OH0z5tW8WXp6lpEZmvg2i1KS06JJqQ76BXk9eB5AcdhB5WbrVD46MXP2HhAJNUVI+EHhvOKurys0uvadEy0A+oARD4UfK6unZoMkv9uoBrc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB5273
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10162 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 mlxscore=0
 suspectscore=0 bulkscore=0 spamscore=0 phishscore=0 malwarescore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2111090001
X-Proofpoint-ORIG-GUID: ZO8jcQR2OJ7P4eE-Ia0KSW3wilj6WBw8
X-Proofpoint-GUID: ZO8jcQR2OJ7P4eE-Ia0KSW3wilj6WBw8
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 04.11.2021 01:25, Sean Christopherson wrote:
> Stop making a full copy of the old memslot in __kvm_set_memory_region()
> now that metadata updates are handled by kvm_set_memslot(), i.e. now that
> the old memslot's dirty bitmap doesn't need to be referenced after the
> memslot and its pointer is modified/invalidated by kvm_set_memslot().
> 
> No functional change intended.
> 
> Signed-off-by: Sean Christopherson <seanjc@google.com>

Reviewed-by: Maciej S. Szmigiero <maciej.szmigiero@oracle.com>