Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 9 Nov 2021 01:10:47 +0100
From:   Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= <kw@linux.com>
To:     Babu Moger <babu.moger@amd.com>
Cc:     tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
        dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
        clemens@ladisch.de, jdelvare@suse.com, linux@roeck-us.net,
        bhelgaas@google.com, linux-kernel@vger.kernel.org,
        linux-hwmon@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH 1/3] x86/amd_nb: Add AMD Family 19h Models (10h-1Fh) and
 (A0h-AFh) PCI IDs
Message-ID: <YYm8h1wDTAm7Rkf5@rocinante>
References: <163640820320.955062.9967043475152157959.stgit@bmoger-ubuntu>
 <163640828133.955062.18349019796157170473.stgit@bmoger-ubuntu>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <163640828133.955062.18349019796157170473.stgit@bmoger-ubuntu>
Precedence: bulk

Hello!

> Add the new PCI Device IDs to support new generation of AMD 19h family of
> processors.

This commit message matches the spirit of past additions very well, as per:

  commit b3f79ae45904 ("x86/amd_nb: Add Family 19h PCI IDs")

Admittedly, it would be nice to know what platform and/or generations of
AMD family of CPUs this is for.  Unless this is somewhat confidential and
in which case it would be fair enough.

For the following PCI related changes:

[...]
> --- a/include/linux/pci_ids.h
> +++ b/include/linux/pci_ids.h
> @@ -555,6 +555,7 @@
>  #define PCI_DEVICE_ID_AMD_17H_M60H_DF_F3 0x144b
>  #define PCI_DEVICE_ID_AMD_17H_M70H_DF_F3 0x1443
>  #define PCI_DEVICE_ID_AMD_19H_DF_F3	0x1653
> +#define PCI_DEVICE_ID_AMD_19H_M10H_DF_F3 0x14b0
>  #define PCI_DEVICE_ID_AMD_19H_M40H_DF_F3 0x167c
>  #define PCI_DEVICE_ID_AMD_19H_M50H_DF_F3 0x166d
>  #define PCI_DEVICE_ID_AMD_CNB17H_F3	0x1703

Acked-by: Krzysztof Wilczyński <kw@linux.com>

	Krzysztof