Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Maciej S. Szmigiero" <maciej.szmigiero@oracle.com>
Subject: Re: [PATCH v5.5 15/30] KVM: Use prepare/commit hooks to handle
 generic memslot metadata updates
To:     Sean Christopherson <seanjc@google.com>
Cc:     James Morse <james.morse@arm.com>,
        Alexandru Elisei <alexandru.elisei@arm.com>,
        Suzuki K Poulose <suzuki.poulose@arm.com>,
        Atish Patra <atish.patra@wdc.com>,
        David Hildenbrand <david@redhat.com>,
        Cornelia Huck <cohuck@redhat.com>,
        Claudio Imbrenda <imbrenda@linux.ibm.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>,
        Joerg Roedel <joro@8bytes.org>,
        linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu,
        linux-mips@vger.kernel.org, kvm@vger.kernel.org,
        kvm-ppc@vger.kernel.org, kvm-riscv@lists.infradead.org,
        linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
        Ben Gardon <bgardon@google.com>, Marc Zyngier <maz@kernel.org>,
        Huacai Chen <chenhuacai@kernel.org>,
        Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>,
        Paul Mackerras <paulus@ozlabs.org>,
        Anup Patel <anup.patel@wdc.com>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Albert Ou <aou@eecs.berkeley.edu>,
        Christian Borntraeger <borntraeger@de.ibm.com>,
        Janosch Frank <frankja@linux.ibm.com>,
        Paolo Bonzini <pbonzini@redhat.com>
References: <20211104002531.1176691-1-seanjc@google.com>
 <20211104002531.1176691-16-seanjc@google.com>
Message-ID: <84daccb5-9eec-011d-a0f7-a6af38a124da@oracle.com>
Date:   Tue, 9 Nov 2021 01:40:49 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
In-Reply-To: <20211104002531.1176691-16-seanjc@google.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Qjhwcm15YndLSDJMQ1k2THF6V3cxWVo3SWdSUndBWkpEOEF2SXd6aHdqU2JB?=
 =?utf-8?B?eDRCRm9aV3YzY0ovUTdFSExoWDRRTzZWVHhSUEF3U3ZPSEd1K2NSSG9ETC94?=
 =?utf-8?B?dGtIUzE5N1IzSmU3R2xoeDNvajRWWFErTVN5UWY3UWhZdGs4WFEzcUNtSVFm?=
 =?utf-8?B?SVE4OFM0dHh5cXovRHNvS0hCT0JUdWZLL2lXbFlDdXJsUmFjbzFjU2xOdTBs?=
 =?utf-8?B?ZnRJMzg0T203dTVXVjFxZUl5b1hMWll0RFdxQS84azdXRnZvKzZ0b1J1LzA0?=
 =?utf-8?B?MzF0N0dldDJTanBUVVA4aWpXVjVFRUxoSTQvKzJhSkprTTc4ZnZGN1E1b29n?=
 =?utf-8?B?dml5NzAvTnFWNzcyZkFwSTV1S0FTNDZzWFlZYStRQmFkM0l0UEMxVjFpSytu?=
 =?utf-8?B?dGlIUEZTZTNSS0tlOWZvSVp4QkN0Zm40ZG1LeVpnZ1NaalhWa2hwcGN4cHJR?=
 =?utf-8?B?VjltcS82bUNYSGdwanlWQk9vNjRTdjFKbHY4ZVRwQUVNYVFlUEZFUEE4Y2lD?=
 =?utf-8?B?T0VLeEZVNWlia1FpZ0UvekYzNkFwdDJqNFh0ZmswZkFZY1hmbmk0V0FvYnZM?=
 =?utf-8?B?RjNWNFFyTk4xdHU1NVUxWDA1cUdNbHFGNUdwbVRjYWdsbEFoUUdrWEZlbEZs?=
 =?utf-8?B?NTFiYkdhTUs4WnBXTFQ1WXo2b2ZwaDNXSUV0SmJiNk5JZjNUNHYwYmF3anZQ?=
 =?utf-8?B?bWpuQ2J3Q3BiYTNva3NGbUR3eVpHZHJNOEJmMGFuZ3EwSzgyQkJqY0ExSUQ5?=
 =?utf-8?B?b21VTUxzT2g5d3gwY2k2cHExUWdZSmRmQzVoajdhMVhQanB0WmZFWkFEL2VU?=
 =?utf-8?B?Y0JzaDNVcGxGSEQ3T09FNzYrNEs3Q1g1SXZubUZzV09lRTNhdGlnMGpVanRC?=
 =?utf-8?B?VzhOS3ZwZVVjRndhSXJhNFM3VmZOMEI5WnhSbjErZ2lLTVI4cGwyWXFEL2N0?=
 =?utf-8?B?RGtodzkyZzVLNW15NzdFWDVlZXI3L200MjU3SGxFLzV4WFZhSytlNnQvbXlE?=
 =?utf-8?B?RFA4bDNQT1VGTGFLdi9VTndSSlJHRHZGOXpKNExhRi9EQjFDZXFrL1pKeEJy?=
 =?utf-8?B?WDQ2Yy9BYVJsNUxtWFZlaDZYcDEzeTZkOTNRSVFpWU10TzFBMnc2RnpIOE9Y?=
 =?utf-8?B?K2RLV2RTVk5FdVIwY0dHZGFBSHZ0WEpyT1RCYVJwejAzSnFDUzdHZFVwSnJx?=
 =?utf-8?B?bHlwN2ltaDVnTEhxR1VZQkhpV3NEamdlTTN6RHhkV2sxdXkrUHFFd0NIRG5W?=
 =?utf-8?B?TUZtWC9wcDY2d2pBNFd3RnduTngwZVV6bFY4S2d5OXcxeDhYazhFR1FIVWp2?=
 =?utf-8?B?RHp1VTJJbHBrd0hoYTFlSVdiK2hBSFZEZnJDYWhXQXErRzZHa1ZuZC9rbWZM?=
 =?utf-8?B?eXAwOFR0TVo0OExPYi9YYkZVak1PcVdkWE9yUitFcTZNNnhhTWRhVW1oMnI3?=
 =?utf-8?B?dFhNdlNhN01MUVM2R0V4YjFtNWVtQWRTOW5Fdklad0JQRGFmVGwyRnlvN0tK?=
 =?utf-8?B?MDU3V1RaNEZoNndQS0pxUGI4NzdQOWdKaXp6b3U0QXVsVStwR3l4bEdpamJw?=
 =?utf-8?B?N2NXejNvMndqeGRYMzJQK004MzIzQnVpeWxlaFVjbEVLVG1NVmxRUSsxRWJl?=
 =?utf-8?B?Vkl6cXdyY2ExTTExUGFHN3dtYlRXODNEN21sZ0svSE9abUNlSkEydXQvNU4v?=
 =?utf-8?B?SXRTem11allEdzR1dzZFajNEZmo3Y2swOFA1NnhPQXhQbmp1Uk0zaWY2eTRG?=
 =?utf-8?B?OEdSUllxSGJHb09GaUs3YUJLamZTdEJ2bDFHQ3VNUi9iWjJKaWZiT2NISEpI?=
 =?utf-8?B?MUpiLzJadGJMYXJpakY5K3NyUEJMM2c1Qng4N1NRVFFWV2QxbFR2dW8wYnJD?=
 =?utf-8?B?VUhMT2RGYWhBbkFGUUF0UEhIbmxwK1RYLzJhU3RUQjdvZWxSRGNiTXozVnBm?=
 =?utf-8?B?QS9TU095WDBNN1NVZTN0L243SjZFNHg3WS8wckltMUlvYnpFeHlRSUdaZmNP?=
 =?utf-8?B?eHpJRWVQOGlTY2dnMXFWR2dpdzBPMG1kNExyL2VBZmdTV1hncHpvQks3cm5h?=
 =?utf-8?B?THREMTlGK1I5QXZvM0Z1TGw0dHk1QUZTSVJWS0pSSzYyNXovcFJLTHFKYVpt?=
 =?utf-8?B?SHh2MFdsMkpEcW9nWno2ZTJ2b0xHOG85SkpjQURIZzl2aUNzQmVNR1RTVFRF?=
 =?utf-8?B?RlVoRHlJNlkvWkpOZ2R2R0czNXFyUlkwa0VjY3N4alpPRkdRR1JLbFlFcnlB?=
 =?utf-8?B?UFBscmVnMFp4TFNKREZiMk9DSUNnPT0=?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 68eeff40-30dc-4378-6672-08d9a319998e
X-MS-Exchange-CrossTenant-AuthSource: CH2PR10MB4008.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2021 00:40:59.6921
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: agFiluKbWE5ucQ6fedRlXIcmf1rbaihPiNCoWjS0jLNPouoaJVLkuBL/ZIdNR2MJ/3rFnEnFKRNV2FJlXwIXGxQrkn+oCPwgyneRI7XLQl4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB5273
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10162 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 mlxscore=0
 malwarescore=0 spamscore=0 adultscore=0 suspectscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2111090001
X-Proofpoint-GUID: 4BL8KN-eMpRww0lFSDqcHzpUBScdvP64
X-Proofpoint-ORIG-GUID: 4BL8KN-eMpRww0lFSDqcHzpUBScdvP64
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 04.11.2021 01:25, Sean Christopherson wrote:
> Handle the generic memslot metadata, a.k.a. dirty bitmap, updates at the
> same time that arch handles it's own metadata updates, i.e. at memslot
> prepare and commit.  This will simplify converting @new to a dynamically
> allocated object, and more closely aligns common KVM with architecture
> code.
> 
> No functional change intended.
> 
> Signed-off-by: Sean Christopherson <seanjc@google.com>

Reviewed-by: Maciej S. Szmigiero <maciej.szmigiero@oracle.com>