Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Maciej S. Szmigiero" <maciej.szmigiero@oracle.com>
Subject: Re: [PATCH v5.5 04/30] KVM: Open code kvm_delete_memslot() into its
 only caller
To:     Sean Christopherson <seanjc@google.com>
Cc:     James Morse <james.morse@arm.com>,
        Alexandru Elisei <alexandru.elisei@arm.com>,
        Suzuki K Poulose <suzuki.poulose@arm.com>,
        Atish Patra <atish.patra@wdc.com>,
        David Hildenbrand <david@redhat.com>,
        Cornelia Huck <cohuck@redhat.com>,
        Claudio Imbrenda <imbrenda@linux.ibm.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>,
        Joerg Roedel <joro@8bytes.org>,
        linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu,
        linux-mips@vger.kernel.org, kvm@vger.kernel.org,
        kvm-ppc@vger.kernel.org, kvm-riscv@lists.infradead.org,
        linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
        Ben Gardon <bgardon@google.com>, Marc Zyngier <maz@kernel.org>,
        Huacai Chen <chenhuacai@kernel.org>,
        Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>,
        Paul Mackerras <paulus@ozlabs.org>,
        Anup Patel <anup.patel@wdc.com>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        Albert Ou <aou@eecs.berkeley.edu>,
        Christian Borntraeger <borntraeger@de.ibm.com>,
        Janosch Frank <frankja@linux.ibm.com>,
        Paolo Bonzini <pbonzini@redhat.com>
References: <20211104002531.1176691-1-seanjc@google.com>
 <20211104002531.1176691-5-seanjc@google.com>
Message-ID: <94ce4359-a87b-cbb1-0d47-acc5257d97b6@oracle.com>
Date:   Tue, 9 Nov 2021 01:38:36 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
In-Reply-To: <20211104002531.1176691-5-seanjc@google.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cnhZaGpZaUphSVNOd1F2WjgxbWlyc1IrSmZUdE9xWWFmZ0JJRTA0NWZZdzBX?=
 =?utf-8?B?MWxWM0xmbjFZbXZBdjNZaktmT3l4bzZYMmlMRVlNRWJPQnVpOFlSay9adWpq?=
 =?utf-8?B?N0dZQTJxSEM5ME5ObE5mMUNvbXpIWDVTS1J0T3p4aStQMEpsMjVvb1MvcDg1?=
 =?utf-8?B?SlFDbVRDL0tTRzRVOEE3UG0xanB6aFFjdUxDKzM4aVpDcVo0Q21hdTdNYXdC?=
 =?utf-8?B?cll1KzNoeFYxQ3Q1enZvNWJJVEhGK3AzZ2F2d2REdENsRTh2c0RFU1ZKc0dF?=
 =?utf-8?B?RmNTWkdaWjJPeUNPOGVFN2hpV0FjbDE2RkpmMFZxbjJlMlJEUklya2IvUEJr?=
 =?utf-8?B?WmVobi8rcWFFZHNxakg5dnpqeHdOelEvZUJxZTIzZGVzQmVXdmdJdUc5UUh2?=
 =?utf-8?B?UU5KbDJrZ1ZhL3VQQTZCMjlnbEtOWkc2OW5ObnN6MzdwalY3OFEyVHNOalFM?=
 =?utf-8?B?VzZkRk40VjNlSTFZSnpBSUF3M0VmblNrRjVIZ0Vwb2dHUmxJWWpGb3ZvK0ov?=
 =?utf-8?B?UmJKREZDVEtvbEk0aFZLQW9HV0cvZ1NxQWo2Z3RweXVFMFNIWmhJYVVGYUp6?=
 =?utf-8?B?WWMvSGdKbTM3eHRlTlNrR0pkaEZsbEtYV1pCQUlwSEFvNkpzSTEwTWwrejlF?=
 =?utf-8?B?YmI1a2Vxc3pTR1ZRRUtvTHZJdC9JT25qSGc0cUxzZml2OEllb0c4U01aVlFu?=
 =?utf-8?B?MU1iajU1Nit1UFl5ODc3UThrMjRPTFVYUk80UTh0Q1lXQzRpdHRUditLcUw1?=
 =?utf-8?B?R1JCbld4amtVaUVyQk80NVkwcDhaMStMaDJHY2o5bFZnbjg0Z2RUYVRIaHpF?=
 =?utf-8?B?bHFBbC9iWXBaVmZrQkFneGdMREl4VG91M1NzNUZqYnJhMEhFZGF5bVl6RlZB?=
 =?utf-8?B?MUV5ZUpwbVNtekUyWHNBYnZmd1dkMlBMQ3N5RWpEWEFSVkJGNndrdUh4TGVL?=
 =?utf-8?B?L0s1S0JwNW95d2FTcnpOS2pwY0hiSEkzNjY1c0lGUUVpbm90VVhkU09Mek1J?=
 =?utf-8?B?b3lWN0JRWitRbHZpSGRJYzkzYnRMNEV3S0NRWEZYeGtFQ0M4N1Z6OXJkdjhR?=
 =?utf-8?B?cGdPK3VVL09QRUdFTWp4YStuTnVHcXo3WmduUFFKQXZBZ3dpMkZydkZFZGty?=
 =?utf-8?B?Y0xFVWVuODNzcnRTNnd0WDBZMThxUEdIWGpDRDRKYm1qR0RTTkFEdHRPUFJN?=
 =?utf-8?B?aEpHcUNaVHRHRXdaVEVmZEJLNVhXTzBVN1FqNTA2Z29jRk9TTHhmRFdnSkdj?=
 =?utf-8?B?ZktNTm5WRjNoekNiOXhOVnJlWDhjMjBWam93aDkvWHFOSXMzRktZc2NaT0dK?=
 =?utf-8?B?eWZHN2Fka1RMeDBNeERreDZGdzJua0lmamdmdm1MQjhpRzdBMTdjbEUrekVa?=
 =?utf-8?B?cGFqSXV2SmIwdDNvZ245amw5RXMwZm1CMkhMYU41SVFNU1Z5RkxpeERxdUJr?=
 =?utf-8?B?YU1lcE1TNGVBMFFzT2czYUJJaitPbmVyZFp6T2hWVjFPbWVocWpNTUJLY2hI?=
 =?utf-8?B?ZENoVXl0Wkl1ZzIzRmk5eVpMYWM3eGxkRXB3UEFHTENTQnVyaW5wRmtMNDE3?=
 =?utf-8?B?bjNGamtiMmpMMlFGSDRrdU1ZdStqZXZXWGtwTFBxUE9CMlZ5aVhLeG5IbjBE?=
 =?utf-8?B?bXhZZzR2bEYvajBBVXcyb1JrZzJNUkdyQ0J1bWI4S2syUFIzSm1BM3d5M3FK?=
 =?utf-8?B?SjQwZG03dFBXa2FxNEdrblRrbnp4b1UrVGE3d2FMb0NzeTc5RjkzSFFkbzd1?=
 =?utf-8?B?VVIrRCs5SkcxQ01zZlR1cjlHR3d5c3dMTXVBaWRHVm9uSW84ZWdsMTc5Q1JW?=
 =?utf-8?B?eENpUVJ6NXh4N01RWlNQMDV4a1NxaEliQ0FCaW5tbEs4OSt1aTYrT0NjbGtl?=
 =?utf-8?B?SFYxbWtDNURoQ2g2eS9paWk4V293N1NIMUlJYkFmV2Z3UXBqOVhhS2RHT1lY?=
 =?utf-8?B?eE92WTRwSXE5NGhFa1RDWUVxRDhnRmYzM1BXWmZBeHZ5UUFsOEJoUUkvSzZH?=
 =?utf-8?B?TWc1d1hEUHpQQ0V1VzBYRmZtUkI5Z0ZpbnEvV1BVRks1ZmpnbFhQdkZZQjdU?=
 =?utf-8?B?UkZMM2tZZVlZYWtkRWVmVXd3aGtFOGNnNkdrclozTkYxNlZGSUhoNFBqN2R1?=
 =?utf-8?B?ZGtLNjhOS3lhazVVVDBxOVc0M1RSOE8rWDFrUHBSSkpocnpnSDltS0h6K0Fu?=
 =?utf-8?B?dlBMQWFTbCtLT1k3bVd4alFHUHltUE8rVGQwRzRveW9WYkNqQkNqMXhrUjZZ?=
 =?utf-8?B?akVVZGhYZFJyQU9uU003VU9IOVpnPT0=?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cdc1370f-eaa6-438e-35ce-08d9a3194a2a
X-MS-Exchange-CrossTenant-AuthSource: CH2PR10MB4008.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2021 00:38:46.5994
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6LuNPicQP+1kiRpgn3FkT8NioYe8mLEf2TVbYwYuJGnYEAmQKQHCRw9XXlyDgFG5AJQ/FtyBNxJb2+BOwthvkvLW/9EWXiE3kmkDvoz77Ts=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB4972
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10162 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 mlxscore=0
 malwarescore=0 spamscore=0 adultscore=0 suspectscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2111090001
X-Proofpoint-GUID: 8mk2pPjupQ8kvT71pHe8dG2G_kvixzS7
X-Proofpoint-ORIG-GUID: 8mk2pPjupQ8kvT71pHe8dG2G_kvixzS7
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 04.11.2021 01:25, Sean Christopherson wrote:
> Fold kvm_delete_memslot() into __kvm_set_memory_region() to free up the
> "kvm_delete_memslot()" name for use in a future helper.  The delete logic
> isn't so complex/long that it truly needs a helper, and it will be
> simplified a wee bit further in upcoming commits.
> 
> No functional change intended.
> 
> Signed-off-by: Sean Christopherson <seanjc@google.com>

Reviewed-by: Maciej S. Szmigiero <maciej.szmigiero@oracle.com>