Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Maciej S. Szmigiero" <maciej.szmigiero@oracle.com>
Subject: Re: [PATCH v5.5 16/30] KVM: x86: Don't assume old/new memslots are
 non-NULL at memslot commit
To:     Sean Christopherson <seanjc@google.com>
Cc:     James Morse <james.morse@arm.com>,
        Alexandru Elisei <alexandru.elisei@arm.com>,
        Suzuki K Poulose <suzuki.poulose@arm.com>,
        Atish Patra <atish.patra@wdc.com>,
        David Hildenbrand <david@redhat.com>,
        Cornelia Huck <cohuck@redhat.com>,
        Claudio Imbrenda <imbrenda@linux.ibm.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>,
        Joerg Roedel <joro@8bytes.org>,
        linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu,
        linux-mips@vger.kernel.org, kvm@vger.kernel.org,
        kvm-ppc@vger.kernel.org, kvm-riscv@lists.infradead.org,
        linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
        Ben Gardon <bgardon@google.com>, Marc Zyngier <maz@kernel.org>,
        Huacai Chen <chenhuacai@kernel.org>,
        Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>,
        Paul Mackerras <paulus@ozlabs.org>,
        Anup Patel <anup.patel@wdc.com>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Albert Ou <aou@eecs.berkeley.edu>,
        Christian Borntraeger <borntraeger@de.ibm.com>,
        Janosch Frank <frankja@linux.ibm.com>,
        Paolo Bonzini <pbonzini@redhat.com>
References: <20211104002531.1176691-1-seanjc@google.com>
 <20211104002531.1176691-17-seanjc@google.com>
Message-ID: <623f2d6e-6f75-03a9-2932-61190eebd30a@oracle.com>
Date:   Tue, 9 Nov 2021 01:40:57 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
In-Reply-To: <20211104002531.1176691-17-seanjc@google.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bjFQakh2STlwR2xwK0h1Z2VablZic20yTENPRHhTUHBKMWpjRlF4NlJpdGZ2?=
 =?utf-8?B?YlowV1NXUlJVUU1KVmliNHJFdHhpaTQ4SEtTcXExdXJzV3pXS29XOTdtSjFW?=
 =?utf-8?B?Z2MyMXFRWDlIYlcxQmRXWkl2RHRqQzhUWVV5YUFULzdGMWI3SHFaZDRIQWxL?=
 =?utf-8?B?UkJ0ZU54elFIM1grQ2JnaktYRytGR1dsOUVjS0RkbkphR2lKVmNza3ZlZklI?=
 =?utf-8?B?eDVUN29oeGRlTENDb3BPbWxPdlIzMGpYUU0ydGVKamp4VkNGUld3dzFuaEFo?=
 =?utf-8?B?RXVQbFNSQmNHVHdRQWE3K1BGWTdpUW5URU4zN3FmOXlWcWJpRThIampYeSs2?=
 =?utf-8?B?T3lqRXNTL0pwVENDZXc2QlBveHNEdmg4bGNrSG9UOXlvd3ZlSDlXREdxRmZ3?=
 =?utf-8?B?bjNwYm1YQU44ZU8yUFRla0ZYRFdHNnRYMU1EQmdGN3VtUWJieHVLS2ttaEtl?=
 =?utf-8?B?dWhMODNNYWpMQWNTU3ljSlliRFFZSmFsMUdKSkdlc1lOTXhKa1ltQ1BRMmRi?=
 =?utf-8?B?OVBUd1p4anlpNlpyM0I0V3dleTVOM1ZmOXhPOWU4SUtHQTdUbUkyRElycUR3?=
 =?utf-8?B?c3dXdG0yNHRzQ3Q1eHVzM3F0Nld6azVpTXVxWUFYVDVIOStQb25tWTNlMXM3?=
 =?utf-8?B?N1BldHdyS2VhMnBHQ1lDYzBUL1VOckJBbnpNUjZpWnRiblFCYnNHNmRoTTFC?=
 =?utf-8?B?SWtCQ0hZV2NaeXlNaGRhNitXWEdZUHJpaEh3TU55TiszRlB5R0tpQUZ4N0xT?=
 =?utf-8?B?dGUrRzMxZ0c4eUlxVmRITmtIOSt2dWpmWnQ5NGdYZ0kxSWpEYlZJQ09aTjdh?=
 =?utf-8?B?bFFtZGJwYm00Sm9aWjdqLzJOcDRhaXF5S3VWdEpVVXpGSFBRVy9UeHd3djJY?=
 =?utf-8?B?VzlyZ2hFTVpYbUZjWWZyWHJwUjVDYWJyTFFkbEpUMFFyOWlOK0pHbjlLSy9M?=
 =?utf-8?B?cmJOSEYxRG5oNzQ1VXdJTlZGWkpWeEtleFZ2SFozQm5Kd0RSMUc0cG4ySDAz?=
 =?utf-8?B?ZHlQRUVuL2dzblhMT0xGa01nOFBjYWJRQVBGRnlRSXYzVk1qam1SSVAyK1ZX?=
 =?utf-8?B?Tk9SM3ZZRmpyZVhvTVF4ZEJtU0IzOUlDc0ErdU5jYzQyVUZweHRtSTRUZGZQ?=
 =?utf-8?B?RGFoUEN1S0hWNDlTS25ZZERLcTlNc2NPeTE4Q2JoN1c2bDBpWldYYnUzNmhB?=
 =?utf-8?B?LzNGbk1QOXNlSnhrTnF2Q08xclpCaXJITlQ5cDVTcHNxZnA2WVZ5T2pMVWYy?=
 =?utf-8?B?SkVMMlYyOEI2M1M1Vi9YdjRkakVaTkhGQ29ZR3hrbzdMSWRrS3RrR2NXNFpG?=
 =?utf-8?B?UzdvbkFnTkRqcHlsekorclRydzkzMTRBRWtZajBBdU0xQ0ZDWjVHUjQ0L1Rz?=
 =?utf-8?B?dzFqd0hSNEp3NGdCcGdzVjhmNUJXWW94dHhXUkFaMFJoczZ3Ym5PQlduVnJV?=
 =?utf-8?B?b3haS0hRR0tBNFdVU01SaFlIZERZYWJHSFN4Z3lSVFdtNTV6Q2sxMDZkZWx4?=
 =?utf-8?B?REhvU3piVGJ6Tmxiem40ejNZV0xxODU5Zk94YjlzUGVxN1dwalhVUzU3Z09q?=
 =?utf-8?B?RS92ZjhkRzFRUkg2Zm9oWldxNmRITUxsVTMrd3VCL3h2VGxnaCsxZVY1STNo?=
 =?utf-8?B?NFRnQlpUbjFQV3F1bFlwMFVTRE1MT3lLRUlySWxNZWl0WDhGcW40OGdPZFJK?=
 =?utf-8?B?NXlOZ0xVOUYyU2xMMUpHSGJzQlJLMlB2SWRFcUdyY0E2dk5vN0Y5Q0t1M2Jw?=
 =?utf-8?B?VVZoL2pMVmplV2FybHI1blVqK3lrQ1NsKzB0T0VvbUNQL0VIZFkyVzJGWFFG?=
 =?utf-8?B?RFpqYnhESkRIOUtIU3R5eTVGVmw5elROZlcycC9rWlpTRDJkV0tJemRkdnRj?=
 =?utf-8?B?YzR2ZGJtaVBuZmh6UUN4QlpNeHFRUlJXdHNhd0tIUHRzWk50STIzTW9hcDd5?=
 =?utf-8?B?dVZOREV5WCtvZ3VpV1VXSjg3S1hpeDNoNUVnb1llRld2Tlh3OExCb2N5dmd3?=
 =?utf-8?B?TkVBOE5rQTEwVWxLNDJ4TjRzeDNCVTFmdWgrTUlFOUUzVkk5OU95MjI0MXZn?=
 =?utf-8?B?eHFYZEk5UWVzQkMweUZlM285K0lwTDA5ZjdTc0VYZ0RwbjRvSTJaRGs5Vko1?=
 =?utf-8?B?ektlZ0dmVysrS2hieTdlT0pybjJrRDV2SGJZVGR5SEYzUTArcjcvQ0RrK2ha?=
 =?utf-8?B?MHZ6LzN0NlhsVk1XYlZwOUZLVXFMaHhCM2NSYkx1TVNhS3l0bXpXWWs1eVdq?=
 =?utf-8?B?eklkVmZ2d2tjTThuRVVscnhRMXFnPT0=?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f02a8c77-3f78-416e-69f5-08d9a3199e6b
X-MS-Exchange-CrossTenant-AuthSource: CH2PR10MB4008.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2021 00:41:07.9913
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: k5clREpClXIKSoVyBVw73jvlgdlVWrdL3tUW0h85cg/XYDM5uZYhj7KDGCVryKWb5CG84jdEqsXn173KOr0oedFR5K24CkmfKspaTvwREYM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB5273
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10162 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 mlxscore=0
 suspectscore=0 bulkscore=0 spamscore=0 phishscore=0 malwarescore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2111090001
X-Proofpoint-ORIG-GUID: PoJFbYJEWeqJE3HC_Y3qRNwWDif6TPGR
X-Proofpoint-GUID: PoJFbYJEWeqJE3HC_Y3qRNwWDif6TPGR
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 04.11.2021 01:25, Sean Christopherson wrote:
> Play nice with a NULL @old or @new when handling memslot updates so that
> common KVM can pass NULL for one or the other in CREATE and DELETE cases
> instead of having to synthesize a dummy memslot.
> 
> No functional change intended.
> 
> Signed-off-by: Sean Christopherson <seanjc@google.com>

Reviewed-by: Maciej S. Szmigiero <maciej.szmigiero@oracle.com>