Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] powerpc/embedded6xx/hlwd-pic: Add missing of_node_put in
 hlwd_pic_probe
From:   He Ying <heying24@huawei.com>
To:     <mpe@ellerman.id.au>, <benh@kernel.crashing.org>,
        <paulus@samba.org>, <maz@kernel.org>
CC:     <linuxppc-dev@lists.ozlabs.org>, <linux-kernel@vger.kernel.org>
References: <20211103014833.163615-1-heying24@huawei.com>
Message-ID: <21d5814e-cd51-ab24-f673-b2da5e784ce8@huawei.com>
Date:   Tue, 9 Nov 2021 10:07:44 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <20211103014833.163615-1-heying24@huawei.com>
Content-Type: text/plain; charset="gbk"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

kindly ping...

?? 2021/11/3 9:48, He Ying д??:
> Early exits from for_each_compatible_node() should decrease the
> node reference count.
>
> Signed-off-by: He Ying <heying24@huawei.com>
> ---
>   arch/powerpc/platforms/embedded6xx/hlwd-pic.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/arch/powerpc/platforms/embedded6xx/hlwd-pic.c b/arch/powerpc/platforms/embedded6xx/hlwd-pic.c
> index 15396333a90b..a4b020e4b6af 100644
> --- a/arch/powerpc/platforms/embedded6xx/hlwd-pic.c
> +++ b/arch/powerpc/platforms/embedded6xx/hlwd-pic.c
> @@ -214,6 +214,7 @@ void hlwd_pic_probe(void)
>   			irq_set_chained_handler(cascade_virq,
>   						hlwd_pic_irq_cascade);
>   			hlwd_irq_host = host;
> +			of_node_put(np);
>   			break;
>   		}
>   	}