Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] fsl_hypervisor: Add missing of_node_put in
 fsl_hypervisor_init
From:   He Ying <heying24@huawei.com>
To:     <galak@kernel.crashing.org>, <timur@freescale.com>, <arnd@arndb.de>
CC:     <linux-kernel@vger.kernel.org>
References: <20211029032002.97355-1-heying24@huawei.com>
Message-ID: <18de7555-0d77-77ae-f357-dea07c73d771@huawei.com>
Date:   Tue, 9 Nov 2021 10:07:08 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <20211029032002.97355-1-heying24@huawei.com>
Content-Type: text/plain; charset="gbk"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

kindly ping...

?? 2021/10/29 11:20, He Ying д??:
> Early exits from for_each_compatible_node() should decrement the
> node reference counter.
>
> Signed-off-by: He Ying <heying24@huawei.com>
> Fixes: 6db7199407ca ("drivers/virt: introduce Freescale hypervisor management driver")
> ---
>   drivers/virt/fsl_hypervisor.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/virt/fsl_hypervisor.c b/drivers/virt/fsl_hypervisor.c
> index 46ee0a0998b6..ef5fcca4b8f0 100644
> --- a/drivers/virt/fsl_hypervisor.c
> +++ b/drivers/virt/fsl_hypervisor.c
> @@ -849,8 +849,10 @@ static int __init fsl_hypervisor_init(void)
>   		}
>   
>   		dbisr = kzalloc(sizeof(*dbisr), GFP_KERNEL);
> -		if (!dbisr)
> +		if (!dbisr) {
> +			of_node_put(np);
>   			goto out_of_memory;
> +		}
>   
>   		dbisr->irq = irq;
>   		dbisr->doorbell = be32_to_cpup(handle);